D1230: GBM remote access support for KWin

2018-03-25 Thread Ben Cooksley
bcooksley added a comment. The introduction of this has broken the FreeBSD Build. Please see https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/120/consoleText REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson,

D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

2018-03-25 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks! :) REVISION DETAIL https://phabricator.kde.org/D11661 To: lueck, #plasma, #localization, #documentation, davidedmundson, hein Cc: kde-doc-english, aacid, hein, plasma-devel, ragreen,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

2018-03-25 Thread Vlad Zagorodniy
zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Why does this patch have non-related changes? E.g. `GLRenderTarget::attachTexture`, `GLRenderTarget::detachTexture`, empty GLRenderTarget constructor, `GLRenderTarget::setTextureDirty`, etc? They aren't

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 445 - Still unstable!

2018-03-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/445/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Mon, 26 Mar 2018 03:11:25 + Build duration: 58 min and counting JUnit Tests Name: (root) Failed: 2 t

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 121 - Still Failing!

2018-03-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/121/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 03:11:24 + Build duration: 31 min and counting CONSOLE OUTPUT [...truncated 93

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

2018-03-25 Thread Nathaniel Graham
ngraham added a comment. @romangg so is this more of a request just for code review review, then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11469 To: romangg, #plasma Cc: hein, mart, abetts, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-moham

D11410: [RFC] Add option to make applet fixed width

2018-03-25 Thread Radek Hušek
Pitel updated this revision to Diff 30555. Pitel added a comment. - Replace checkbox with a checkable button - Add support for panel spacer -- currently we just check whether the applet is panel spacer and if it is we use `applet.configuration.expanding` instead of our `fixedSizeOverride`.

D11352: [RFC] Auto ordered systray

2018-03-25 Thread Radek Hušek
Pitel added a comment. > i would prefer the final version to be quiet Sure. INLINE COMMENTS > mart wrote in AbstractItem.qml:80 > This is probably not necessary: both plasmoids and statusnotifieritems have > ids that you can access (numeric for plasmoids, alphanumeric for > statusnotif

D11695: Update clock docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck updated this revision to Diff 30548. lueck added a comment. fix typo spotted by Yuri, thanks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11695?vs=30547&id=30548 REVISION DETAIL https://phabricator.kde.org/D11695 AFFECTED FILES doc/kcontrol/clock/index.docbook To: luec

D11695: Update clock docbook to 5.12

2018-03-25 Thread Yuri Chornoivan
yurchor accepted this revision as: yurchor. yurchor added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > index.docbook:55 > +When you log in to the &plasma; session while being online or when you > later > +connect to the Internet the access to on or more NTP

D11695: Update clock docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date + releasein

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 444 - Failure!

2018-03-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/444/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Mar 2018 17:19:06 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated 946.75 K

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 120 - Failure!

2018-03-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/120/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 17:19:06 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated 93

D11693: Update kcmnotify docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date + releasein

D1230: GBM remote access support for KWin

2018-03-25 Thread Oleg Chernovskiy
Kanedias added a comment. Done! Thanks for looking this through. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma

D1231: Add Remote Access interface to KWayland

2018-03-25 Thread Oleg Chernovskiy
Kanedias added a comment. - squashed before pushing - fixed all versions to 5.45 Thanks gentlemen, it's was 1 day more for the second birthday of this patch :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, roman

D1231: Add Remote Access interface to KWayland

2018-03-25 Thread Oleg Chernovskiy
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:5116fe0c6345: Add Remote Access interface to KWayland (authored by Kanedias). CHANGED PRIOR TO COMMIT https://phabri

D1230: GBM remote access support for KWin

2018-03-25 Thread Oleg Chernovskiy
Kanedias closed this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay,

D1231: Add Remote Access interface to KWayland

2018-03-25 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. Looks fine to me. Tested compilation as well as runtime with KWin's DRM+EGL backend. - Please change in comments the frameworks version number these changes are landing in. - I would like to have @davidedmundson look over this pa

D1230: GBM remote access support for KWin

2018-03-25 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Looks fine to me. Tested runtime together with your KWayland patch. Probably you know this, but please push as one commit only to master. INLINE COMMENTS > egl_gbm_backend.cpp:160 >

D11690: Update mouse docbook to 5.12

2018-03-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date + releseinf

D11688: Update mouse docbook to 5,12

2018-03-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date + releseinf

D11687: Update autostart docbook to 5,12

2018-03-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date + releseinf

D11551: use the new install_package form

2018-03-25 Thread Martin Kostolný
martinkostolny added a comment. > Is there something I may be doing wrong? I can see now that this change was applied and then reverted all over the plasma repositories so these are probably 2 leftovers. Sorry for the fuzz. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D11686: Update desktop theme docbook to 5,12

2018-03-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date + releasein

D11551: use the new install_package form

2018-03-25 Thread Martin Kostolný
martinkostolny added a comment. Sorry to be late on this. I cannot compile plasma-pa anymore after this change with error: Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc make[2]: *** No rule to make target 'applet/org.kde.plasma.volume-contents.rcc', n

D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

2018-03-25 Thread Burkhard Lück
lueck updated this revision to Diff 30498. lueck retitled this revision from "Fix wrong X-DocPath in kcm_launchfeedback.desktop" to "Fix docbook installation for doc/kcontrol/kcmlaunchfeedback". lueck added a comment. Restricted Application added a subscriber: kde-doc-english. rename dir doc/

D11606: [WebBrowser Plasmoid] Support opening external links

2018-03-25 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:65-67 > You can find a better solution. Especially as there's only 3 items (two > spaces) in this Layout. The layout is [<] [>] [address bar] [popup blocked] [ reload ] I want a space between everything except

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

2018-03-25 Thread Burkhard Lück
lueck added a comment. In D11661#233341 , @hein wrote: > I disagree with this patch - I renamed things for consistency for a reason and emailed i18n-doc, so I expect the docs to get renamed. Right you emailed i18n-doc, changed the X-DocPa

D11661: Fix wrong X-DocPath in kcm_launchfeedback.desktop

2018-03-25 Thread Albert Astals Cid
aacid added a comment. Your email said "master branch renamed kcmlaunch.pot to kcmlaunchfeedback.pot" you did never mention docs. Anyhow, are you asking Burkhard to change the patch to rename the folder? I guess that's also a fine solution. REPOSITORY R119 Plasma Desktop REVISION DET

D11670: [cursors] Add arrow cursor symlinks

2018-03-25 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e4620e09ded: [cursors] Add arrow cursor symlinks (authored by drosca). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11670?vs=30469&id=30482 REVISION DETAIL https

D11220: option to force FolderView icon-only presentation

2018-03-25 Thread Michail Vourlakos
mvourlakos abandoned this revision. mvourlakos added a comment. can be closed because https://phabricator.kde.org/D11651 was accepted... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart, hein Cc: sebas, broulik, hein, plasma-

D11651: FolderView applet respect panel maxIcon size

2018-03-25 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2683d4c6e60a: FolderView applet respect panel maxIcon size (authored by mvourlakos). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11651?vs=30420&id=30470

D11670: [cursors] Add arrow cursor symlinks

2018-03-25 Thread David Rosca
drosca created this revision. drosca added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY Add arrow -> left_ptr symlinks. Same symlink can be

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-25 Thread Martin Flöser
graesslin added a comment. In D10816#233128 , @fvogt wrote: > In D10816#233088 , @graesslin wrote: > > > In D10816#233074 , @fvogt wrote: > > > > > `XD