D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

ngraham added inline comments. INLINE COMMENTS > main_deviceless.qml:62 > + > +Column { > +spacing: units.smallSpacing * 2 Do you really need to define each individual column like this? Seems like a code small to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

abetts added a comment. In D11469#228987 , @ngraham wrote: > Some more UI comments: > > - Right now it looks pretty awkward with everything left-justified. Centering would seem to be more natural. > - Since the speed/acceleration is the mos

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

ngraham added a comment. Some more UI comments: - Right now it looks pretty awkward with everything left-justified. Centering would seem to be more natural. - Since the speed/acceleration is the most commonly-changed settings, let's move it up to the top. - I think we could put botto

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

ngraham added a comment. Ah, people are really going to like this. Instead of "acceleration", could we make the label say "speed"? I know "acceleration" is technically what it's controlling, but I think "speed" gets the point across just as well and it's more natural language--more in tu

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

romangg added a comment. This is supposed to land in 5.12 as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11471 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11471: [Touchpad KCM] Sync values to UI on Defaults in Wayland session

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY On Defaults the updated values need to be resynced to the QML part

D11468: [Mouse KCM] Add KWin Wayland backend

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY The primal goal of this patch is the addition of a new backend in

D11198: [libbreezecommon] add box shadow helper

zzag updated this revision to Diff 29858. zzag added a comment. don't forward declare Qt stuff REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11198?vs=29843&id=29858 REVISION DETAIL https://phabricator.kde.org/D11198 AFFECTED FILES CMakeLists.txt cmak

D11198: [libbreezecommon] add box shadow helper

hpereiradacosta added inline comments. INLINE COMMENTS > breezeboxshadowhelper.h:30 > +class QRect; > + > + I think the "rule" is to not use forward declarations for classes external to once project. Reason is that the upstream library might decide to turn a class into a struct, or an alias i

D10251: [RFC] Use mipmap filtering in window thumbnails

progwolff added a comment. Thanks! I tested it with several running applications, including windows with different apect ratios and combined previews for multiple instances of the same application. Looks great in every case. +1 from me! REPOSITORY R242 Plasma Framework (Library)

D11308: Use the default Plasma wallpaper on the lock screen

davidedmundson added a comment. > (btw that leak i think should be solved, @davidedmundson also has a rewrite of the wallpaper code which should make it take less memory, as right now the first few times it changes memory gooes up not for an actual leak but more for the management not being

D11198: [libbreezecommon] add box shadow helper

zzag updated this revision to Diff 29843. zzag edited the summary of this revision. zzag added a comment. - add comments REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11198?vs=29535&id=29843 REVISION DETAIL https://phabricator.kde.org/D11198 AFFECTED FIL

D11455: Update kcmstyle docbook

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY remove menubar style options add info ho

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik updated this revision to Diff 29832. fredrik added a comment. Rebase on master. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10251?vs=26374&id=29832 REVISION DETAIL https://phabricator.kde.org/D10251 AFFECTED FILES src/dec

D11447: No longer export QT_QPA_PLATFORM env variable to the session

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY As discussed the env variables are no longer exported. Thus

D11446: Use platform detection from KWorkspace in Powerdevil

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY On a wayland session powerdevil needs to use Wayland platfor

D11445: Use platform detection in SystemSettings

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY SystemSettings needs to run on Wayland in a Wayland session

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b5c326996309: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org