Re: What does LTS mean again?

On Tue, 20 Feb 2018 23:34:33 + Jonathan Riddell wrote: > On Tue, Feb 20, 2018 at 09:13:42PM +0100, Sebastian Kügler wrote: > > Hi, > > > > I know we talked about it extensively and even put it into writing, > > but I can't find it anymore. What does our LTS promise for 5.12 > > entail? >

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

apol added a comment. For some reason, didn't see this review >.<. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai,

D10692: parent full representation to the proper window at start

apol added inline comments. INLINE COMMENTS > systemtray.h:30 > class QQuickItem; > +class QQuickWindow; > class PlasmoidModel; Why? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: apol, broulik, hein, davidedmundson, plasma-deve

D10091: Combine source and version into a single piece of metadata

acrouthamel added a comment. I would also change `Also available in` to `Also available:`, since adding the version number in front of the sentence doesn't flow correctly in English. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10091 To: ngraham,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham added a comment. Thanks! I'll land this later tonight, if Alex doesn't beat me to it. REPOSITORY R134 Discover Software Store BRANCH diffD10701 REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouth

D10429: Disable the title bar separator by default

abetts added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas

D10032: Swap play/pause icons in mediacontroller plasmoid

rizzitello added a comment. We place this item in the system tray by default. This being a place were users expect to be able to at a glance get some quick info about things their system is doing. While media is playing the play icon is what most users would expect to see. I do agree that th

D10429: Disable the title bar separator by default

rizzitello added a comment. I'm a breeze dark user and the current color is just way to strong on this theme as @ngraham said above. It was quite jarring to have this bright line on my window out of nowhere. If we can not find a more muted color then my vote its +1 disable no need to remov

D10697: Make the badge text readable on dark color schemes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:00f113eacb03: Make the badge text readable on dark color schemes (authored by mwolff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10697?vs=27637&id=27725

D10728: Improve multi-desktop folderview behavior

amantia added reviewers: Plasma, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1072

D10729: Improve detecting D&D between two screen showing the same URL

amantia added reviewers: Plasma, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

akrutzler updated this revision to Diff 27724. akrutzler added a comment. Rebase to origin/Plasma/5.12. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10701?vs=27642&id=27724 BRANCH diffD10701 REVISION DETAIL https://phabricator.kde.or

D10591: forcefully activate popup windows when they open

mart added a comment. An alternate idea: - we open it without giging focus - the current show time is 5 seconds - after 2 seconds (1 would be enough?) we check if there was user activity with kidletime - if there was activity, if the notifier doesn't contain the cursor or isn't foc

D10723: hide primary display combo when not supported

sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY Some backends, for example the kwayland backend, do not support

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27715. mart added a comment. - new approach: parent full reps to the dialog only when needed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27710&id=27715 BRANCH arcpatch-D10692 REVISION DETAIL http

D10722: other preload microoptimizations

davidedmundson added inline comments. INLINE COMMENTS > svgitem.cpp:50 > > +void SvgItem::componentComplete() > +{ I don't see how this makes any difference. Every setSomeProperty already calls scheduleImageUpdate regardless of whether we're complete or not. and if you don't have any propert

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham added a comment. Since this is a small bugfix, I'd like to land it on the Stable branch (Plasma 5.12). However, I can't easily do this using `arc` because you did the work on master without a branch (in the future, see https://community.kde.org/Infrastructure/Phabricator#Workflow). C

D10692: parent full representation to the proper window at start

mart added a comment. now it depends from D10722 , which can preload it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mo

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27710. mart added a comment. - less hacks on this part, ones in libplasma enough REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27633&id=27710 BRANCH arcpatch-D10692 REVISION DETAIL https://phabrica

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10142 To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-moh

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin, #plasma, #frameworks Cc: plasma-devel, schernikov, michaelh, ZrenBot, alexeym

D10440: Support modifier mouse/scroll action on internal decorated windows

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10440 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening,

D10549: Don't crash if the cursor theme fails to create

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening,

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10291 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening,

D10294: Init the icon in ShellClient::init

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10294 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening,

D10308: Send hoverLeave or hoverMotion after touch up on decoration

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10308 To: graesslin, #kwin, #plasma, ngraham Cc: plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D10490: Add a method to dbus interface to query information about a window

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma Cc: davidedmundson, broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai,

D10594: Disable window rule configuration for Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R108:7bf4a94286a7: Disable window rule configuration for Wayland (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDAT

D10431: Properly handle move during touch events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:338c7362c9fb: Properly handle move during touch events (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE h

D10722: other preload microoptimizations

broulik added inline comments. INLINE COMMENTS > iconitem.h:42 > Q_OBJECT > +Q_INTERFACES(QQmlParserStatus) > `QQuickItem` should do that for you already > svgitem.h:41 > Q_OBJECT > +Q_INTERFACES(QQmlParserStatus) > Same here > ScrollArea.qml:58 > +Component.onComple

D10722: other preload microoptimizations

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY make svgitem schedule a polish right when it's done l

D10325: [KFileWidget] Hide places frame and header

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3e2b24b17ee: [KFileWidget] Hide places frame and header (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10325?vs=26642&id=27706 REVISION DETAIL

D10710: update appMenu status only from qml side

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e6969f2c776f: update appMenu status only from qml side (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10710?vs=27677&id=27705 RE

D10586: [Task Manager] Limit badge label to a sane size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3b526a3a2aa9: [Task Manager] Limit badge label to a sane size (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10586?vs=27355&id=27701

D10557: [Clipboard plasmoid] Split delegate into separate files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7c644c4499c8: [Clipboard plasmoid] Split delegate into separate files (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10557?vs=27647&

D10499: [spellcheck runner] Make each suggestion copyable as separate item

kossebau added a comment. Thanks for review. In D10499#210493 , @broulik wrote: > > and then copy the correct or suggested into the clipboard for further usage? > > Calculator runner does `setText` on `QClipboard` in `run`, so I guess

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

ngraham accepted this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

Re: Closing old Plasma 4 bugs

I have also cleaned up the bug triaging page: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging It's still a bit long, so any further editing to condense it a bit would be welcome. Nate On 02/21/2018 07:16 AM, Nate Graham wrote: On 02/21/2018 06:26 AM, Nate Graham wrote:

Re: Closing old Plasma 4 bugs

On 02/21/2018 06:26 AM, Nate Graham wrote: On Feb 21, 2018, at 12:59 AM, Ben Cooksley wrote: On Wed, Feb 21, 2018 at 9:34 AM, pointedstick wrote: I have editbugs power on bugs.kde.org, but cannot edit the Importance field or mark a bug as CLOSED on bugstest.kde.org. I appear to have the

D10653: Set IconItem default to smooth=true

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bf4facd8c1b9: Set IconItem default to smooth=true (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10653?vs=27528&id=

D10713: Render application icon at paintdevice DPR

This revision was automatically updated to reflect the committed changes. Closed by commit R31:c32eb4129275: Render application icon at paintdevice DPR (authored by davidedmundson). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10713?vs=27683&id=27684 REVISION

D10713: Render application icon at paintdevice DPR

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10713 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10713: Render application icon at paintdevice DPR

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY QIcon::pixmap doesn't know anything about the

Re: Closing old Plasma 4 bugs

> On Feb 21, 2018, at 12:59 AM, Ben Cooksley wrote: > >> On Wed, Feb 21, 2018 at 9:34 AM, pointedstick wrote: >> I have editbugs power on bugs.kde.org, but cannot edit the Importance field >> or mark a bug as CLOSED on bugstest.kde.org. I appear to have the new normal >> permissions. > > Than

D10710: update appMenu status only from qml side

mvourlakos added a comment. > but I think the panel (at least Plasma, dunno about latte) is smart enough to stay open when a transient child is open no prob the... Latte uses the NeedsAttention from applets to block auto-hiding REPOSITORY R120 Plasma Workspace BRANCH menustatus REV

D10710: update appMenu status only from qml side

broulik added a comment. > AcceptingInputStatus This was to keep an auto-hidden panel visible but I think the panel (at least Plasma, dunno about latte) is smart enough to stay open when a transient child is open, see 2d8b4e1dec26c5976dd75c238c3ae8a4700b8dd9

D10710: update appMenu status only from qml side

mvourlakos added a comment. @broulik my only concerns are for line: setStatus(Plasma::Types::AcceptingInputStatus); do you know if there was any specific reason for it? REPOSITORY R120 Plasma Workspace BRANCH menustatus REVISION DETAIL https://phabricator.kde.org/D10710 To

D10710: update appMenu status only from qml side

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. BUG: 390271 REPOSITORY R120 Plasma Workspace BRANCH menustatus REVISION DETAIL https://phabricator.kde.org/D10710 To: mvourlakos, #plasma, broulik Cc: broulik, plasma-devel, ZrenB

D10710: update appMenu status only from qml side

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --add NeedsAttention status when a menu is showing, and

D10695: dont initialize app menu index in every hiding

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1e7b424826c9: dont initialize app menu index in every hiding (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10695?vs=27634&id=276

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > broulik wrote in Menu.qml:36 > Would that also help Kickoff's initial opening? > > Also see D10557 which makes a huge > difference without that.. yeah, pretty much everything that has a listview in it, tough i d

D10557: [Clipboard plasmoid] Split delegate into separate files

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10557 To: broulik, #plasma, graesslin, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ma

D10670: Reduce plasmashell frozen time

jtamate updated this revision to Diff 27672. jtamate edited the summary of this revision. jtamate added a comment. Updated the summary and added a comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10670?vs=27576&id=27672 REVISION DE

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski added a comment. @ivan When database is broken additionaly kactivitymanagerd is in endless loop of creating and closing processes. Each KF5 application prints to console message: "KActivities: FATAL ERROR: Failed to contact the activity manager daemon" Maybe it would be good

D10695: dont initialize app menu index in every hiding

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R120 Plasma Workspace BRANCH global REVISION DETAIL https://phabricator.kde.org/D10695 To: mvourlakos, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot,

D10697: Make the badge text readable on dark color schemes

mwolff added a comment. I did not test it with a light color scheme yet, will do that eventually and commit it then to the branch you indicated REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10697 To: mwolff, broulik, hein Cc: ngraham, plasm

Re: Plasma 5.13 dependencies

On Wed, Feb 21, 2018 at 12:28 AM, Tobias C. Berner wrote: > Hi Ben Hi Tobias, > > > I think we could upgrade the CI to 5.10 "sans webengine" -- which is the one > part we are missing. Okay, that's good to know. I presume getting webengine working will be a bit further off? (I know it has caused

D10512: try to preload certain applets in a smart way

broulik added inline comments. INLINE COMMENTS > anthonyfieroni wrote in appletquickitem.cpp:57-68 > But if PLASMA_PRELOAD_POLICY is not setted s_preloadPolicy stays > Uninitialized, no? But since you check against >= Adaptive it's still ok :) https://cgit.kde.org/plasma-framework.git/commit/?i

Re: Closing old Plasma 4 bugs

On Wed, Feb 21, 2018 at 9:34 AM, pointedstick wrote: > I have editbugs power on bugs.kde.org, but cannot edit the Importance field > or mark a bug as CLOSED on bugstest.kde.org. I appear to have the new normal > permissions. Thanks for confirming my testing Nate. I've now gone ahead and rolled t