D10252: Applet: Use new device icons

This revision was automatically updated to reflect the committed changes. Closed by commit R115:9d354da68994: Applet: Use new device icons (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10252?vs=26382&id=26479 REVISION

D10280: Fix output device context menu

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH fix REVISION DETAIL https://phabricator.kde.org/D10280 To: nicolasfella, broulik, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

Re: tars up for Plasma 5.12.0

Hello there! On Thu, Feb 01, 2018 at 09:39:05PM +0530, Bhushan Shah wrote: > Plasma devs: any last minute bug fixes ask me for a re-roll of tars. We had a re-roll of kwin tarball, new checksum is, 73f6cec78dd3cd76caf26ba57f3d3deed94ad37458ed4aea70752eaffa5664c0 it includes fix for kwin_wayland

D9671: Show only available profiles in Pulseaudio KCM

nicolasfella added a comment. In https://phabricator.kde.org/D9671#200326, @broulik wrote: > This breaks the context menu of output devices: > > org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined > see https://phabricator.kde.org/D1

D10280: Fix output device context menu

nicolasfella created this revision. nicolasfella added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Port QML type got wrongly removed. TEST PL

D9671: Show only available profiles in Pulseaudio KCM

broulik added a comment. This breaks the context menu of output devices: org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9671 To: nicolasfella, #pla

D10151: Correction with the & problem in tabs

ngraham added a comment. Done. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:0ed4aae225c0: Correction with the & problem in tabs (authored by carlavilla, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10151?vs=26457&

D10151: Correction with the & problem in tabs

ngraham added a comment. I'll cherry pick 'em. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: fvogt, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

fvogt reopened this revision. fvogt added a comment. This revision is now accepted and ready to land. This needs to be commited to Plasma/5.12 as well, probably also Plasma/5.8. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham

D10151: Correction with the & problem in tabs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:5ce56e6bb5ef: Correction with the & problem in tabs (authored by carlavilla, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10151?vs=26090&

D10151: Correction with the & problem in tabs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better now, thanks! Works fine. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plas

D10181: Removed the "fastblur" path

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f8ff40271e4d: Removed the "fastblur" path (authored by anemeth, committed by fredrik). Restricted Application edited projects, added Plasma; removed KWin. CHANGED PRIOR TO COMMIT https://phabricator.

D10181: Removed the "fastblur" path

fredrik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma, #vdg, fredrik

D10224: Give a default player name

nicolasfella abandoned this revision. nicolasfella added a comment. Turns out i wasn't running the latest extension. Works fine now. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10224 To: nicolasfella, broulik, apol Cc: apol, plasma-devel, ZrenB

D5932: KCM for controlling Night Color

dfaure added a comment. Ah, the un-namespaced name made me think it was an external dependency. OK, sorry for the noise, I must have updated plasma-desktop without updating plasma-workspace, it works now after a run of kdesrc-build. REPOSITORY R119 Plasma Desktop REVISION DETAIL https:

D10236: [libinput] Ensure Event::device returns a proper Device

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6c00cfb5c75d: [libinput] Ensure Event::device returns a proper Device (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE

D10236: [libinput] Ensure Event::device returns a proper Device

bshah added a comment. Restricted Application edited projects, added KWin; removed Plasma. Ergh, can you commit it though? REPOSITORY R108 KWin BRANCH libinput-event-device REVISION DETAIL https://phabricator.kde.org/D10236 To: graesslin, #kwin, #plasma, fvogt, avaragic Cc: bshah, pla

D10236: [libinput] Ensure Event::device returns a proper Device

bshah added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D10236#200079, @graesslin wrote: > I would not have asked for it, but I agree. @bshah can you please take care of it? Yeah give me half an hour REPOSITORY R

D10236: [libinput] Ensure Event::device returns a proper Device

graesslin added a subscriber: bshah. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D10236#200072, @fvogt wrote: > I'm actually in favor of a tar respin for 5.12.0 in this case. What do you think? I wou

D5932: KCM for controlling Night Color

graesslin added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:59 > Why is it required? Can't this KCM be skipped if the lib isn't available? > > Also, this is missing a set_package_properties call so that one can find out > what the lib is about and where to get it from, whe

D10236: [libinput] Ensure Event::device returns a proper Device

fvogt added a comment. Restricted Application edited projects, added Plasma; removed KWin. I'm actually in favor of a tar respin for 5.12.0 in this case. What do you think? REPOSITORY R108 KWin BRANCH libinput-event-device REVISION DETAIL https://phabricator.kde.org/D10236 To: graess

D10236: [libinput] Ensure Event::device returns a proper Device

fvogt accepted this revision. fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. Tested, works! REPOSITORY R108 KWin BRANCH libinput-event-device REVISION DETAIL https://phabricator.kde.org/D10236 To: graesslin, #kwin, #plasma, fvogt, avaragic C

D10263: Fix being unable to close the toolbox menu by clicking outside

broulik added a comment. Can you verify the toolbox stays open while interacting with applets? If so, +1, otherwise this defies the purpose of the "edit mode" but I trust you tested exactly this :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: he

D10272: Fix crash when searching

aacid added a reviewer: mart. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10272 To: aacid, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10272: Fix crash when searching

aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. TEST PLAN Put the mouse over the left bar to get a tooltip, then type gibbership and remove it a few times, get it to cr

D10268: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN

kossebau created this revision. kossebau added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH appstreamrunnertranslations REVISION D

D5932: KCM for controlling Night Color

dfaure added inline comments. INLINE COMMENTS > kcm_nightcolor.desktop:18 > +Name[de]=Nachtfarbe > +Comment=Adjust color temperatur at night to reduce eye strain > +Comment[de]=Passe Farbtemperatur nachts an um Augen zu entlasten Typo: temperatur -> temperature. REPOSITORY R119 Plasma Desktop

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/28/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Feb 2018 10:39:49 + Build duration: 7 min 25 sec and counting

D5932: KCM for controlling Night Color

dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:59 > find_package(LibTaskManager CONFIG REQUIRED) > +find_package(LibColorCorrect CONFIG REQUIRED) > find_package(KWinDBusInterface CONFIG REQUIRED) Why is it required? Can't this KCM be skipped if the lib isn't available? Also, t