KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 109 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/109/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 06:52:46 + Build duration: 2 min 18 sec and counting CONSOLE OUT

D10193: use proper padding for list contents

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store BRANCH phab/fixsources REVISION DETAIL https://phabricator.kde.org/D10193 To: mart, #kirigami, #discover_software_store, apol Cc: apol, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10197: Fix krunner's alt+f2 on wayland

davidedmundson accepted this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10197: Fix krunner's alt+f2 on wayland

apol updated this revision to Diff 26233. apol added a comment. Readd the comment If somebody can test it on X11, I'd merge to 5.12. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10197?vs=26232&id=26233 BRANCH master REVISION DETAIL htt

D10197: Fix krunner's alt+f2 on wayland

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. For context, krunner inherits from Dialog. Dialog does all this stuff. Duplicating it here is wrong. Must have been ported first or something. INLINE COMMENTS > vie

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

davidedmundson added a comment. > Does this means I can merge to master now (and it'll appear in Plasma 5.13)? Yes and yes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma, davidedmundson Cc: ngraham, mmustac, davidedmundson, brouli

D10197: Fix krunner's alt+f2 on wayland

apol updated this revision to Diff 26232. apol added a comment. Remove code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10197?vs=26230&id=26232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10197 AFFECTED FILES krunner/view

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

ngraham added a comment. Yep, if you land this on master, it will wind up in 5.13. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma, davidedmundson Cc: ngraham, mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezh

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

Zren added a comment. I do have commit access. > Or it could go into master at anytime. Does this means I can merge to master now (and it'll appear in Plasma 5.13)? > only to save in some other unit As so the plan is to serialize in dpi units? Eg: In units of `pixels /

D10193: use proper padding for list contents

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Can you land it on Plasma/5.12? REPOSITORY R134 Discover Software Store BRANCH phab/fixsources REVISION DETAIL https://phabricator.kde.org/D10193 To: mart, #kirigami, #discover_software

D10197: Fix krunner's alt+f2 on wayland

davidedmundson added inline comments. INLINE COMMENTS > view.cpp:236 > if (m_plasmaShell && event->type() == QEvent::Expose) { > using namespace KWayland::Client; > auto ee = static_cast(event); This code here is definitely not designed for X11 REPOSITORY R120 Plasma Wo

D10197: Fix krunner's alt+f2 on wayland

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't go through the workaround introduced for X11 that makes it go mental.

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

croick added a reviewer: Plasma: Workspaces. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D10195 To: croick, #kdevelop, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

croick created this revision. croick added a reviewer: KDevelop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY - register a DBus service to make it work at all - service name u

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

croick edited the test plan for this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D10195 To: croick, #kdevelop, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10188: Sanitise notification HTML

aacid added a comment. My hard drive crashed over the weekend so i haven't had much time for anything other than trying to salvage stuff from my non-backups, but meanwhile here a stuppid "make it const" comment. INLINE COMMENTS > notificationsanitizer.cpp:49 > + > +QVector allowedTags =

D10193: use proper padding for list contents

mart added a comment. In https://phabricator.kde.org/D10193#198147, @ngraham wrote: > Thanks! How does it look when you have multiple backends? E.g if you install the Flatpak backend and add Flathub, what's the presentation like now? can't try directly, has been painful already ha

D10193: use proper padding for list contents

ngraham added a reviewer: Discover Software Store. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10193 To: mart, #kirigami, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10193: use proper padding for list contents

ngraham added a comment. Thanks! How does it look when you have multiple backends? E.g if you install the Flatpak backend and add Flathub, what's the presentation like now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10193 To: mart, #kirigami Cc:

D10193: use proper padding for list contents

mart added a comment. F5683903: Screenshot_20180130_175002.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10193 To: mart, #kirigami Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D10193: use proper padding for list contents

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY every item is in a ListItem, which in kirigami master put the

D10042: Parse EDID on the backend side

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. One minor thing to fix, otherwise the idea + approach look fine to me. Thanks! INLINE COMMENTS > edid_p.h:3 > + * Copyright (C) 2012 - 2014 by Daniel Vrátil > * > + *

D10188: Sanitise notification HTML

fvogt added a comment. Looks good to me. I didn't try it out myself though, but the unit tests look almost complete to me: Can you add a unit test for obviously broken HTML, like `https://phabricator.kde.org/D10188 To: davidedmundson, #plasma, fvogt Cc: fvogt, plasma-devel, ZrenBot, prog

D10188: Sanitise notification HTML

davidedmundson updated this revision to Diff 26213. davidedmundson added a comment. Fabian's requested changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10188?vs=26206&id=26213 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.or

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

kossebau closed this revision. kossebau added a comment. Has been committed as https://phabricator.kde.org/R114:36f5e02ea22e57f4bccffb40bb0bcb85c38118e4 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10163 To: kossebau, jriddell, mart, davidedmundson Cc: plas

D10191: Add Navigation/Turn-By-Turn Directions View and Delegate

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:b11861b1728e: Add Navigation/Turn-By-Turn Directions View and Delegate (authored by Aiix). REPOSITORY R846 Mycroft P

D10188: Sanitise notification HTML

fvogt added inline comments. INLINE COMMENTS > notificationsanitizer.cpp:34 > +t.replace(QLatin1String("\n"), QStringLiteral("")); > +// Now remove all inner whitespace (\ns are already s > +t = t.simplified(); Missing `)` > notificationsanitizer.cpp:57 > +const QString

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau updated this revision to Diff 26208. kossebau added a comment. rebase to latest master REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26186&id=26208 BRANCH portmediawiki REVISION DETAIL https://phabricator.kde.org/D10184 AFFEC

D10191: Add Navigation/Turn-By-Turn Directions View and Delegate

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref https://phabricator.kde.org/T7175 Added navigation and turn-by-turn di

D10188: Sanitise notification HTML

davidedmundson updated this revision to Diff 26206. davidedmundson added a comment. Against 5.8 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10188?vs=26197&id=26206 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D10188 AFFEC

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Not in 5.12. I'm not a huge fan, as there's another open bug that the panel should follow the Plasma style font-size based sizing. When we have both, presenting somethi

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/22/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 30 Jan 2018 09:34:37 + Build duration: 3 min 28 sec and counting

D10177: Fix iterator

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b4278a15226a: Fix iterator (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10177?vs=26171&id=26204 REVISION DETAIL https://phabricator.k

D10024: Add supportedSchemes feature

mwolff added a comment. @apol any hint what to do about KIOSK? any resources I should have a look at? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, Zr