D10188: Sanitise notification HTML

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. This is required for 5.8 as well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10188 To: davidedmundson, #plasma, fvogt Cc: fvogt, plasma-devel

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

ngraham added a comment. Since there aren't any string changes, technically it could still go into the 5.12 branch. Or it could go into master at anytime. I approve in concept, FWIW. But we should probably get formal approval from @broulik or @davidedmundson first. REPOSITORY R119 Pla

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

Zren added a comment. No one approved it so I never merged it in time for the Plasma 5.12 beta. So I guess it'll have to wait for 5.12 to be released before I merge it into the master branch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #pl

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH block-geometry-update-on-finish-resize-5.12 REVISION DETAIL https://phabricator.kde.org/D10156 To: graesslin, #kwin, #plasma, jgrulich Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesli

D10065: Fix brightness shortcuts in the whitelist

This revision was automatically updated to reflect the committed changes. Closed by commit R133:33547e2f7a42: Fix brightness shortcuts in the whitelist (authored by dos, committed by davidedmundson). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10065?v

D10066: Add touchpad shortcuts to the whitelist

This revision was automatically updated to reflect the committed changes. Closed by commit R133:e861e10d84c8: Add touchpad shortcuts to the whitelist (authored by dos, committed by davidedmundson). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10066?vs=

D10065: Fix brightness shortcuts in the whitelist

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D10065 To: dos, #plasma, davidedmundson Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10066: Add touchpad shortcuts to the whitelist

dos marked 3 inline comments as done. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D10066 To: dos, #plasma, graesslin Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6673: [Notifications] Manually remove remote images

davidedmundson abandoned this revision. davidedmundson added a comment. Superseeded by https://phabricator.kde.org/D10188 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6673 To: davidedmundson, #plasma, fvogt, broulik Cc: ngraham, aacid, davidedmundson, pla

D10188: Sanitise notification HTML

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Qt labels support a HTML subset, using a comp

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

ngraham added a comment. FWIW, a major Linux reviewer mentioned this as a wishlist item in his recent review of the Plasma 5.12 beta: http://www.ocsmag.com/2018/01/27/plasma-5-12-long-term-sweetness/ "If you wish to change the bottom panel height, you don’t have a field where you can in

D10177: Fix iterator

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/fixiter REVISION DETAIL https://phabricator.kde.org/D10177 To: mart, #plasma, hein, ivan Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. QML and presentation look great to me! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D10183 To: kamathraghavendra, davidedmundson, #pla

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

mmustac added a comment. Whats the status here? I would love to see this feature coming in the near future. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma Cc: mmustac, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliez

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

kamathraghavendra added inline comments. INLINE COMMENTS > davidedmundson wrote in TrafficMonitor.qml:55 > Semantically it's weird to use the size of an icon for a margin, unless > you're trying to line up with an icon. There's a medium sized icon in the > toolbar, which I assume is the intent

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

kamathraghavendra updated this revision to Diff 26190. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10183?vs=26185&id=26190 REVISION DETAIL https://phabricator.kde.org/D10183 AFFECTED FILES applet/contents/ui/TrafficMonitor.qml

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

davidedmundson added a comment. Looks good. +1 1 minor nitpick, but it's not super important. INLINE COMMENTS > TrafficMonitor.qml:55 > left: parent.left > -leftMargin: units.iconSizes.medium > +leftMargin: units.iconSizes.large > right:

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

kamathraghavendra added reviewers: Plasma, broulik, jgrulich. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D10183 To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich Cc: plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

kamathraghavendra added a reviewer: davidedmundson. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D10183 To: kamathraghavendra, davidedmundson Cc: plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D10184: Port mediawiki runner to Plasma5/Qt5

kossebau created this revision. kossebau added reviewers: broulik, jriddell, davidedmundson, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Straight initial port of exist

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

kamathraghavendra created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kamathraghavendra requested review of this revision. REVISION SUMMARY The text showing the speed of the download in the speed section of the plasma-n

D10181: Removed the "fastblur" path

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D10170: Added optional transparency/blur to menu frames

zzag added a comment. In https://phabricator.kde.org/D10170#197851, @anemeth wrote: > Just tried that. > Nothing changed. Try to change `contrast`, `intensity`, and `saturation` args. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hp

D10170: Added optional transparency/blur to menu frames

zzag added inline comments. INLINE COMMENTS > anemeth wrote in breezestyle.cpp:3630 > The slider has 10 steps and goes from 0 to 10, that's why it's `/ 10.0` > 100 steps would be too much in my opinion. > > And we need to invert the value of it because the setAlphaF works inverted to > our slid

D10170: Added optional transparency/blur to menu frames

anemeth added inline comments. INLINE COMMENTS > zzag wrote in breezestyle.cpp:3630 > buggy.. > > `background.setAlphaF(StyleConfigData::menuTransparency() / 100.0f);` The slider has 10 steps and goes from 0 to 10, that's why it's `/ 10.0` 100 steps would be too much in my opinion. And we need

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In https://phabricator.kde.org/D10170#197849, @zzag wrote: > In https://phabricator.kde.org/D10170#197845, @anemeth wrote: > > > I presume you mean the Background contrast effect. It was in the half-enabled state. I checked it to be fully enabled but I did not

D10170: Added optional transparency/blur to menu frames

zzag added a comment. In https://phabricator.kde.org/D10170#197845, @anemeth wrote: > I presume you mean the Background contrast effect. It was in the half-enabled state. I checked it to be fully enabled but I did not notice any difference. Did you call `KWindowEffects::enableBac

D10170: Added optional transparency/blur to menu frames

anemeth added inline comments. INLINE COMMENTS > zzag wrote in breeze.kcfg:188 > Redundant comment. What's redundant about it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: zzag, ngraham, plasma-devel, ZrenBot, pro

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In https://phabricator.kde.org/D10170#197812, @zzag wrote: > Looks great! > > BUT, it would be nice to have a little bit bigger contrast. Could you please enable background contrast and upload a screenshot what it looks like? I presume you mean the Bac

D10181: Removed the "fastblur" path

anemeth edited the summary of this revision. anemeth added reviewers: graesslin, KWin, Plasma. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: plasma-devel. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181

D10170: Added optional transparency/blur to menu frames

zzag added inline comments. INLINE COMMENTS > breeze.kcfg:189 > + > + > +0 0 100 maybe something like this? > breezestyle.cpp:3630 > +if (hasAlpha) { > +background.setAlphaF(1.0 - > StyleConfigData::menuTransparencyPercent() / 10.0); > +

D10170: Added optional transparency/blur to menu frames

zzag added inline comments. INLINE COMMENTS > breeze.kcfg:188 > > + > + Redundant comment. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, #vdg Cc: zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D10170: Added optional transparency/blur to menu frames

zzag added a comment. Looks great! BUT, it would be nice to have a little bit bigger contrast. Could you please enable background contrast and upload what it looks like? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma,

D10175: use kcrash so we get drkonqi to pop up on crashes

This revision was automatically updated to reflect the committed changes. Closed by commit R124:9bb8a5f1412d: use kcrash so we get drkonqi to pop up on crashes (authored by sitter). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10175?vs=26167&id=26178

D10175: use kcrash so we get drkonqi to pop up on crashes

sitter added a comment. In https://phabricator.kde.org/D10175#197772, @davidedmundson wrote: > heh, open the look and feel KCM and then it does. > > Weird. kcrash is initialized as qcoreapp_startup thingy as well, so loading any plugin/kcm that already directly links against K

D10175: use kcrash so we get drkonqi to pop up on crashes

davidedmundson accepted this revision. davidedmundson added a comment. heh, open the look and feel KCM and then it does. Weird. REPOSITORY R124 System Settings BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10175 To: sitter, mart, bshah, davidedmundson Cc: davide

D10177: Fix iterator

mart added reviewers: hein, ivan. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10177 To: mart, #plasma, hein, ivan Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10177: Fix iterator

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY removing favorites crashed, next() has to be called before accessing the

D10175: use kcrash so we get drkonqi to pop up on crashes

sitter added a comment. In https://phabricator.kde.org/D10175#197736, @davidedmundson wrote: > > kill -SEGV pidof systemsettings5 brings up drkonqi > > > > That happens without this patch F5681773: vokoscreen-2018-01-29_15-38-29.mkv

D10175: use kcrash so we get drkonqi to pop up on crashes

bshah added a comment. In https://phabricator.kde.org/D10175#197736, @davidedmundson wrote: > > kill -SEGV pidof systemsettings5 brings up drkonqi > > > > That happens without this patch interesting, doesn't happen for me it just coredumps to systemd-coredump

D10175: use kcrash so we get drkonqi to pop up on crashes

davidedmundson added a comment. > kill -SEGV pidof systemsettings5 brings up drkonqi That happens without this patch REPOSITORY R124 System Settings BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10175 To: sitter, mart, bshah Cc: davidedmundson, plasma-devel, Z

D10175: use kcrash so we get drkonqi to pop up on crashes

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10175 To: sitter, mart, bshah Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D10175: use kcrash so we get drkonqi to pop up on crashes

sitter created this revision. sitter added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sitter requested review of this revision. TEST PLAN - kill -SEGV `pidof systemsettings5` brings up drkonqi REPOSITORY R124 Syst

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. It's working and the patch looks good to me. REPOSITORY R108 KWin BRANCH block-geometry-update-on-finish-resize-5

D10173: windowthumbnail: Fix the GLXFBConfig selection code

fredrik created this revision. fredrik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Check that the sizes of the color channels i

Minutes Monday Plasma Hangout

Notes of today's meeting... Enjoy! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 29 january 2018 Present: Sho, notmart, d_ed, bshah, frinring, sebas Sho: i wrote patches for kio and kjobwidgets in an attempt to make kio confirmation dialogs spawned from fv modal all th

D10163: Removing all unported/unbuilt applets, dataengines, runners, wallpapers

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH cleanupunportedcode REVISION DETAIL https://phabricator.kde.org/D10163 To: kossebau, jriddell, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha

D10102: base scrolling on the smallest item

mart added a comment. also, that gwenview patch really looks like a workaround for the Qt bug fixed by https://codereview.qt-project.org/#/c/212398/, since that's upstream now, i'm not sure is worth to workaround in random applications which would just harm in long term maintainability? REP

D10102: base scrolling on the smallest item

This revision was automatically updated to reflect the committed changes. Closed by commit R318:0b130dd57e59: base scrolling on the smallest item (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10102?vs=25952&id=26164#toc REPOSITORY R318 Dolphin CHANGES SINCE LAST U

D10102: base scrolling on the smallest item

mart added a comment. In https://phabricator.kde.org/D10102#197637, @ngraham wrote: > I understand now. This patch does indeed make it //better// in the case where you have icons with really long/tall filenames, but it doesn't do anything to help the general case of Dolphin's scrolling b