fvogt added inline comments.
INLINE COMMENTS
> ivan wrote in ResourceScoreMaintainer.cpp:62
> If that is enough, then why not just `wait()`?
Simple: `wait()` waits for an infinite amount of time if `run()` never returns.
If that happens (`run()` is stuck), we prefer a crash over silently wastin
This revision was automatically updated to reflect the committed changes.
Closed by commit R161:ed092b96f7af: Actually quit threads nicely (authored by
fvogt).
REPOSITORY
R161 KActivity Manager Service
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9998?vs=25709&id=25737
REVISION DE
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/31/
Project:
Plasma libksysguard kf5-qt5 SUSEQt5.9
Date of build:
Mon, 22 Jan 2018 07:06:59 +
Build duration:
5 min 5 sec and counting
CONSOLE OUTPUT
[.
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/19/
Project:
Plasma libksysguard kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 22 Jan 2018 07:06:59 +
Build duration:
1 min 12 sec and counting
CONSOLE OUTPUT
On Sonntag, 21. Jänner 2018 22:40:31 CET Ben Cooksley wrote:
> On Mon, Jan 22, 2018 at 10:15 AM, Martin Koller wrote:
> > Hi,
>
> Hi Martin,
>
> >
> > On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote:
> >> Hi Martin,
> >>
> >> Looks like your latest commit to ksshaskpass doesn't build
On Sun, Jan 21, 2018 at 7:25 PM, Albert Astals Cid wrote:
> El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va
> escriure:
> > On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham
> wrote:
> > > I've submitted an idea for System Settings: Improve handling for
> touchpads
> > > and mi
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20SUSEQt5.9/12/
Project:
Plasma ksshaskpass kf5-qt5 SUSEQt5.9
Date of build:
Sun, 21 Jan 2018 23:10:07 +
Build duration:
5 min 52 sec and counting
JUnit Tests
Name:
ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.
Otherwise +1
REPOSITORY
R161 KActivity Manager Service
BRANCH
Plasma/5.12
REVISION DETAIL
https://phabricator.kde.org/D9998
To: fvogt, #plasma, ivan, anthonyfieroni
Cc: lbeltrame, plasm
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20FreeBSDQt5.9/8/
Project:
Plasma ksshaskpass kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 23:10:07 +
Build duration:
1 min 11 sec and counting
ivan added inline comments.
INLINE COMMENTS
> lbeltrame wrote in ResourceScoreMaintainer.cpp:62
> Same as above.
If that is enough, then why not just `wait()`?
REPOSITORY
R161 KActivity Manager Service
REVISION DETAIL
https://phabricator.kde.org/D9998
To: fvogt, #plasma, ivan, anthonyfier
On Mon, Jan 22, 2018 at 10:15 AM, Martin Koller wrote:
> Hi,
Hi Martin,
>
> On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote:
>> Hi Martin,
>>
>> Looks like your latest commit to ksshaskpass doesn't build.
>> Could you please take a look?
>
> I don't understand this.
>
> Why does my n
Hi,
On Sonntag, 21. Jänner 2018 20:43:42 CET Ben Cooksley wrote:
> Hi Martin,
>
> Looks like your latest commit to ksshaskpass doesn't build.
> Could you please take a look?
I don't understand this.
Why does my new line fail
QRegularExpression re3a("^(Password|Username) for \"(.*?)\"$")
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/18/
Project:
Plasma libksysguard kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 20:09:01 +
Build duration:
10 min and counting
JUnit Tests
Nam
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/17/
Project:
Plasma libksysguard kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 19:49:31 +
Build duration:
8 min 34 sec and counting
CONSOLE OUTPUT
Hi Martin,
Looks like your latest commit to ksshaskpass doesn't build.
Could you please take a look?
Cheers,
Ben
-- Forwarded message --
From: CI System
Date: Mon, Jan 22, 2018 at 8:40 AM
Subject: KDE CI: Plasma ksshaskpass kf5-qt5 SUSEQt5.9 - Build # 11 - Still
Failing!
To: pla
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20SUSEQt5.9/11/
Project:
Plasma ksshaskpass kf5-qt5 SUSEQt5.9
Date of build:
Sun, 21 Jan 2018 19:38:58 +
Build duration:
1 min 5 sec and counting
CONSOLE OUTPUT
[...
El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va
escriure:
> On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham wrote:
> > I've submitted an idea for System Settings: Improve handling for touchpads
> > and mice with Libinput
>
> Speaking of systemsettings, would be a good fit por
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/65/
Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 18:09:13 +
Build duration:
23 min and counting
JUnit Tests
Name: (root) Failed
tcberner added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9930#194036, @graesslin wrote:
> In https://phabricator.kde.org/D9930#193993, @tcberner wrote:
>
> > Hi there
> >
> > This breaks the CI on FreeBSD, where w
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/64/
Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 18:04:37 +
Build duration:
3 min 38 sec and counting
CONSOLE OUTPUT
[...truncat
Hi,
> I think you've only half analysed this. If nothing is really listening on
> DBus it will fall back to legacy X which will work on XFCE.
Where did I miss this in the code? The createPlatformSystemTrayIcon() functions
in qtbase/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp ar
anemeth added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> fredrik wrote in blur.cpp:255
> Does calling effects->addRepaintFull() also work?
It does.
Changed to that.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/
anemeth updated this revision to Diff 25720.
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Implemented the changes suggested by @fredrik
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9848?vs=25643&id=25720
BRANC
anemeth marked 3 inline comments as done.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9848
To: anemeth, #plasma, #kwin
Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,
fredri
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/16/
Project:
Plasma libksysguard kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 17:03:59 +
Build duration:
1 min 37 sec and counting
CONSOLE OUTPUT
fredrik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
I haven't looked at everything in detail, but in general I think this looks
ready to land.
Just a couple of nitpicks, and a question below.
INLINE COMMENTS
> anemeth wrote in blur.cpp:145
> Ok I
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9930#193993, @tcberner wrote:
> Hi there
>
> This breaks the CI on FreeBSD, where we only have libinput 1.6
>
> 10:17:48 -- Could NOT find Libinput: Foun
ngraham closed this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10002
To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas
apol accepted this revision.
REPOSITORY
R134 Discover Software Store
BRANCH
Plasma/5.12
REVISION DETAIL
https://phabricator.kde.org/D10002
To: ngraham, apol, abetts, andreaska, colomar, #discover_software_store, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute
croick added inline comments.
INLINE COMMENTS
> CMakeLists.txt:69
> +if (PLASMA_ENABLED)
> +install(DIRECTORY styles/Plasma DESTINATION
> ${KDE_INSTALL_QMLDIR}/org/kde/kirigami.2/styles)
> +endif()
When trying to install it using kdesrc-build, it complains about not finding
the
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9848#190176, @graesslin wrote:
> I would like to see this reviewed by @fredrik, @mart , @davidedmundson and
in general the https://phabricator.kde.org/tag/vdg/
>Following the initialisation I now see that the Qt5 systray set-up fails
because there's nothing listening on the DBus
I think you've only half analysed this. If nothing is really listening on
DBus it will fall back to legacy X which will work on XFCE.
You'll get into this situation if you have
tcberner added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Hi there
This breaks the CI on FreeBSD, where we only have libinput 1.6
10:17:48 -- Could NOT find Libinput: Found unsuitable version "1.6.0", but
required is at least "1.9" (found /usr/lo
fvogt updated this revision to Diff 25709.
fvogt added a comment.
Add comments to explain the magic values
REPOSITORY
R161 KActivity Manager Service
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9998?vs=25694&id=25709
BRANCH
Plasma/5.12
REVISION DETAIL
https://phabricator.k
lbeltrame added inline comments.
INLINE COMMENTS
> fvogt wrote in Resources.cpp:60
> It's the `// initial delay before processing the events` plus some time for
> it to process the last request. I can add a comment if you want to.
A comment would do (so that it is less "magic").
REPOSITORY
R
fvogt added inline comments.
INLINE COMMENTS
> lbeltrame wrote in Resources.cpp:60
> What's the reason for 1500 here?
It's the `// initial delay before processing the events` plus some time for it
to process the last request. I can add a comment if you want to.
REPOSITORY
R161 KActivity Mana
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/63/
Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 10:16:13 +
Build duration:
6 min 43 sec and counting
CONSOLE OUTPUT
[...truncat
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:4cc1d7a24546: Require libinput version 1.9 (authored by
graesslin).
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabr
graesslin added a comment.
I took care of the auto test with
https://commits.kde.org/kwin/0d2a34172357c016f74f5374e6db1785e7739f11
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9980
To: jgrulich, graesslin
Cc: ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenB
Hi,
I'm running a simple XFCE environment on a Unix rig (not Linux) and thought
some dependency was missing because the xfce4-panel notification area remained
empty - until I noticed that it works just fine when GTk2 applications try to
use it. Following the initialisation I now see that the Qt
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20FreeBSDQt5.9/7/
Project:
Plasma ksshaskpass kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 21 Jan 2018 09:27:08 +
Build duration:
1 min 23 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20ksshaskpass%20kf5-qt5%20SUSEQt5.9/10/
Project:
Plasma ksshaskpass kf5-qt5 SUSEQt5.9
Date of build:
Sun, 21 Jan 2018 09:27:08 +
Build duration:
1 min 18 sec and counting
CONSOLE OUTPUT
[..
lbeltrame added inline comments.
INLINE COMMENTS
> Resources.cpp:60
> +requestInterruption();
> +wait(1500);
> }
What's the reason for 1500 here?
> ResourceScoreMaintainer.cpp:62
> +requestInterruption();
> +wait(1500);
> }
Same as above.
REPOSITORY
R161 KActivity Manager
This revision was automatically updated to reflect the committed changes.
Closed by commit R105:37aa02a33a86: make it work with with git-lfs (authored by
mkoller).
REPOSITORY
R105 KDE SSH Password Dialog
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9072?vs=23181&id=25706
REVISION
44 matches
Mail list logo
