D9974: Improve header and metadata display

ngraham added a comment. Thanks for the vote of confidence, Roman! In this patch, I didn't touch the review UI; it's still a pop-up. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software

D9974: Improve header and metadata display

romangg added a comment. In my opinion this looks absolutely wonderful! When we last discussed Discover app pages in VDG Telegram channel I said that the version selection should be at top together with the other basic information, but by this I meant foremost that the info should be tog

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 77 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/77/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 04:12:11 + Build duration: 27 min and counting CONSOLE OUTPUT

D9974: Improve header and metadata display

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9974: Improve header and metadata display

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9974: Improve header and metadata display

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9974: Improve header and metadata display

ngraham added a dependent revision: D9976: Display version alongside source, and use a combobox to switch between them. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc:

D9974: Improve header and metadata display

ngraham retitled this revision from "Improve header, metadata display, and version chooser UI" to "Improve header and metadata display". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https:

D9974: Improve header, metadata display, and version chooser UI

ngraham updated this revision to Diff 25620. ngraham added a comment. "You missed a spot" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25619&id=25620 BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.or

D9974: Improve header, metadata display, and version chooser UI

ngraham updated this revision to Diff 25619. ngraham added a comment. Revert Combobox changes, as they changed a string and we're past the string freeze date for 5.12 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25614&id=25619 BR

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 76 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/76/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 02:29:05 + Build duration: 7 min 43 sec and counting JUnit Tests

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > anemeth wrote in blur.cpp:145 > I checked if I have these extensions. Just to make sure it works I included > another extension I know my card supports. > > qCDebug(KWINEFFECTS

D9974: Improve header, metadata display, and version chooser UI

ngraham planned changes to this revision. ngraham added a comment. I just realized that this can't go into 5.12 because I changed a string and there's a string freeze. I'm going to remove the combobox part of this patch and put it in a second one to make this patch potentially able to go into

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:145 > Okay, I see what you mean. I think this is a trade-off between two > undesirable effects though, because the clamping causes abrupt changes near >

D9974: Improve header, metadata display, and version chooser UI

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#193152, @davidedmundson wrote: > Changing the blur size at runtime didn't seem to have an effect, it all worked after kwin restart. > Your code looks fine,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Thanks for the patience going through this! Some reviews do go through a lot of iterations, but it's generally worth it. I gave it a quick test. Blur part works nicely. Changing the bl

D9965: Provide a tooltip for the main action

apol added inline comments. INLINE COMMENTS > broulik wrote in ActionButton.qml:115 > Unfortunately there's no non-widgets API to get it but Qt uses 700 ms as > `SH_ToolTip_WakeUpDelay` We can create a new Kirigami.Units.toolTipDelay REPOSITORY R169 Kirigami REVISION DETAIL https://phabri

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 2 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredri

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25615. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updated the blur amount value configuration to use less magically numbers and added an explanation comment. This new method creates an evenly distributed

D9974: Improve header, metadata display, and version chooser UI

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D9974: Improve header, metadata display, and version chooser UI

ngraham created this revision. ngraham added reviewers: apol, abetts, colomar, andreask, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Moved the

D1230: GBM remote access support for KWin

Kanedias added a comment. Hi @jgrulich! There are actually two sides of this dime. The one that I wanted to take is implementing pipewire server in kded. It will be responsible for converting GBM fds to PW video stream fds and will announce this interface via DBus like Mutter does

Re: KDE and Google Summer of Code 2018

Yea, I thought that we could find maybe some intermediate state/goal for the parallel rendering to which we can fallback when the overall goal can't be achieved. I would add a line about the difficulty of this project to the idea list. What do you think about this plan? But if you still think that

D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D7246: Tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R129:24a859b356ef: Tooltips (authored by graesslin). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25539&id=25604 REVISION DETAIL https://ph

Re: KDE and Google Summer of Code 2018

Am 2018-01-18 15:23, schrieb Roman Gilg: I added two KWin project ideas: https://community.kde.org/GSoC/2018/Ideas#KWin The first idea (parallel rendering) is IMHO too difficult for a GSoC. The other idea sounds reasonable from scope. Cheers Martin On Wed, Jan 17, 2018 at 6:18 PM, Roman G

Re: KDE and Google Summer of Code 2018

Am 2018-01-17 18:18, schrieb Roman Gilg: Hi, Valorie, do we have until 23rd with project ideas? I didn't want to mentor this year because I only was a GSoC student last year, but since there are not yet many ideas from Plasma/KWin I might do it anyway. I'm not able to mentor this year (due to

D7246: Tooltips

graesslin accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed

Re: detecting tablet mode

Am 2018-01-17 13:26, schrieb Marco Martin: On Wed, Jan 17, 2018 at 10:33 AM, Marco Martin wrote: Another thing that i think would be needed, is to detect if the tabet mode switch is present at all on the hardware (my use case would be wether show options related to that on the gui side) is tha

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > tabletmodemanager.cpp:87 > +{ > +//TODO: we need to access to libinput::connection from here > +if (m_tabletModeAvailable == available) { Impossible! That's violating th

D9900: Make it clear that the setting applies to tiled windows, too

ngraham abandoned this revision. ngraham added a comment. Doesn't make sense since you can already resize tiled windows from their borders even without this setting checked. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9900 To: ngraham, hpereiradacosta, #breeze Cc:

D9930: Require libinput version 1.9

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9930#192197, @davidedmundson wrote: > Edit: please make sure the CI has this before pushing. CI has it. I checked before starting the work on the feature w

D9414: Implement OSD to select action when unknown monitors is connected

broulik added a comment. Cool. INLINE COMMENTS > daemon.cpp:188 > +{ > +self->deleteLater(); > + This makes me uneasy. > daemon.cpp:195 > +case KScreen::OsdAction::SwitchToInternal: > +qCDebug(KSCREEN_KDED) << "OSD: swutch to internal"; > + > doApplyConfig(Generator:

D9965: Provide a tooltip for the main action

broulik added inline comments. INLINE COMMENTS > ActionButton.qml:115 > +Controls.ToolTip.text: action ? action.text : "" > +Controls.ToolTip.delay: Units.longDuration > + Unfortunately there's no non-widgets API to get it but Qt uses 700 ms as `SH_ToolTip_WakeUpDelay`

D9965: Provide a tooltip for the main action

apol added a comment. With tooltip F5662283: Screenshot_20180118_172541.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9965 To: apol, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D9965: Provide a tooltip for the main action

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This way there's a chance to see the action text without clicking

D9414: Implement OSD to select action when unknown monitors is connected

sebas requested changes to this revision. sebas added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > OsdSelector.qml:49 > +iconSource: "osd-shutd-screen", > +label: qsTr("Switch to external screen"), > +

D9963: [KCMShell] Don't assume KCModuleProxy is our child widget

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D9963 To: broulik, dfaure, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D9963: [KCMShell] Don't assume KCModuleProxy is our child widget

broulik created this revision. broulik added a reviewer: dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This broke with the introduction of scroll bars around the KCM as

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. I've tested this branch, and it's looking quite good. On X11, it works as expected now after doing a few changes: - The first two icons were mixed up, fix added to dvratil/osd branch - The OSD wouldn't dismiss when the cable got unplugged without selecting an act

D9960: Query os-release for distro name

This revision was automatically updated to reflect the committed changes. Closed by commit R134:2f4f9a48fcb8: Query os-release for distro name (authored by arojas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9960?vs=25587&id=25597#toc REPOSITORY R134 Discover Software Store CHANGE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in blur.cpp:152 > I think 5 blur strength steps to select from is fine, if that means we can > get rid off the magic number

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25596. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Made the changes that were suggested by @frederik Now only the taskbar doesn't have the extended blur effect. REPOSITORY R108 KWin CHANGES SINCE LAST U

D3598: rework kscreen's OSD logic

sebas abandoned this revision. sebas added a comment. This branch is going to be merged as part of https://phabricator.kde.org/D9414 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3598 To: sebas, #plasma Cc: kpiwowarski, mart, graesslin, broulik, plasma-devel, david

D9945: Don't close plasmoid when closing a subdialog via index change in a parent subdialog

ngraham added a comment. Sorry about that. I was going by https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages, which lists them with spaces. between the colon and the number. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart updated this revision to Diff 25594. mart added a comment. try to diff against the proper stuff REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9892?vs=25589&id=25594 BRANCH mart/static REVISION DETAIL https://phabricator.kde.org/D9892 AFFECTED

Re: KDE and Google Summer of Code 2018

I added two KWin project ideas: https://community.kde.org/GSoC/2018/Ideas#KWin On Wed, Jan 17, 2018 at 6:18 PM, Roman Gilg wrote: > Hi, > > Valorie, do we have until 23rd with project ideas? I didn't want to mentor > this year because I only was a GSoC student last year, but since there are > no

D9962: Make sure the search result that Return will run is highlighted

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Otherwise there's no visual feedback that you can just hit Return. This requires refactoring the item list code slightly not

D9960: Query os-release for distro name

apol added a comment. Then leave it as is. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9960 To: arojas, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9945: Don't close plasmoid when closing a subdialog via index change in a parent subdialog

hein added a subscriber: ngraham. hein added a comment. @ngraham: "BUG:number" is the correct form, please don't add the spaces there :). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9945 To: hein, #plasma Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwol

D9945: Don't close plasmoid when closing a subdialog via index change in a parent subdialog

hein added a comment. In https://phabricator.kde.org/D9945#192419, @cfeck wrote: > This partly fixes the issue. After applying this I can still reproduce by moving the mouse from the list to the gap between the list and the search box. The gap between the list and the search box i

D9792: even slimmer scrollbars

mart added a comment. landed just in master post 5.12 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts Cc: davidedmundson, ngraham, colomar, abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D9792: even slimmer scrollbars

This revision was automatically updated to reflect the committed changes. Closed by commit R31:d4b07d9e1daf: even slimmer scrollbars (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25385&id=25590 REVISION DETAIL https://phabricator.k

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart added a comment. now the library definition is not duplicated and both the cmake and qmake example do usa the static plugin REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9892 To: mart, #kirigami, lepagevalleeemmanuel Cc: apol, plasma-devel, davidedmundson,

D9892: cmake: Use the official CMake variable for building as a static plugin.

mart updated this revision to Diff 25589. mart added a comment. - don't duplicate target_link_libraries - properly use the static plugin in the example - the pro makes a static library - use proper static plugins for the cmake example - toplevel qmake with subfolders - proper name for

D9960: Query os-release for distro name

arojas added a comment. In https://phabricator.kde.org/D9960#192840, @apol wrote: > Works for me. > Maybe use PRETTY_NAME? It's supposed to be prettier and it's used to display after all. According to https://www.freedesktop.org/software/systemd/man/os-release.html both NAME a

D1230: GBM remote access support for KWin

romangg added a comment. In https://phabricator.kde.org/D1230#192516, @Kanedias wrote: > After it is working we'll have an implicit confirmation that these patches indeed have not regressed and can be merged. I don't fully understand what this means, but in general I think it soun

D9960: Query os-release for distro name

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Please Plasma/5.12 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9960 To: arojas, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9960: Query os-release for distro name

apol added a comment. Works for me. Maybe use PRETTY_NAME? It's supposed to be prettier and it's used to display after all. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9960 To: arojas, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 389152 TEST PLAN Compiles REPOSITOR

D9960: Query os-release for distro name

arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY Look for the distro name in /etc/os-release and /usr/lib/os-release ins

D1230: GBM remote access support for KWin

jgrulich added a comment. In https://phabricator.kde.org/D1230#192516, @Kanedias wrote: > @romangg , let's go with following approach: I'll upstream all changes I have left hanging (e.g. https://phabricator.kde.org/D9708) by the end of this week and will try to come up with some PoC work

D9892: cmake: Use the official CMake variable for building as a static plugin.

lepagevalleeemmanuel added a comment. I tried the patch on my CI and it compiled and linked. I also reviewed the changes between my patchset and this diff and approve the change, I also agree with Apol about the `target_link_libraries` issue. It should be mutualized between the `if` and `els