D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx accepted this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts, rkflx Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham marked 3 inline comments as done. ngraham added a comment. I'm agnostic about the `default` style, but I do see the utility of putting it on top. I'll leave it that way unless anybody has strong objections. Is this shippable now? REPOSITORY R31 Breeze BRANCH master REVISION

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham updated this revision to Diff 24854. ngraham added a comment. Handle inappropriately high numeric values set in pre-existing breezerc files REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9627?vs=24801&id=24854 BRANCH master REVISION DETAIL https

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx added a comment. Thanks for the review and your help ;) INLINE COMMENTS > hpereiradacosta wrote in breezedecoration.cpp:643 > Matter of taste. > Some people (including me), like to have the default (fallback) choice first. > Some others like to have it last. > Some, inline. > There is

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

hpereiradacosta added a comment. Other than that ... Ship it ! I'm fine with the change and happy to maintain it in the future. INLINE COMMENTS > rkflx wrote in breezedecoration.cpp:643 > Ordering by size would be more readable, `default` doesn't have to sit at the > top (it should just tag

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx added a comment. In https://phabricator.kde.org/D9627#186696, @rkflx wrote: > I won't need to test again, as the screenshots clearly show it working fine ;) Never trust a screenshot… INLINE COMMENTS > breezedecoration.cpp:643 > +{ > +default: >

D9699: Keep fullscreen windows in active layer based on transients not the group

luebking added a comment. Restricted Application edited projects, added KWin; removed Plasma. The original implementation based the fullscreen status on the stack position of the window (ie. whenever a window would rise above the plain stack position of the FS window, it would loose the FS st

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. X11 === F5625140: fullscreen-animation-x11.mp4 Xwayland F5625142: fullscreen-animation-xwayland.mp4

D9699: Keep fullscreen windows in active layer based on transients not the group

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. I've tested it with Kate and also multiple screens, and everything worked fine. On Wayland I couldn't really test it, be

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24849. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect Re-implemented this effect. The only missing part is emitters of `windowFullScr

D8529: Plasma change icons should exit after its work finished.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:60bc30083fe4: Plasma change icons should exit after its work finished. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8529?vs=2145

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9699#186972, @graesslin wrote: > git blame result: The group check was introduced with https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 -

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > romangg wrote in abstract_client.cpp:1155 > Just a question for understanding unrelated to this patch: why should > `isActiveFullScreen` return true, if `ac->screen() != screen(

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. git blame result: The group check was introduced with https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 - before it was a check for transient, but the group check was there a

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

fvogt updated this revision to Diff 24838. fvogt added a comment. Forgot to save ProcessModel.cpp before git commit. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9689?vs=24836&id=24838 BRANCH history REVISION DETAIL https://phabricator.kde

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9699#186940, @romangg wrote: > Are there maybe other cases of clients in X, which share the same group, are not transient, but need to have `isActiveFullScreen` r

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

fvogt updated this revision to Diff 24836. fvogt added a comment. Instead of updating the last entry's timestamp if the value is the same, add a new entry only if the latest entry has a certain age. Otherwise, the interpolation results would look differently and processes had different

D9699: Keep fullscreen windows in active layer based on transients not the group

romangg added a comment. Restricted Application edited projects, added KWin; removed Plasma. Are there maybe other cases of clients in X, which share the same group, are not transient, but need to have `isActiveFullScreen` return true on any client if one of them is the most recent activated

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D8922: Avoid jumping of items toward right/botton when dropping

amantia added a comment. Sorry about it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8922 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart