D9625: Require Qt 5.7

graesslin added a comment. Please do this change in master and not in the bug fix branch. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D9627: Reduce menu shadows to half the size of the window shadows

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, apol, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. Here's the follow-up patch to make menu shadows a smaller faction of the window shadow size: https://phabricator.kde.org/D9627 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake Cc:

D9625: Require Qt 5.7

volkov added a reviewer: Plasma. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9625 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9201: Slightly reduce vertical gutter width.

Zren added a comment. So you removed 2 units from the overall cell height, but only 1 unit from the frameloader height. This means you removed 1 unit from the "leftover" padding at the bottom of the frameloader, and are overlapping the cell below by another 1 unit. Before (cellHeight=6

D7013: Middle-click on QSystemTrayIcon сauses context menu

volkov added a comment. Restricted Application added a subscriber: plasma-devel. Is there a reason why KDEPlatformSystemTrayIcon is supported? Why don't drop it and rely on Qt's dbus tray implementation? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://p

D9618: Don't send keyboard events to QWindows which have outputOnly property set

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY PlasmaCore.Dialog has a prope

Plasma 5.11.5

https://www.kde.org/announcements/plasma-5.11.5.php Plasma 5.11.5 has been released with lots of fixes in Discover -- Marco Martin

Re: 5.11.5 release (almost) done

done now On Tue, Jan 2, 2018 at 8:10 PM, Marco Martin wrote: > Hi all, > In order to have more people know about the release process of plasma, > I tried today of taking care of the 5.11.5 release. > The process went, not that smooth, but went, now all should be > uploaded and the web pages: > ht

5.11.5 release (almost) done

Hi all, In order to have more people know about the release process of plasma, I tried today of taking care of the 5.11.5 release. The process went, not that smooth, but went, now all should be uploaded and the web pages: https://www.kde.org/info/plasma-5.11.5.php and https://www.kde.org/announceme

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. Yes, I did not realize that the menu shadows being small was actually a bug in how I made the patch. https://phabricator.kde.org/tag/vdg/ definitely would like them to be smaller than the window shadows. I'll put together a follow-up patch tonight or in the coming da

D9549: Horizontally center shadows and make them bigger

rkflx added a comment. In https://phabricator.kde.org/D9549#185046, @hpereiradacosta wrote: > I just pushed the necessary modification to the second file. Thanks. Now the menu/window shadow separation work can start on a clean slate (because after re-login, as expected, the defaul

D9549: Horizontally center shadows and make them bigger

rkflx added a comment. Now I am confused. I thought the screenshots above show what the https://phabricator.kde.org/tag/vdg/ proposed, i.e. small menu shadows, large window shadows? At least I like it this way. As for how it scales with different user-set sizes (which a static screenshot

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. Ah, thank you Hugo. My apologies for introducing that bug, and thanks for cleaning up the mess. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake Cc: rkflx, zzag, cfeck, januz, rpel

D9549: Horizontally center shadows and make them bigger

abetts added a comment. The only thing that we could address later is that the concentration of this shadow for the menus makes it so that the shadows become a tad darker. Since the space they have to spread in is smaller, the colors combine a little bit making the shadow be more pronounced.

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. >> Right, that's exactly it. The old menu shadows were just hardcoded to use a smaller version of the old default size, and it didn't consult the default at all until you changed it, at which point it becomes as big as the menu shadows. > > Don't think so

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 02 Jan 2018 17:10:29 + Build duration: 6 min 33 sec and counting JUnit Tests

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#185037, @ngraham wrote: > In https://phabricator.kde.org/D9549#185034, @rkflx wrote: > > > I did not look at the complete code, but at least your patch does not contain anything which changes this coupling. I suspec

D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:32932b44e6f0: Move calls depending on $DISPLAY from startplasmacompositor to startplasma (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. In https://phabricator.kde.org/D9549#185034, @rkflx wrote: > I did not look at the complete code, but at least your patch does not contain anything which changes this coupling. I suspect to achieve the situation in the screenshots your patch relies on the fact th

D9549: Horizontally center shadows and make them bigger

rkflx added a comment. In https://phabricator.kde.org/D9549#184601, @ngraham wrote: > I can make the spinbox not affect menus; good catch. This was a pre-existing bug, but it gets bigger with the patch. Are you sure this is an old bug? Works for me (and Hugo mentioned it too), i.

D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. +1 from me too Thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9597 To: fvogt, #plasma, davidedmundson Cc: gr

D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma

graesslin added a comment. Looks good to me. Personally I would split it into two commits. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9597 To: fvogt, #plasma, davidedmundson Cc: graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, a

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 44 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 02 Jan 2018 16:42:28 + Build duration: 2 min 30 sec and counting CONSOLE OUTP

D9608: [KScreen Effect] Fade opacity only for transparent windows

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9608#184901, @broulik wrote: > > As of the effect, maybe this should rather fade in a black layer than fade out everything else? > > I suppose. Do you have a

D9612: Don't show "Edit Application..." action for non-app services.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:16c97a1645ae: Don't show "Edit Application..." action for non-app services. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9612?vs=24606&

D9612: Don't show "Edit Application..." action for non-app services.

hein updated this revision to Diff 24606. hein added a comment. Fix return statement. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9612?vs=24604&id=24606 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9612 AFFECTED FILES applet

D9608: [KScreen Effect] Fade opacity only for transparent windows

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9608#184871, @luebking wrote: > Should the lock screen not be guarded by a black layer in the compositor? On Wayland that's the case. On X11 there is a bla

D9612: Don't show "Edit Application..." action for non-app services.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9612 To: hein, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9599: Create interface for passing server decoration palettes

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9599 To: davidedmundson, #plasma, graessl

D9612: Don't show "Edit Application..." action for non-app services.

hein updated this revision to Diff 24604. hein added a comment. Don't go KService for anything but the services runner. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9612?vs=24602&id=24604 BRANCH master REVISION DETAIL https://phabricator.kde.

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. That all sounds totally reasonable to me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake Cc: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progw

D9201: Slightly reduce vertical gutter width.

hein added a comment. ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: hein, #plasma Cc: abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. @ngraham A follow up on the menu vs window decoration shadow size, and a suggestion for the window decoration shadow size option, for discussion. - right now there is an explicit 3/4 (12/16) conversion factor between the menu shadow size and the window

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9474 To: broulik, #plasma, hein, ivan Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, seb

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

broulik added a comment. Yes, and so is the activity-related stuff, see "Test plan" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9474 To: broulik, #plasma, hein, ivan Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

hein added a comment. Does the add fav stuff also move to the bottom? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9474 To: broulik, #plasma, hein, ivan Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D9549: Horizontally center shadows and make them bigger

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R31:9fb5d3abb18c: Horizontally center shadows and make them bigger (authored by ngraham). REPOSITORY R31 Breeze CHANG

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. Thanks! Also, the HiDPI shadow issue I thought was caused by this patch is also present without it (this patch just makes it more visible), so that too can be addressed in another patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9549 To

D9549: Horizontally center shadows and make them bigger

hpereiradacosta accepted this revision. hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#184905, @ngraham wrote: > @rkflx, I don't see any issues when using QT_SCALE_FACTOR to simulate HiDPI. Can you elaborate on how you got the issues to show up? > > @hpereiradac

D9549: Horizontally center shadows and make them bigger

ngraham planned changes to this revision. ngraham added a comment. Never mind, found it. Menus look off in HiDPI mode, too. Will work on this. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake Cc: rkflx, zza

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. @rkflx, I don't see any issues when using QT_SCALE_FACTOR to simulate HiDPI. Can you elaborate on how you got the issues to show up? @hpereiradacosta, are you approving this patch as-is and then we can follow up with more for the remaining issues brought up above

D9549: Horizontally center shadows and make them bigger

ngraham updated this revision to Diff 24593. ngraham added a comment. Increase maximum shadow size REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9549?vs=24457&id=24593 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 AFFECTED FILES kd

D9608: [KScreen Effect] Fade opacity only for transparent windows

broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. > As of the effect, maybe this should rather fade in a black layer than fade out everything else? I suppose. Do you have a pointer to anywhere in KWin where I could look how that's done? (That'll

D9549: Horizontally center shadows and make them bigger

rpelorosso added a comment. In https://phabricator.kde.org/D9549#184458, @ngraham wrote: > The other proposed change is https://phabricator.kde.org/D8232, by @rpelorosso, who has expressed positive sentiments about this one. @rpelorosso, would you mind closing https://phabricator.kde.org

D8232: Add option to center shadow

rpelorosso abandoned this revision. rpelorosso added a comment. Closing this revision in favor of https://phabricator.kde.org/D9549 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta

D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma

fvogt updated this revision to Diff 24589. fvogt added a comment. I don't see any such calls in kwin_wayland before the session is started, but sure. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9597?vs=24558&id=24589 BRANCH master REVISION

D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Copying my bugzilla coment. If you *moved* that call we'd need to be absolutely sure that kwin doesn't make any DBus calls before startplasma has finished proc

D9608: [KScreen Effect] Fade opacity only for transparent windows

luebking added a comment. Restricted Application edited projects, added KWin; removed Plasma. Should the lock screen not be guarded by a black layer in the compositor? As of the effect, maybe this should rather fade in a black layer than fade out everything else? REPOSITORY R108 KWin REV

D9452: [Logout screen] Don't underline button when has focus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:98f96ac6e708: [Logout screen] Don't underline button when has focus (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9452?vs=24218&id=

D6799: Apply maximize effect to full screen changes

broulik abandoned this revision. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. Superseded by https://phabricator.kde.org/D9391 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6799 To: broulik, #plasma, graesslin, #vdg Cc: n

D9452: [Logout screen] Don't underline button when has focus

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9452 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

broulik added a comment. Before F5613264: Screenshot_20180102_132001.png After F5613260: Screenshot_20180102_132323.png Especially if you have more actions at the top like "Open new tab" and the like, the f

D9608: [KScreen Effect] Fade opacity only for transparent windows

broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY When you have two wind

D9503: Only save the last update timestep on success

This revision was automatically updated to reflect the committed changes. Closed by commit R623:d9708fb7efea: Only save the last update timestep on success (authored by fvogt). REPOSITORY R623 Plasma PackageKit Updater CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9503?vs=24367&id=2

D9508: List known updates on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R623:3203b654db93: List known updates on startup (authored by fvogt). REPOSITORY R623 Plasma PackageKit Updater CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9508?vs=24377&id=24582 REVISION D

D9504: Show that the last check failed if no updates available

This revision was automatically updated to reflect the committed changes. Closed by commit R623:b372eae9c718: Show that the last check failed if no updates available (authored by fvogt). REPOSITORY R623 Plasma PackageKit Updater CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9504?vs=

D8896: Add recently added file to .qrc

janmulder added a comment. Ah stupid. It appears that @mart pushed the same fix as part of commit https://phabricator.kde.org/R169:63a7f75a79c16852683f3edaf89229e174aacca0. So this one can be reverted. Sorry. Well, that happens when stuff is sitting around for 6 weeks. REPOSITORY R169 Kir

D8896: Add recently added file to .qrc

davidedmundson added a comment. We have a somewhat silly process. It was waiting on some dev to pay attention. If it happens again, just prod the review like you just did there. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8896 To: janmulder, mart, davidedmu

D8896: Add recently added file to .qrc

This revision was automatically updated to reflect the committed changes. Closed by commit R169:09da1cca814e: Add recently added file to .qrc (authored by janmulder, committed by davidedmundson). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8896?vs=22595&id

D8896: Add recently added file to .qrc

janmulder added a comment. Ok, accepted within 7 minutes after creation, but not merged since then (19 november). Do I need to do something? Maybe I just do not understand the development model, merge rights etc? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8896

D9526: Fix system tray settings if placed on desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e6bfe5d43a22: Fix system tray settings if placed on desktop (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9526?vs=24409&id=2

D9526: Fix system tray settings if placed on desktop

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9526 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 - Build # 330 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/330/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 Date of build: Tue, 02 Jan 2018 10:03:02 + Build duration: 16 min and counting JUnit Tests Name:

D9599: Create interface for passing server decoration palettes

davidedmundson updated this revision to Diff 24569. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. replace tiny typo REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9599?vs=24565&id=24569 BR

D9599: Create interface for passing server decoration palettes

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

D9508: List known updates on startup

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R623 Plasma PackageKit Updater BRANCH fixes REVISION DETAIL https://phabricator.kde.org/D9508 To: fvogt, lukas, jgrulich Cc: ngraham, plasma-devel

D9504: Show that the last check failed if no updates available

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R623 Plasma PackageKit Updater BRANCH fixes REVISION DETAIL https://phabricator.kde.org/D9504 To: fvogt, lukas, jgrulich Cc: ngraham, plasma-devel

D9503: Only save the last update timestep on success

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R623 Plasma PackageKit Updater BRANCH fixes REVISION DETAIL https://phabricator.kde.org/D9503 To: fvogt, lukas, jgrulich Cc: ngraham, plasma-devel

Re: Plasma and Frameworks Release issue

On úterý 26. prosince 2017 17:57:32 CET David Edmundson wrote: > We have a frameworks and Plasma release schedule issue again. > > We have new API (Package::fileUrl literally everwhere and I have something > minor in kwin) that requires frameworks 5.42 > > This frameworks release comes out on the