KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 - Build # 329 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/329/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 Date of build: Mon, 01 Jan 2018 03:53:12 + Build duration: 9 min 12 sec and counting CONSOLE OUTPUT

D8232: Add option to center shadow

ngraham added a comment. Does this revision need to stay open? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson,

D9391: [effects] Add 'Fullscreen' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9391#184475, @zzag wrote: > In https://phabricator.kde.org/D9391#184440, @abetts wrote: > > > Could you please post a new video with a before and after? I would l

D9549: Horizontally center shadows and make them bigger

abetts added a comment. In https://phabricator.kde.org/D9549#184487, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9549#184007, @abetts wrote: > > > @hpereiradacosta I feel this is a good direction for the theme. I am sure we can evolve it to fit new ideas. > > > Reg

D8232: Add option to center shadow

abetts added a comment. In https://phabricator.kde.org/D8232#184486, @hpereiradacosta wrote: > In https://phabricator.kde.org/D8232#184470, @abetts wrote: > > > In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > > > > > Per recent https://phabricator.kde.org/tag/vdg/ di

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#184007, @abetts wrote: > @hpereiradacosta I feel this is a good direction for the theme. I am sure we can evolve it to fit new ideas. Regarding this (and the comment you made on the other thread), I am restating

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#184470, @abetts wrote: > In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > > > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizon

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#184458, @ngraham wrote: > I did check to make sure that tooltip shadows still look okay. Here are some more screenshots: > > Small tooltip: > F5609610: Small tooltip.png >

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. Hello Nathan, thanks In https://phabricator.kde.org/D9549#184467, @ngraham wrote: > And FWIW, @alake commented in https://phabricator.kde.org/D8232 on the subject of centered shadows: > > > Ok, I agree now that there shouldn't be an option. I thin

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9391#184440, @abetts wrote: > Could you please post a new video with a before and after? I would like to preview it. Ok, I'll do it later. But keep in mind cod

D9549: Horizontally center shadows and make them bigger

zzag added a comment. Looks great, but I think shadow size for the left and right side should be smaller. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze, alake Cc: zzag, cfeck, januz, rpeloross

D8232: Add option to center shadow

abetts added a comment. In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger: https://phab

D9549: Horizontally center shadows and make them bigger

ngraham added a comment. And FWIW, @alake commented in https://phabricator.kde.org/D8232 on the subject of centered shadows: > Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overlapping windows could be improved. The pr

D9549: Horizontally center shadows and make them bigger

ngraham added a reviewer: alake. ngraham added a comment. I did check to make sure that tooltip shadows still look okay. Here are some more screenshots: Small tooltip: F5609610: Small tooltip.png Large tooltip: F5609611: Large tooltip.png

D9391: [effects] Add 'Fullscreen' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. Could you please post a new video with a before and after? I would like to preview it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma, graesslin C

D9549: Horizontally center shadows and make them bigger

abetts added a comment. In https://phabricator.kde.org/D9549#184434, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9549#184334, @cfeck wrote: > > > I remember the shadows were made thin on the left so that cascading popup menus look smoother. > > > Hello christoph,

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#184334, @cfeck wrote: > I remember the shadows were made thin on the left so that cascading popup menus look smoother. Hello christoph, Thing is: the same (inverse) argument was used to justify centered shadow

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9391#182439, @graesslin wrote: > I'm absolutely against any changed to window gravity on X11. And I'm also not happy with a new animation if we already know that it do

Re: Plasma and Frameworks Release issue

The earliest we can do the beta is the 15th. That only gives 2 weeks for the beta, which isn't enough time. We will have to adjust the final release and therefore every patch thereafter. I can edit the wiki, but there's also a Google calendar that I don't have access to. Jonathan can you confirm y

D9555: Simulate user activity on fake input events

davidedmundson added a comment. Restricted Application edited projects, added KWin; removed Plasma. Make sure the CMakeLists.txt is bumped if it's not already. Note also my frameworks release issue thread that you've already replied to. I don't really want to make that situation worse if

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24524. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect Squash commits. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://pha

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24522. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect Add fullscreen effect to the effect loader tests. REPOSITORY R108 KWin CHANG

D9549: Horizontally center shadows and make them bigger

cfeck added a comment. I remember the shadows were made thin on the left so that cascading popup menus look smoother. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9549 To: ngraham, abetts, hpereiradacosta, #vdg, #breeze Cc: cfeck, januz, rpelorosso

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. In https://phabricator.kde.org/D9549#184323, @hpereiradacosta wrote: > I have no objection to the change, in principle. > Now: > > - I feel that the top shadow at least should be somewhat smaller than the three other sides. Comments welcome

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. I have no objection to the change, in principle. Now: - I feel that the top shadow at least should be somewhat smaller than the three other sides. Comments welcome - could you check with ALake. He is also VDG and the original style/decoration designe

D9549: Horizontally center shadows and make them bigger

hpereiradacosta added a comment. Please no commit. The patch is _incomplete_. As already stated, there is a need for a matching change in the widget style, for the same shadow to apply to menus, tooltips, and combobox dropdown. I have such a change ready locally already. Just have not had

D9391: [effects] Add 'Fullscreen' effect

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. As this adds a new effect: all the effectloader autotests need to be adjusted, otherweise the tests will start to fail. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 T