abetts added a comment.
@hpereiradacosta I feel this is a good direction for the theme. I am sure we
can evolve it to fit new ideas.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: januz, rp
januz added a comment.
I knew it would look better, but not //this// much better!
Please accept this change
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: januz, rpelorosso, apol, mvourlak
ostroffjh added a comment.
Is there a problem with this, or has it simply fallen through the cracks?
REPOSITORY
R113 Oxygen Theme
REVISION DETAIL
https://phabricator.kde.org/D8267
To: ostroffjh, #plasma
Cc: asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
alexeymin added a comment.
I don't spot any obvious problems in QML any more. And I like newer version
more than previous...
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D9542
To: ngraham, apol, #vdg, #discover_software_store
Cc: januz, alexeymin,
rpelorosso added a comment.
These new shadows look amazing! :D
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: rpelorosso, apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali
ngraham added a comment.
No matter what, I will definitely wait for at least @hpereiradacosta to weigh
in.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: apol, mvourlakos, plasma-devel, Zre
mvourlakos added a comment.
no prob then!
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: apol, mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
mvourlakos added a comment.
In https://phabricator.kde.org/D9549#183814, @abetts wrote:
> In https://phabricator.kde.org/D9549#183809, @apol wrote:
>
> > In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote:
> >
> > > Dont merge please, this needs authorization from VDG f
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D9542
To: ngraham, apol, #vdg, #discover_software_store
Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts
ngraham updated this revision to Diff 24470.
ngraham marked 2 inline comments as done.
ngraham added a comment.
- Use a larger font instead of bold for the caption
- Put the homepage on top, too
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:361ee31606fb: startplasmacompositor: If available, query
org.freedesktop.locale1 for XKB… (authored by fvogt).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
localed
REVISION DETAIL
https://phabricator.kde.org/D9512
To: fvogt, #plasma, graesslin
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
al
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application edited projects, added Plasma; removed KWin.
REVISION SUMMARY
This ensures that using KDE C
graesslin added inline comments.
INLINE COMMENTS
> McPain wrote in decoratedclientprivate.h:79-80
> I need to avoid sover increasing, right?
No, increasing the soversion of the private library is fine. It's only used by
KWin and by KDecoration public library. The interface to the decoration plu
abetts added a comment.
In https://phabricator.kde.org/D9549#183809, @apol wrote:
> In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote:
>
> > Dont merge please, this needs authorization from VDG first
>
>
> @ngraham and @abetts are the VDG, no?
Last I checked
apol added a comment.
In https://phabricator.kde.org/D9549#183807, @mvourlakos wrote:
> Dont merge please, this needs authorization from VDG first
@ngraham and @abetts are the VDG, no?
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
T
mvourlakos added a comment.
Dont merge please, this needs authorization from VDG first
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: mvourlakos, plasma-devel, ZrenBot, progwolff, lesliezhai
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4595a2c2709e: [server] Add a method
IdleInterface::simulateUserActivity (authored by graesslin).
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
CHANGED PRIOR TO COMMIT
abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.
I love it! People, please accept. Just notice how the depth perception works
better this way. With the current implementation, shadows don't show a strong
depth perception and they almost d
ngraham added a comment.
Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put
together a patch that changes the defaults to horizontally center window and
menu shadows, and make them a bit larger: https://phabricator.kde.org/D9549
REPOSITORY
R31 Breeze
REVISION DETAIL
h
ngraham added a comment.
I could do a bigger font instead of bold, sure.
As for going around in circles: sorry, I wasn't around a few releases ago, so
I didn't know what it looked like back then. But folks do seem to think this is
nicer than the status quo...
REPOSITORY
R134 Discover
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9549
To: ngraham, abetts, hpereiradacosta, #vdg, #breeze
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
apol added a comment.
We used to have exactly this same layout for that section few releases ago,
let's not keep doing the same changes over and over.
Also I'm not a big fan of the bold. Maybe it would make sense to make the
font slightly bigger?
REPOSITORY
R134 Discover Software Stor
ngraham added a comment.
Good idea, I'll do that too.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D9542
To: ngraham, apol, #vdg, #discover_software_store
Cc: januz, alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterbe
januz added a comment.
+1 Definitely an improvement. What do you think about grouping the homepage
with the rest of the info at the top?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D9542
To: ngraham, apol, #vdg, #discover_software_store
Cc: januz,
ngraham marked 2 inline comments as done.
ngraham added inline comments.
INLINE COMMENTS
> alexeymin wrote in ApplicationPage.qml:153
> Why do you put a `Text` inside a label? Why not use `font.bold` property of
> Label itself?
This was actually the only way I could get it to work. Doing this:
ngraham updated this revision to Diff 24456.
ngraham added a comment.
- Merge branch 'master' of git.kde.org:discover
- Address review comments
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9542?vs=2&id=24456
BRANCH
master
REVISIO
McPain planned changes to this revision.
McPain added a comment.
UPD:
As the secondary monitor switches off, windows on it doesn't move to the
primary
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D9506
To: McPain, sebas, drosca
Cc: ngraham, plasma-devel,
28 matches
Mail list logo
