D9271: Fixed memory leak in new_argv

anthonyfieroni added inline comments. INLINE COMMENTS > Viewer.cpp:143 > viewer=new KFI::CViewer; > viewer->show(); > } You should set attribute delete on close as well. > standard_actions_module.cpp:136 > m_editor->addCollection(m

Re: Plasmoid debugging

On 12/12/17 21:50, Aleix Pol wrote: That's because some distributions change stuff so debug information don't show up on the users' systems. Thank you! Googling for QT_LOGGING_RULES gave me this page which is what I had been missing, http://doc.qt.io/qt-5/qloggingcategory.html And sure enough

D9304: Get the padding into the header

apol added a comment. After F5544256: Screenshot_20171213_010457.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9304 To: apol, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D9304: Get the padding into the header

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Used to be inside, something happened at some point REPOSITORY R169 Kirigami BRANCH master REVISION DETA

D9271: Fixed memory leak in new_argv

nathanhenry updated this revision to Diff 23839. nathanhenry added a comment. Fixed m_actionCollection, manager and solved viewer REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9271?vs=23837&id=23839 BRANCH Memory-Leak-Fixes REVISION DETAIL htt

D9271: Fixed memory leak in new_argv

davidedmundson added inline comments. INLINE COMMENTS > joydevice.cpp:197 >origCorr = oldCorr; > + delete [] oldCorr; //We should be deleting this when it fails and after > use. >corr = new struct js_corr[axes]; When you do this origCorr is now a dangling pointer to deleted contents.

D9271: Fixed memory leak in new_argv

nathanhenry added inline comments. INLINE COMMENTS > davidedmundson wrote in Viewer.cpp:145 > and then it will crash here. Should this be dereferenced outside the loop or not at all? > davidedmundson wrote in kcm.cpp:83-85 > The runner manager has a parent object. > > http://doc.qt.io/qt-5/obj

D9271: Fixed memory leak in new_argv

davidedmundson added inline comments. INLINE COMMENTS > nathanhenry wrote in Viewer.cpp:140-143 > More info? you're deleting an object immediately after show. That will close the dialog > Viewer.cpp:145 > } > viewer->showUrl(url); > + delete viewer

D9271: Fixed memory leak in new_argv

nathanhenry marked 2 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9271 To: nathanhenry, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D9271: Fixed memory leak in new_argv

nathanhenry updated this revision to Diff 23837. nathanhenry added a comment. Fixed indentation and removed new_argv and new_argc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9271?vs=23692&id=23837 BRANCH Memory-Leak-Fixes REVISION DETAIL htt

D9271: Fixed memory leak in new_argv

nathanhenry added inline comments. INLINE COMMENTS > davidedmundson wrote in Viewer.cpp:140-143 > that can't be right. More info? > davidedmundson wrote in kcm.cpp:83-85 > 1. this doesn't leak > > 2. what's the point of making a manager? How doesn't this leak when excluding my change? REPOSI

Fwd: KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 4 - Failure!

Can someone please look into this? The latest commit introduces a new dependency and the build metadata hasn't been updated :( In future please make sure the build metadata is updated prior to landing changes. -- Forwarded message -- From: "CI System" Date: 13/12/2017 4:15 AM Su

Re: Advance Downtime Notification

On Wed, Nov 29, 2017 at 8:11 PM, Ben Cooksley wrote: > Hi all, Hi everyone, > > Over the past 24 hours we have received initial warning notifications > that a disk in our bulk storage server has begun to show signs of > failure. We have now begun the process of having this disk replaced, > follo

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9288: support for defining autostart apps in lnf packages

mvourlakos added a comment. In https://phabricator.kde.org/D9288#178638, @mart wrote: > we could add a new named file in the lnf package for the latte layout: in what format is it exported? > so lattedock upon startup may go read that file (is already possible for any app to access th

D9300: Store screenMapping info only once

amantia added reviewers: Plasma, mwolff, hein, broulik. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9300: Store screenMapping info only once

amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Until now every FolderView applet stored exactly the same screenMapping info in the config file. Store it only once using the config object

D9298: Only search when search field is accepted

This revision was automatically updated to reflect the committed changes. Closed by commit R134:1990b3b8b119: Only search when search field is accepted (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9298?vs=23815&id=23816 R

D9298: Only search when search field is accepted

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good and works fine. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D9298 To: apol, #plasma, ngraham Cc: plasma-devel, Zre

D9298: Only search when search field is accepted

apol created this revision. apol added reviewers: Plasma, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Saves a bunch of intermediate requests that aren't super useful TEST PLAN Searched a bit, feels nice RE

D9201: Slightly reduce vertical gutter width.

abetts added a comment. Does the grid and spacing cover only the areas in yellow, or does it cover the entire screen? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: hein, #plasma Cc: abetts, Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D9215: Make Appmenu work based on the presence of a visual representation

abetts added a comment. In https://phabricator.kde.org/D9215#178733, @davidedmundson wrote: > > Is there a screenshot of this change? > > It's effectively non visual Love it! ha! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9215 To: mart,

D9284: Make it obvious what "Display window borders for maximized windows" is for

abetts added a comment. Looks good! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: abetts, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9215: Make Appmenu work based on the presence of a visual representation

davidedmundson added a comment. > Is there a screenshot of this change? It's effectively non visual REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9215 To: mart, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, mvourlakos, broulik, plasma-d

D9215: Make Appmenu work based on the presence of a visual representation

abetts added a comment. Is there a screenshot of this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9215 To: mart, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, mvourlakos, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D9287: disappearing scrollbars on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b2f61f8e3c9f: disappearing scrollbars on mobile (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9287?vs=23809&id=23814 REVISI

D9267: remove menubar settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ae09827caaad: remove menubar settings (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9267?vs=23682&id=23813 REVISION DETAIL https://pha

D9216: export org.kde.appmenuview

This revision was automatically updated to reflect the committed changes. mart marked an inline comment as done. Closed by commit R108:6b6875166f2f: export org.kde.appmenuview (authored by mart). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES S

D9215: Make Appmenu work based on the presence of a visual representation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:19ab6f3bbe55: Make Appmenu work based on the presence of a visual representation (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9215?vs=23806&id=23810#toc REPOSITORY R120

D9287: disappearing scrollbars on mobile

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D9287 REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks

D9287: disappearing scrollbars on mobile

mart marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma, bshah Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9287: disappearing scrollbars on mobile

mart updated this revision to Diff 23809. mart added a comment. - fix deps REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9287?vs=23761&id=23809 BRANCH arcpatch-D9287 REVISION DETAIL https://phabricator.kde.org/D9287 AFFECTED FILES

D9287: disappearing scrollbars on mobile

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in DefaultListItemBackground.qml:23 > does this change kill this? > > If so +1000 ah, yes it does, will remove REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9287 To: mart, #plasma

D9215: Make Appmenu work based on the presence of a visual representation

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D9215 REVISION DETAIL https://phabricator.kde.org/D9215 To: mart, #plasma, davidedmundson Cc: davidedmundson, ngraham, mvourlakos, broulik, plasma-devel

D9288: support for defining autostart apps in lnf packages

mart updated this revision to Diff 23805. mart added a comment. - e Qtring::section REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9288?vs=23764&id=23805 BRANCH phab/lnfautostartwq! REVISION DETAIL https://phabricator.kde.org/D9288 AFFECTED FI

D9288: support for defining autostart apps in lnf packages

mart marked 2 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9288 To: mart, #plasma Cc: ngraham, mvourlakos, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9215: Make Appmenu work based on the presence of a visual representation

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in appmenuapplet.cpp:60 > I don't understand what this else clause is about it registers or unregisters the service when the destroyed value of the applet change, and not in the dtor, becau

D9215: Make Appmenu work based on the presence of a visual representation

mart updated this revision to Diff 23806. mart marked an inline comment as done. mart added a comment. - better comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9215?vs=23600&id=23806 BRANCH arcpatch-D9215 REVISION DETAIL https://phabr

D9288: support for defining autostart apps in lnf packages

mart added inline comments. INLINE COMMENTS > apol wrote in kcm.cpp:387 > Also I'm not sure if it works, but something along the lines of `systemctl > --user stop servicename` should work. Or at least it's a thing. it seems to look for a systemd service file? REPOSITORY R119 Plasma Desktop

D9284: Make it obvious what "Display window borders for maximized windows" is for

ngraham added a comment. Done, thanks! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9284: Make it obvious what "Display window borders for maximized windows" is for

ngraham added a comment. Sounds good! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9284: Make it obvious what "Display window borders for maximized windows" is for

hpereiradacosta added a comment. Side note: feel free to push the same thing in the oxygen repo. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D9284: Make it obvious what "Display window borders for maximized windows" is for

ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasmoid debugging

On Tue, Dec 12, 2017 at 7:23 AM, Mark Constable wrote: > I hope it's okay to ask a lame question about simply enabling debug > output to the launching shell from a plasmoid via kpackagelauncherqml. > My desktop is Ubuntu bionic with kubuntu-ci/stable packages and I am > following the first example

D9288: support for defining autostart apps in lnf packages

mart added a comment. In https://phabricator.kde.org/D9288#178442, @mvourlakos wrote: > in the future would it be possible for these apps to include also their layout in the Look N' Feel package? > For example Latte supports import/export of its layouts so it is possible to dynamicall

D9207: Don't load KDE platform module in kglobalaccel5

davidedmundson added a comment. > The description: "I'm not as sure on this..." and "but from code skimming I can't see anything that I went through this code thoroughly recently for a change I made. We know we don't have any graphical widgets used anywhere; the use of QGuiApplication

D7246: Tooltips

McPain edited the summary of this revision. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D7246: Tooltips

McPain updated this revision to Diff 23794. McPain added a comment. Moved QToolTip::showText to KWin REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=22886&id=23794 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES

D9216: export org.kde.appmenuview

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH arcpatch-D9216 REVISION DETAIL https://phabricator.kde.org/D9216 To: mart, #kwin, #plasma, davidedmundson

D9215: Make Appmenu work based on the presence of a visual representation

davidedmundson added inline comments. INLINE COMMENTS > appmenuapplet.cpp:60 > +//if we're the first, regster the service > +if (++s_refs == 1) { > + > QDBusConnection::sessionBus().interface()->registerService(s_viewService, I don't understand what this e

D9284: Make it obvious what "Display window borders for maximized windows" is for

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks a lot. Works for me. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: p

D9201: Slightly reduce vertical gutter width.

hein updated this revision to Diff 23791. hein added a comment. Fix overlap. Thanks for the analysis. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9201?vs=23499&id=23791 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9201 AFFECTE