D9163: Save gtk3 configuration to dconf as well

2017-12-10 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R99:87040960da7e: Save gtk3 configuration to dconf as well (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9163?vs=23414&id=23746#toc REPOSITORY R99 KDE Gtk Configuration T

D9171: Remove concept of multihead in kcminit

2017-12-10 Thread Aleix Pol Gonzalez
apol added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9171 To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9223: [Plasma Dialog] Call window effects only if visible

2017-12-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9223 To: broulik, #plasma, graesslin, apol Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D9026: Sort list of installed apps alphabetically

2017-12-10 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9026 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9026: Sort list of installed apps alphabetically

2017-12-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D9026 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9174: Remove multihead from Plasmashell scripting

2017-12-10 Thread Aleix Pol Gonzalez
apol added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9174 To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9163: Save gtk3 configuration to dconf as well

2017-12-10 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH master REVISION DETAIL https://phabricator.kde.org/D9163 To: jgrulich, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D6764: Use a smaller font size for digital clock plasmoid

2017-12-10 Thread Diego Gangl
januz added a comment. In https://phabricator.kde.org/D6764#178028, @romangg wrote: > Why did you change the 0.56 * main.height value in case a date is shown? Reduces the clock size in two line mode and in this mode it was not too big. main.height is relative to the panel size. It

D6764: Use a smaller font size for digital clock plasmoid

2017-12-10 Thread Diego Gangl
januz updated this revision to Diff 23742. januz added a comment. Add units.smallSpacing to single line height REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6764?vs=23710&id=23742 BRANCH clock3 REVISION DETAIL https://phabricator.kde.org/D67

D9207: Don't load KDE platform module in kglobalaccel5

2017-12-10 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D9207#176322, @graesslin wrote: > I'm against a risky change here. Especially as this becomes irrelevant with Wayland. What makes it risky? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To

D9197: experimental support for rcc files loading in kpackage

2017-12-10 Thread Aleix Pol Gonzalez
apol added a comment. +1 What's the plan here? INLINE COMMENTS > package.cpp:550 > + > QResource::registerResource(dir.absoluteFilePath(QStringLiteral("contents.rcc"))); > +dir = QDir(QStringLiteral(":")+defaultPackageRoot()+path); > +} QLatin1Char(':') +

D9136: Add support for version 3 of data device manager interface

2017-12-10 Thread Nathaniel Graham
Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9136 To: graesslin, #frameworks, #plasma, #kwin Cc: ngraham, broulik, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mo

D9282: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R113:2dfb48a5ce16: Fix indentation of icon for left aligned toolbuttons (authored by rkflx). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9282?vs=23734&id=23739

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-10 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-10 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added reviewers: hpereiradacosta, Breeze, VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9284 To: ngraham, hpereiradacosta, #breeze, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D9281: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R31:f0444f600b97: Fix indentation of icon for left aligned toolbuttons (authored by rkflx). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9281?vs=23733&id=23738 REVISION

D9284: Make it obvious what "Display window borders for maximized windows" is for

2017-12-10 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Change "Display window borders for maximized windows" to "Display window borders and allow resizing for maximized windows" This makes it

D9281: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D9281#178197, @hpereiradacosta wrote: > You might also want to check the close to identical code for oxygen, in case it also applies. Has already been done in https://phabricator.kde.org/D9282, see mentions above your comment

D9281: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
rkflx edited the summary of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9281 To: rkflx, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9282: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
rkflx edited the summary of this revision. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D9282 To: rkflx, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9281: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks for the patch ! Sounds correct. Feel free to submit and to backport to plasma/5.11 You might also want to check the close to identical code for oxygen, in case

D9281: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
rkflx added a comment. This is currently based on the `master` branch, but might be material for `Plasma/5.11` as well. Please tell me where this should land in the end, and how merging/cherrypicking/... works in this repo (the commit history is not entirely consistent regarding this). REPO

D9282: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
rkflx created this revision. rkflx added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Gwenview's Operations sidebar uses custom `QToolButtons` which are wide and left aligned. Special supp

D9281: Fix indentation of icon for left aligned toolbuttons

2017-12-10 Thread Henrik Fehlauer
rkflx created this revision. rkflx added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Gwenview's Operations sidebar uses custom `QToolButtons` which are wide and left aligned. Special supp

D9136: Add support for version 3 of data device manager interface

2017-12-10 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > broulik wrote in datadevicemanager.h:74 > Should `Ask` perhaps become a bigger number in case stuff gets added in the > middle later like `Link` or is that unlikel

D9136: Add support for version 3 of data device manager interface

2017-12-10 Thread Kai Uwe Broulik
broulik added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. lgtm INLINE COMMENTS > datadevice.cpp:177 > { > +if (d->drag.offer) { > +delete d->drag.offer; `delete nullptr` is just fine > datadevicemanager.h:74 > +Move = 1 <<

D9136: Add support for version 3 of data device manager interface

2017-12-10 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9136 To: graesslin, #frameworks, #plasma, #kwin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-12-10 Thread Joan Maspons
maspons added inline comments. INLINE COMMENTS > constants.h:81 > +1., 0.89576933, 0.79989606, > +1., 0.90198230, 0.81465502, /* 5K */ > +1., 0.90963069, 0.82838210, 5000K ? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928

D9200: Move touchpad kcm_init phase

2017-12-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:81d7aedf8b13: Move touchpad kcm_init phase (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9200?vs=23497&id=23726 REVISION DETA

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-12-10 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928 To: romangg, #kwin, graesslin Cc: evpokp, HuShifang, jriddell, ngraham, leezu, behrmann, cfeck, graesslin, davidedmundson, plasma-devel,

D6764: Use a smaller font size for digital clock plasmoid

2017-12-10 Thread Roman Gilg
romangg added a comment. Why did you change the 0.56 * main.height value in case a date is shown? Reduces the clock size in two line mode and in this mode it was not too small. Also the clock with height units.iconSizes.small is a bit too small in comparision to the other icons left and