ivan added a comment.
I've pushed this patch with a few changes (don't want to wait the last moment
before the string freeze).
Changes are:
- Added a dialogue icon so that it looks more like the default password widget
- Fixed the i18n invocation - i18n("something %1").arg("else")
This revision was automatically updated to reflect the committed changes.
Closed by commit R845:b80ee599b39f: Fix PWD dialog (authored by cryptodude,
committed by ivan).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8787?vs=23122&id=23676#toc
REPOSITORY
R845 Plasma Vault
CHANGES SINC
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1d3d4b101343: Cleanup color scheme manager part of KCM
Deco code (authored by davidedmundson).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
CHANGES SINCE
ngraham added a comment.
In https://phabricator.kde.org/D9255#177665, @januz wrote:
> At least for the use-case of screenshots, opening the folder is way more
useful since you usually want to send the file to someone (and you can drag and
drop it on telegram, kmail, etc.).
Yes, t
januz added a comment.
+1 for this patch. The three-line buttons happen in many other places too
(dolphin, window title bars, firefox, chrome, etc.). Users quickly learn that
pattern and recognize it as the "menu button" so I don't think that would be a
problem.
A possible tweak for thi
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:037a4ffa467d: Disconnect shortcutedit slot on widget
destruction (authored by davidedmundson).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9258?vs=23656&id=23660
ngraham added a comment.
I'm not sure we should remove the Open button. That seems like it would be
going backwards in the usability department, because again, a lot of people
won't think to click on the picture. A visible button that //looks// like a
button and has a word in the imperitive
romangg added a comment.
In https://phabricator.kde.org/D9255#177612, @ngraham wrote:
> You can already right-click on the image to pull up the menu. The problem
is that it's a hidden UI; many will miss it because they won't think to
right-click on the image.
>
> Could we maybe make
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9258
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensre
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9248
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, progwol
ngraham added a comment.
You can already right-click on the image to pull up the menu. The problem is
that it's a hidden UI; many will miss it because they won't think to
right-click on the image.
Could we maybe make it a separated button under Open for the common case
where the notific
graesslin added a comment.
In https://phabricator.kde.org/D7246#177383, @McPain wrote:
> In https://phabricator.kde.org/D7246#171923, @graesslin wrote:
>
> > But long story short: for KWin the best is a request from KDecoration
"showTooltip(const QString &)" and KWin creates the toolt
graesslin added a comment.
I'm not really used to being addressed as Martin F. yet - I just realized.
I see pro and cons for both. Personally I think it is better to have destinct
interfaces for different functionality. It's easier for the case that someone
else wants to reuse this. And
davidedmundson updated this revision to Diff 23657.
davidedmundson added a comment.
Fix a hypothetical case of the manager not existing and the QPT being used
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9248?vs=23637&id=
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
If the widget is destroyed the connect still exists with a dangling
cap
romangg added a comment.
Or should we remove the "Öffnen/Open" button? Left click on a preview image /
item (with tooltip what will happen) would then do this "default action". Right
click (or click on the hamburger menu) would show alternative options in the
menu.
REPOSITORY
R120 Plasma
broulik added a comment.
> put it right under the existing Open button
That'll make the code more complex as currently the `ThumbnailStrip.qml` is
fully self-contained. Also that won't really work for multiple thumbnails
further complicating things.
REPOSITORY
R120 Plasma Workspace
R
ngraham added a comment.
Love the idea and the feature. Not sure I'm a fan of making this a hamburger
menu with no text, and putting it inside the preview. My preference would be to
put it right under the existing Open button and give it a label
("Menu/Options/More/something else"). Let's se
broulik created this revision.
broulik added reviewers: Plasma, VDG, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Makes it more obvious there's a menu with more options.
You can still right-click the thumbnai
ngraham added a reviewer: elvisangelaccio.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D4193
To: arichardson, #plasma, elvisangelaccio
Cc: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel,
ZrenBot, progwolff,
davidedmundson added a comment.
Martin F: One idea suggested was to use the same interface for all generic
window -> kwin specific things and move the server side palette into the same
interface.
It'd mean a few renames, but be a lot less work overall, particularly when we
want to add n
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Also fixed to handle the case of surfaces not having the lifespan of the
window, which the ol
davidedmundson added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> mart wrote in settings.cpp:159
> to make it not default anymore you mean?
Yes please.
Otherwise you'd be adding it to everyone's kwin automatically.
REPOSITORY
R108 KWin
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/kpackageinctor
REVISION DETAIL
https://phabricator.kde.org/D9123
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks,
mart added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> davidedmundson wrote in settings.cpp:159
> Remove this please.
to make it not default anymore you mean?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9216
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:11d25c15254f: [kimpanel] Use automoc keyword for
kimpanel-scim-panel (authored by romangg).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9245?vs=23624&id=2
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in applet.cpp:98
> If anyone uses the old argument list syntax (where the first argument was a
> string or a kpluginmetadata) this will break.
>
> Can we be sure that the PluginLoader was the only user?
> It was a somewhat und
mart added inline comments.
INLINE COMMENTS
> broulik wrote in containmentconfigview.cpp:127
> Does that still work given you changed `filePath` to `fileUrl.toString()`?
yes, seems to work fine
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9237
To: mart, #p
sebas added a subscriber: jensreuterberg.
sebas added a comment.
@dvratil Good question. I actually have a branch that adds an OSD to kscreen.
It's in sebas/osd right now and I haven't merged it since it behaves weirdly on
Wayland (placement is not reliable). That should be the start. The pla
McPain added a comment.
In https://phabricator.kde.org/D7246#171923, @graesslin wrote:
> But long story short: for KWin the best is a request from KDecoration
"showTooltip(const QString &)" and KWin creates the tooltip window, positions
it and ensures it works correctly.
Any idea
30 matches
Mail list logo
