ivan added a comment.
Hi @abetts , we need a nice dialogue that shows the password entry for
unlocking a vault. You have the current proposal screenshot above.
To me, it looks misaligned (the second line).
You have the rationale @cryptodude had for keeping it in a separate line
inst
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Do you even need to set automoc? it should be automatic with the right ecm
setup.
Please backport too.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabr
subdiff created this revision.
subdiff added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
With self-compiled Qt5.10 I wasn't able to compile plasma-desktop because of
this. Fixes it.
REPOSITORY
R
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9239
To: davidedmundson, #plasma, graesslin
Cc: plasma-dev
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:98aa41f388f4: [RunnerManager] Don't mess with
ThreadWeaver thread count (authored by broulik).
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9240?vs=23616&id=23619
sitter accepted this revision.
sitter added a comment.
I love it
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks, davidedmundson, sitter
Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai, ali
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
lesl
broulik updated this revision to Diff 23616.
broulik retitled this revision from "[RunnerManager] Use
QThread::idealThreadCount() instead of going through Solid" to "[RunnerManager]
Don't mess with ThreadWeaver thread count".
broulik edited the summary of this revision.
broulik edited the test pl
sitter added a comment.
It seems to me the only reason we have custom code to set the max count is
because of that `maxThreads` config entry. An entry for which I can't see any
UI backing, so it's borderline usless to begin with. The qMin then destroys any
remaining use that entry may have h
davidedmundson requested changes to this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
We're all happy with the concept then. \o/
INLINE COMMENTS
> appmenu.cpp:73
> +
> void ApplicationMenu::updateApplicationMenuEnabled()
> {
davidedmundson added inline comments.
INLINE COMMENTS
> runnermanager.cpp:105
> if (numThreads > Queue::instance()->maximumNumberOfThreads()) {
> Queue::instance()->setMaximumNumberOfThreads(numThreads);
> }
Threadweaver defaults to
inventoryMax(qMax(4, 2 * QThrea
broulik added reviewers: Plasma, Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D9240
To: broulik, #plasma, #frameworks
Cc: plasma-devel, #frameworks, Zre
broulik added inline comments.
INLINE COMMENTS
> runnermanager.cpp:107
> const int maxThreads = config.readEntry("maxThreads", 16);
> -const int numThreads = qMin(maxThreads, 2 + ((numProcs - 1) * 2));
> -//qCDebug(KRUNNER) << "setting up" << numThreads << "threads for" <
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7e2801974ab5: [Folder View] Show "Widgets
unlocked" help only for containment (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9222?vs=2
davidedmundson added a comment.
> Can I submit this revision first and follow up with another later if filter
is not working? Because currently it is not building on arm64 at all and I have
no other way to test it without it getting build.
I'll test it
REPOSITORY
R133 KScreenLocker
R
bshah added a comment.
In https://phabricator.kde.org/D9225#176791, @graesslin wrote:
> I think you also need to adjust the actual seccomp filtering. I don't know
whether the filter works at all if the syscalls don't exist.
Can I submit this revision first and follow up with anoth
Hi all,
please fill in all the awesome work you've been doing for Plasma 5.12's release
announcement, beta due 4 January, release 25 January.
https://notes.kde.org/p/plasma_5_12
Since this is an LTS release and our second one after 5.8 we should do a
similar "what is Plasma" general announceme
broulik added a comment.
Patch submitted to remove the workaround in `QLineEditIconButton`:
https://codereview.qt-project.org/#/c/213798/
I also made a patch for `QCommonStyle` but that affects all styles in
probably undesired ways (I get hover effects in tool buttons and menus for
Fusi
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
PreviewCient is internal to the KCM, it's not used by actual decorations
where we ne
davidedmundson abandoned this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8159
To: davidedmundson, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, #frameworks, ZrenBo
broulik added a comment.
> to asign the icon to the clear button
in principle it affects all action buttons, e.g. the "reveal password"
button, it's not limited to the clear icon.
> Would it not be better to file a bug and send a patch upstream ?
Probably. I'll look into Qt co
hpereiradacosta added a comment.
In https://phabricator.kde.org/D9227#177017, @broulik wrote:
> So that in `polish()` I change the icon for `QLineEditIconButton` to be a
`QIcon` which has manually put the `QIcon::Active` pixmaps in `QIcon::Selected`
category? However what are the implica
broulik added a comment.
So that in `polish()` I change the icon for `QLineEditIconButton` to be a
`QIcon` which has manually put the `QIcon::Active` pixmaps in `QIcon::Selected`
category? However what are the implications of this wrt speed (how often is
`polish` called, I don't think I can
broulik added inline comments.
INLINE COMMENTS
> containmentconfigview.cpp:127
> +KPackage::Package pkg =
> KPackage::PackageLoader::self()->loadPackage("Plasma/Wallpaper",
> m.pluginId());
> +
> m_wallpaperConfigModel->appendCategory(pkg.metadata().iconName(),
> pkg.me
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D9195_1
REVISION DETAIL
https://phabricator.kde.org/D9195
To: mart, #plasma, davidedmundson
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, a
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
in the wallpaper config dialog
there was custom code duplicating listing of kpackage, just wrong
(if the same w
mart retitled this revision from "fix wallpaper config and logout screen" to
"port logout screen to kpackage fileUrl".
mart edited the summary of this revision.
mart edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9195
To
mart added a comment.
In https://phabricator.kde.org/D9195#176145, @broulik wrote:
> Can we please not mingle three separate things into one commit
now the wallpaper dialog related parts are removed, is only about the logout
dialog
REPOSITORY
R120 Plasma Workspace
REVISION DET
mart updated this revision to Diff 23602.
mart added a comment.
- split out wallpaper config
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9195?vs=23487&id=23602
BRANCH
arcpatch-D9195_1
REVISION DETAIL
https://phabricator.kde.org/D9195
AFFE
mart updated this revision to Diff 23600.
mart added a comment.
remove dead code
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9215?vs=23536&id=23600
BRANCH
phab/autoappmenu
REVISION DETAIL
https://phabricator.kde.org/D9215
AFFECTED FILES
mart added inline comments.
INLINE COMMENTS
> mvourlakos wrote in appmenu.cpp:211
> is this ok? isnt that return blocks any code below?
eww, right, a leftover.. it means that the whole content of the method should
get droppped now as there is no such thing as reloading configuration.
the method
31 matches
Mail list logo
