davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Use of static is a hack.
If this fixes anything, it means there's a bug elsewhere that needs finding.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DE
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9119
To: hein, #plasma, davidedmundson, broulik, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesl
hein created this revision.
hein added reviewers: Plasma, davidedmundson, broulik.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Plasma::Svg initializes SvgPrivate::scaleFactor to 1.0. On systems with
a higher
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4ce50cc61f67: Don't tear down renderer and other
busy work when Svg::setImagePath is invoked… (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabr
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9115
To: hein, #plasma, davidedmundson, mart, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, l
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in breezedecoration.cpp:479
> are you sure contains is correct here? If repaint Region intersects the
> titleRect it should get repainted?
Only if `proper = true` is set, the rect would need to be entirely contained
inside the ot
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
During my plasmashell startup this saves time for 17 calls. Opening
something like
graesslin added inline comments.
INLINE COMMENTS
> breezedecoration.cpp:479
>
> +if ( !titleRect.contains(repaintRegion) ) return;
> +
are you sure contains is correct here? If repaint Region intersects the
titleRect it should get repainted?
REPOSITORY
R31 Breeze
REVISION DETAIL
mart updated this revision to Diff 23300.
mart added a comment.
- Merge branch 'master' into phab/minimizekpackage
- fix build
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9113?vs=23296&id=23300
BRANCH
phab/minimizekpackage
REVISI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens
broulik updated this revision to Diff 23298.
broulik added a comment.
- Fix logic error
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9114?vs=23297&id=23298
REVISION DETAIL
https://phabricator.kde.org/D9114
AFFECTED FILES
kdecoration/breezedecoration.c
broulik planned changes to this revision.
broulik added a comment.
Breaks rendering of title bar buttons on hover
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali
broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta, graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Resized my windows with super large border size, painted properly. Did not
repaint the t
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
- only one kpackage per applet, minimizes the metadata() cache misses (and
access to json)
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8e3a16040a7: [IconItem] Use ItemSceneHasChanged rather
than connect on windowChanged (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9111?vs=23292&id=23295#toc
REPOSITOR
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:da2b6e270fb6: [Icon Item] Explicitly emit overlaysChanged
in the setter rather than… (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9112
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
There's literally just one place where this thing changes so just emit the
signal ther
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
The render loop is responsible for calling polish, I don't think it will
without a window.
I can't this really making a difference. ..but nor any harm.
REPOSITORY
R24
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Saves a connection and also only schedule if we actually have a window
TEST PLAN
`sc
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1f9b5ed657df: Performance (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9109?vs=23283&id=23285
REVISION DETAIL
https://pha
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9109
To: apol, #frameworks, #plasma, hein
Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed
apol updated this revision to Diff 23283.
apol added a comment.
Remove crazy check
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9109?vs=23282&id=23283
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9109
AFFECTED FILES
hein added inline comments.
INLINE COMMENTS
> packageurlinterceptor.cpp:166
> +const int firstSlash = relativePath.indexOf(QLatin1Char('/'));
> +const QString filename = firstSlash >= 0 && firstSlash <
> relativePath.size() ? relativePath.mid(firstSlash + 1) : relativePath;
> +
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Remove splitting + joining of a string just to remove the beginning of a
string.
Remove d
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b8b8a69fd1a3: Remove implicit string casting (authored by
apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9108?vs=23277&id=23279
REVISION
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9108
To: apol, #plasma, #frameworks, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je
apol created this revision.
apol added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Follow the KF5 guidelines
TEST PLAN
Plasma shell starts
REPOSITORY
R242 Plasma Framewor
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:bf39f91db8de: Dict applet: implement config dialog for
choosing a dictionary (authored by dfaure).
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2e0fd299caba: Port the dict applet to KF5 and QtQuick 2
(authored by dfaure).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22860&id=23273
REVISION
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in package.cpp:594
> Just curious: what does the modulo operator on a string?
It explicitly uses `QStringBuilder` for concatenation which `operator+` only
does if you define `QT_USE_QSTRINGBUILDER`
REPOSITORY
R290 KPackage
REV
graesslin added a comment.
There are a few unrelated changes, but otherwise looks good.
INLINE COMMENTS
> package.cpp:360
> //Nested loop, but in the medium case resolves to just one iteration
> -//qDebug() << "prefixes:" << prefixes.count() << prefixes;
> +// qDebug() << "prefix
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:cfcf8a61d552: [Dialog] Use KWindowSystem::isPlatformX11()
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9105?vs=23263&id=
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9105
To: broulik, #plasma, hein
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8047e86b298: Reduce the amount of spurious property
changes on ColorScope (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D891
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:2c513b931b43: Group some blocking dbus calls (authored by
apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9092?vs=23230&id=23267#toc
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UP
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:8336ad60d9a5: Properly do strings in the kpackage
framework (authored by apol).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9104?vs=23262&id=23266
REVISION DET
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:041a4eba9430: Migrate powerdevil keyboard shortcuts
(authored by davidedmundson).
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9053?vs=23139&id=23265
REVISION
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
strings
REVISION DETAIL
https://phabricator.kde.org/D9104
To: apol, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Rather than doing a string comparison and doing it every time
TEST PLAN
OSD is still
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of using implicit casts, use the ones we need as suggested for KF5.
TEST PLAN
test
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:27fc3329a862: Don't try to generate metadata.json if
there's no metadata.desktop (authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9073?vs=23182&id=23261#toc
REPOSITORY
R290
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma, davidedmundson
Cc: ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel, #pl
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9066c232b403: [Icon Item] Emit validChanged only if it
actually changed (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D910
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9102
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9102
AFFECTE
dfaure edited the test plan for this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel, #plasma,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts
47 matches
Mail list logo
