[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||bugs5.kde@sjau.ch --- Comment #4 from Chri

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > On the other hand, calling setBold(true) on a font called "HandwriteCursive" _should_ select "HandwriteBoldCursive", even if the styleName was intended to enforce a specific face. If Qt cannot fix this issue, then we have to clear the styleName() at least for those f

D8856: Add support for new IdleInhibition protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ff2e8834694a: Add support for new IdleInhibition protocol (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

cfeck added a comment. The patch also addresses the bug only for default fonts, but not per-application fonts that write their settings to the appnamerc file. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #framewor

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

fvogt added a comment. In https://phabricator.kde.org/D9070#173835, @rjvbb wrote: > > IMO that's a feature though and is the expected behaviour. For instance, if we change the default window title to be bold, users with "windowTitle=Comic Sans" will also have a bold title. > > So h

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

cfeck added a reviewer: cfeck. cfeck added a comment. The config would work with removed styleName() for the cases where the weight() and style() attributes are sufficient. The intention from Qt's side was to uniquely identify fonts that cannot be selected by those two attributes. Imagine a

D8673: Sanitize signal handling in ksmserver

graesslin added inline comments. INLINE COMMENTS > server.cpp:615 > +QSocketNotifier* n = new QSocketNotifier(sockets[1], > QSocketNotifier::Read, this); > +qApp->connect(n, SIGNAL(activated(int)), SLOT(quit())); > + why the old connect syntax? REPOSITORY R120 Plasma Workspace REVIS

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. > IMO that's a feature though and is the expected behaviour. For instance, if we change the default window title to be bold, users with "windowTitle=Comic Sans" will also have a bold title. So how would you "change the default window title to be bold" and more i

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

anthonyfieroni added reviewers: Frameworks, davidedmundson, graesslin. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

fvogt added a comment. Oh, now I understand: It fixes the issue that the styleName was prefilled with the stylename of the default font and fromString might not reset it. IMO that's a feature though and is the expected behaviour. For instance, if we change the default window title to be bol

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. It depends a little bit what kind of call you make. But yes, certain "conflicting" attributes can no longer be set. A particular example reported by many is setting bold. If you do `setStyleName("Regular")` on a Qfont, `setBold(true)` will no longer have the intended e

D9073: Don't try to generate metadata.json if there's no metadata.desktop

apol created this revision. apol added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In fact, if metadata.json is provided directly, that's all we need. REPOSITORY R290 KPacka

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

fvogt added a comment. So after calling setStyleName on a QFont, it's "tainted" and subsequent calls won't have the same effect? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb Cc: fvogt, plasma-devel, ZrenBot, progwo

D9072: make ksshaskpass work with git-lfs

kossebau resigned from this revision. kossebau added a comment. no clue about these ksshaskpass internals, sorry REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D8816: Show root items in kicker menu

ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9072: make ksshaskpass work with git-lfs

mkoller created this revision. mkoller added reviewers: kossebau, cfeck, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On our git-lfs setup, I could not authenticate to the server due to 2 problems with ksshas

D9045: Better UI for the "Create a new vault" button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK, if it's just me, then +1. I'll have to look into what's up with my Neon dev VM. REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL https://phabricator.kde.org/D9045 T

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fa3a3899258b: [AppletInterface] Emit change signals for configurationRequired and -Reason (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabri

D9045: Better UI for the "Create a new vault" button

mart added a comment. code change looks fine, and no, shouldn't do that layouting bug, (nor i can reproduce with long text inside plasma buttons) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D9045 To: ivan, #plasma, cryptodude, ngraham Cc: mart, plasma-devel,

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9066 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Applying the default, hardwired QFont::styleName to one of the standard fonts which then gets changed to a user-selected font can break expectat

D8816: Show root items in kicker menu

lopatin added a comment. Before: F5519898: Выделение_073.png After: F5519897: Выделение_072.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8816 To: lopatin, #plasma Cc: mart,

D9068: Use setSize() instead of setProperty width and height

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b6b81c67b310: Use setSize() instead of setProperty width and height (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9068?vs

D9068: Use setSize() instead of setProperty width and height

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm sure we'd done this already... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9068 To: broulik, #plasma, davidedmundson Cc: davidedmu

D9068: Use setSize() instead of setProperty width and height

broulik updated this revision to Diff 23173. broulik added a comment. - Restore accidentally removed comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9068?vs=23171&id=23173 REVISION DETAIL https://phabricator.kde.org/D9068 AFFECTED FILES

D9068: Use setSize() instead of setProperty width and height

broulik added a comment. > I'm sure we'd done this already... I replaced all method calls to `setWidth()` and `setHeight()` but not instances where we went through `setProperty` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9068 To: broulik, #plasma,

D9068: Use setSize() instead of setProperty width and height

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We know we have a `QQuickItem` so we can just use its methods directly and then also u

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN I now can react on that from the containment and show/hide a configure button REPOSITORY R2

D8924: Move the KDE Polkit-Agent into ksmserver

davidedmundson abandoned this revision. davidedmundson added a comment. Somehow this went from "lets add a thing to ksmserver" to "lets split ksmserver" Abandoning for now. Will return with something more extreme. (maybe for 5.13 at this point) REPOSITORY R120 Plasma Workspace REVISI

D9065: [Task Manager] Support places categories

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9065 To: broulik, #plasma, hein, #vdg, renatoo Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9065: [Task Manager] Support places categories

broulik created this revision. broulik added reviewers: Plasma, hein, VDG, renatoo. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds submenus for subsequent categories in places model. Now that baloo search and o

D8444: Define default Action when we plug unknown monitor

davidedmundson added a comment. I left a comment a month ago. It has not been addressed. > there's one part that's going to appear very confusing. > I have my (small) laptop. Lets say I want any new (big) screen to appear on the left. So I save "Extend to left". > So I'd expe

D8444: Define default Action when we plug unknown monitor

mlaurent added a comment. Ping ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

kdesrc-build setup for building qt5 before plasma

Hi, using kdesrc-build , I dont manage to compile qt before kde5 I setted up qtdir in global conf and repository kde:qt in module qt5, but it does not help Regards S.Ancelot

D8917: Reduce the amount of spurious property changes on ColorScope

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Concept is good. INLINE COMMENTS > colorscope.cpp:127 > } > +m_lastGroup = m_group; > return m_group; It's weird to be caching in a public getter.

D8673: Sanitize signal handling in ksmserver

davidedmundson added a comment. > It would certainly be cleaner to close them in the destructor. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8673 To: jpalecek, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham

D8856: Add support for new IdleInhibition protocol

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > idle_inhibition.cpp:42 > + > +void IdleInhibition::registerShellClient(ShellClient *c