D8993: Properly use QCLP to get the theme name

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Much neater REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8993 To: apol, #plasma, davidedmundson Cc: davidedmundson, pl

D8993: Properly use QCLP to get the theme name

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of guessing it will be the first argument, which leads to very weird behavior. TEST PLAN Checked the k

D8986: an early prototype of a FormLayout

davidedmundson added a comment. What's with this and https://phabricator.kde.org/D8641? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8986 To: mart Cc: davidedmundson, plasma-devel, apol, mart, hein

D8982: Qml controls for kcm creation

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I like the GridView Note that we'll want to use that from the WallpaperDialog in Plasma, which isn't a KCM. I don't think it will be a problem though ? We

D8641: FormLayout

mart reopened this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8641 To: mart, #plasma, #kirigami, hein Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, he

D8982: Qml controls for kcm creation

mart updated this revision to Diff 22897. mart added a comment. - use the actual scrollbar width - more sophisticated implicit size for kcms - size hints for the simple kcm REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22885&id=22897 BRAN

D8916: QML port of fonts kcm

mart updated this revision to Diff 22899. mart added a comment. - reparent the font dialog REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8916?vs=22888&id=22899 BRANCH kcm-redesign/fonts REVISION DETAIL https://phabricator.kde.org/D8916 AFFECT

D8987: reparent the font dialog

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH kcm-redesign/fonts REVISION DETAIL https://phabricator.kde.org/D8987 AFFECTED FILES kcms/fonts/package/contents/ui/m

D8986: an early prototype of a FormLayout

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Form->FormData add gallery page add files to qrc make FormLayout a template use Headings for all the titles remove some

D8986: an early prototype of a FormLayout

mart updated this revision to Diff 22896. mart added a comment. mmediately relayout oncompleted REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8986?vs=22895&id=22896 BRANCH mart/formlayout REVISION DETAIL https://phabricator.kde.org/D8986 AFFECTED F

D8641: FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R169:90b11b50a68b: adress comments (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8641?vs=22468&id=22894#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabr

D8919: Add explicit AppMenu protocol

davidedmundson updated this revision to Diff 22890. davidedmundson marked 8 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Docs++ REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricat

D8916: QML port of fonts kcm

mart updated this revision to Diff 22888. mart added a comment. - port to new kcmcontrols REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8916?vs=22687&id=22888 BRANCH kcm-redesign/fonts REVISION DETAIL https://phabricator.kde.org/D8916 AFFECTE

D8850: Support drag and drop between shared folder view containments

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. thanks for the clarification BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezha

D8982: Qml controls for kcm creation

mart added inline comments. INLINE COMMENTS > hein wrote in GridDelegate.qml:130 > Do these numbers align with anything? Then a comment pointing at where else > we use them would be good. > > Or maybe use multiples of long/short duration? Or makes no sense? > > Same question about the other si

D8598: FolderView: position files at drop event target position

amantia accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH wip/lim-2 REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D7246: Tooltips

McPain updated this revision to Diff 22886. REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=22872&id=22886 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decorationbutton

D8598: FolderView: position files at drop event target position

mwolff updated this revision to Diff 22887. mwolff edited the summary of this revision. mwolff added a comment. remove TODOs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8598?vs=22715&id=22887 BRANCH wip/lim-2 REVISION DETAIL https://phabrica

D8982: Qml controls for kcm creation

hein added inline comments. INLINE COMMENTS > GridDelegate.qml:130 > +enabled: modelData.enabled > +Controls.ToolTip.delay: 1000 > +Controls.ToolTip.timeout: 5000 Do these numbers align with anything? Then a comm

D8982: Qml controls for kcm creation

mart updated this revision to Diff 22885. mart added a comment. - include SimpleKCM REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22883&id=22885 BRANCH phab/kcmodules REVISION DETAIL https://phabricator.kde.org/D8982 AFFECTED FILES sr

D8982: Qml controls for kcm creation

mart added a reviewer: hein. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8982 To: mart, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8692: QML mouse cursor KCM and components

mart updated this revision to Diff 22884. mart added a comment. - port to frameworks-kcmcontrols REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8692?vs=22829&id=22884 BRANCH kcm-redesign/cursorTheme REVISION DETAIL https://phabricator.kde.org/D

D8982: Qml controls for kcm creation

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the base C++ class for qml-based kcms is already there, KQuickAddons::ConfigModule, so this

D6163: [Icon Applet] Get favicon for website shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d821bffe1948: [Icon Applet] Get favicon for website shortcuts (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6163?vs=15309&id=22879

D8965: [PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R242:facaaf93d016: [PlasmaComponents Menu] Set WA_TranslucentBackground on the underlying QMenu (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabr

D8963: [Containment Interface] Set WA_TranslucentBackground before accessing winId()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f395097fe90b: [Containment Interface] Set WA_TranslucentBackground before accessing winId() (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phab

D8961: [Folder View] Accept mouse events if we handled them

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0d3f000f5bfe: [Folder View] Accept mouse events if we handled them (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8961?vs=22804&id=228

D7246: Tooltips

McPain updated this revision to Diff 22872. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=17995&id=22872 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decorationbutton.cpp src/decorationbutton.h To: McPain, #b

D7246: Tooltips

McPain retitled this revision from "Tooltips in Breeze theme" to "Tooltips". McPain changed the repository for this revision from R31 Breeze to R129 Window Decoration Library. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #p

D8850: Support drag and drop between shared folder view containments

hein added a comment. lgtm, but Phab says "You can not accept this revision because you have already accepted it." REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D8850: Support drag and drop between shared folder view containments

hein accepted this revision. REVISION DETAIL https://phabricator.kde.org/D8850 To: amantia, mwolff, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8961: [Folder View] Accept mouse events if we handled them

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8961 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8493: Make Folder View screen aware

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff Cc: anthonyfieroni, ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:30-39 > +function applyBusyCursorCurrentIndex() { > +if (kcm.busyCursorCurrentIndex == 0) { > +busyCursorDisabled.checked = true; > +} else if (kcm.busyCursorCurrentIndex == 1) { > +busyCu

D8692: QML mouse cursor KCM and components

hein added a comment. Related to the above: We also have various cases where applications bring up KCMs via kcmshell, e.g. KIO's Web Shortcuts KCM. That means also at runtime none of this can depend on plasma-desktop in any way. KCMs need to work outside of Plasma with a sane dep tree. Styli

D8692: QML mouse cursor KCM and components

hein added a comment. I don't think we can put the components into plasma-desktop, especially SimpleKCM if you really intend it to be used by all KCMs as root item. That would make any KCM requiring something like this depend on plasma-desktop. We have many KCMs in frameworks (e.g. KIO and S

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. > Given you're now familiar with this code, can you look through: Done. Two reassigned/retitled, one closed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, b