D8787: Fix PWD dialog

ngraham added a comment. @ivan, what do you think? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. @apol got a chance to test it? REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma Cc: apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Us https://phabricator.kde.org/tag/vdg/ folks did a bunch of design work today and all agreed on the following: F5501647: Option 10.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 T

D7543: [autotests] Support new way to run the tests without need to install

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1c61e61119f3: [autotests] Support new way to run the tests without need to install (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7543?vs=18794&id=22704#toc REPOSITORY

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f8be3f746ba9: [effects] Delay creation of EffectFrames in WindowGeometryEffect (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8821?vs=22369&id

D8776: [autotests] Add tests for DRM platform plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R108:d4ba05a22f86: [autotests] Add tests for DRM platform plugin (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8776?vs=22236&id=22700 REVISION DE

D8916: QML port of fonts kcm

ngraham added a comment. Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string that doesn't have any meaning to most users)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916

D8916: QML port of fonts kcm

mart added a comment. F5501237: Spectacle.n25430.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916 To: mart, #plasma, #vdg Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D8924: Move the KDE Polkit-Agent into ksmserver

graesslin added a comment. This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

abetts added a comment. **These are the good examples of what I think it should be:** TITLE [ ] Verb/action explanation TITLE [ ] verb/explanation **IF** [ ] verb/explanation **But never** Verb/Explanation [X ] Verb/Explanation [X ] verb/explanation

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

broulik added a comment. In https://phabricator.kde.org/D8911#170262, @hein wrote: > Updated screenshot: > > F5500694: Screenshot_20171121_174245.png According to KDE HIG a REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. I'm sorry @hein. I understand that this is pretty frustrating. Sometimes there's no substitute for seeing the actual implementation, I guess! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmu

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. The above exchange is seriously upsetting and frustrating to me. I implemented the VDG mockup, and now there's discussion about the design in my code review. Please get your act together and make sure the mockups are ready for implementing so the review process of code

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Also as discussed in the VDG room this morning, there's the open question of whether we actually need a launch feedback KCM or whether these settings should be in the Task Manager's own settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator

D8916: QML port of fonts kcm

ngraham added a comment. Needs more screenshots! :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916 To: mart, #plasma, #vdg Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. 1. I think the labels with controls next to them need colons. It looks weird otherwise. 2. We should vertically align the labels and their controls, just like @mmustac showed. That looks radically better. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://

D8436: use a single QML engine

This revision was automatically updated to reflect the committed changes. Closed by commit R296:fcecbc5c67f7: use a single QML engine (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21224&id=22693 REVISION DETAIL https://phabr

D8436: use a single QML engine

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH arcpatch-D8436 REVISION DETAIL https://phabricator.kde.org/D8436 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,

D8924: Move the KDE Polkit-Agent into ksmserver

apol added a comment. +1 for having it all in once place. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8924 To: davidedmundson, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8796: Support dynamic output enabling/disabling from KScreen

This revision was automatically updated to reflect the committed changes. Closed by commit R108:01c1870e9dde: Support dynamic output enabling/disabling from KScreen (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8796?vs=22629&id=2269

D8006: Add edit button to desktop theme

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c1910621cbc8: Add edit button to desktop theme (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8006?vs=22467&id=22689 REVISION

D8924: Move the KDE Polkit-Agent into ksmserver

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The rationale is two-fold: 1. It fixes a security issue. Right now, a rogue app can k

D8916: QML port of fonts kcm

mart added inline comments. INLINE COMMENTS > hein wrote in main.qml:175 > This and similar bindings will break when the user changes the spinbox value, > so after a manual adjustment e.g. defaults() won't work any longer. It needs > a seperate Connections à la https://phabricator.kde.org/D8911

D8916: QML port of fonts kcm

mart edited the summary of this revision. mart added a task: T7244: Fonts (somewhere in branch). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916 To: mart, #plasma, #vdg Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D8916: QML port of fonts kcm

mart updated this revision to Diff 22687. mart added a comment. - needssave only when settings actually changed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8916?vs=22663&id=22687 BRANCH kcm-redesign/fonts REVISION DETAIL https://phabricator.

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

mmustac added a comment. I don't know if I am allowed to write here, so sorry if not ... I just wanted to share my point of view (daily user). While the first screens look good for me, the second one here seems to be very restless and so I wondered if I should share what I would like to se

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22682. amantia added a comment. - Improve path detection as suggested by Milian - fix d&d for multiple items. There is only one issue, but I think it is acceptable this way: when moving two or more items that are not near each other to a new screen,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. In https://phabricator.kde.org/D8911#170032, @ngraham wrote: > Can you add "Fixes https://phabricator.kde.org/T7284"; so this it will close that Maniphest task once this goes in? Will do when pushing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D8916: QML port of fonts kcm

hein added inline comments. INLINE COMMENTS > fonts.cpp:570 > +emit smallFontChanged(); > +setNeedsSave(true); > +} Instead of always setting this to true in a prop setter, you need to implement a method that checks whether the new value is actually different from the stored configurat

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Updated screenshot: F5500694: Screenshot_20171121_174245.png I have a question: As per the mockup, I have no colons after the labels. I'm not sure I like that. Thoughts? @abetts, @ngraham? REPOSITORY R119 Plasma Desktop

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22681. hein marked 3 inline comments as done. hein added a comment. Address all review comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22634&id=22681 BRANCH kcm-redesign/launchfeedback REVISION

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein marked 3 inline comments as done. hein added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:69 > "Task Manager notification: [checkbox] Enable Task Manager notification" a > bit redundant and overly wordy. How about the following? > > "Task Manager notification: [checkbox]" >