D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Martin Flöser
graesslin updated this revision to Diff 22208. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Update the eglsurface in AbstractEglBackend if it changed REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8752?vs=22200

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Martin Flöser
graesslin added a comment. Ok, I figured out why the context is not current any more. We seem to get a mode change request from KScreen, which results in the DRMBackend updating a screen, the EGLBackend recreates the EGLSurface but didn't pass it to the parent class which tried to make a con

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Martin Flöser
graesslin added a comment. In combination that looks like kscreen sends a request to KWin which is stupid. Resulting in KWin losing the OpenGL context and then epoxy crashing. So we have two problems here: one being the incorrect request from KScreen, the other the fact that KWin ends up wit

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Fabian Vogt
fvogt added a comment. I found a workaround for the `no GLX or EGL context` crash: `rm /usr/lib64/qt5/plugins/kf5/kded/kscreen.so` + this patch results in a working wayland session in QEMU again. REPOSITORY R108 KWin BRANCH drm-property-safety REVISION DETAIL https://phabricator.kde.

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Fabian Vogt
fvogt added a comment. Ok, now both AMS and no-AMS cases result in the same crash. libepoxy terminates kwin_wayland due to `Couldn't find current GLX or EGL context`: #0 0x74ee3260 in errx () from /lib64/libc.so.6 #1 0x70c32c8c in ?? () from /usr/lib64/libepoxy.s

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Martin Flöser
graesslin updated this revision to Diff 22200. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fix stupid mistake, now starting should work again REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8752?vs=22186&id=222

D8764: Remove unnecessary QString::arg call

2017-11-11 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R108:73f5b09e3bbe: Remove unnecessary QString::arg call (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8764?vs=22198&id=22199 REVISION DETAIL https:

D8764: Remove unnecessary QString::arg call

2017-11-11 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH argfix REVISION DETAIL https://phabricator.kde.org/D8764 To: fvogt, #plasma, graesslin, davidedmundson Cc: kwin, plasma-devel, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8764: Remove unnecessary QString::arg call

2017-11-11 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. REVISION SUMMARY Fixes 'QString::arg: Argument missing: "-\n" , 0' TEST PLAN Didn't test this at all. REPOSITORY

Re: Regarding the outputdevice Wayland protocol

2017-11-11 Thread Drew DeVault
Thanks for the info, guys! My main use-case for this protocol is to be able to share an arandr-like tool between KDE and any compositor using wlroots (Sway, way-cooler, waymonad, etc). Did you guys write a screen configuration tool that leverages this protocol? Can it be easily detached from the

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Fabian Vogt
fvogt added a comment. Not quite sure whether it's related to this change, but I tried to debug the failure to init the primary plane and found this: kwin_wayland_drm: Using Atomic Mode Setting. kwin_wayland_drm: Number of planes: 2 kwin_wayland_drm: Atomic init for plane: 26

D8759: Implement SH_Widget_Animation_Duration style hint

2017-11-11 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 22193. elvisangelaccio added a comment. - Don't use QT_VERSION_CHECK since it's not used anywhere in breeze REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8759?vs=22192&id=22193 BRANCH master REVISION DETAIL

D8759: Implement SH_Widget_Animation_Duration style hint

2017-11-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qt 5.10 deprecates the SH_Widget_Animate style hint in favor of a new SH_Widget_An

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. Works. Instead of crashing I now get: kwin_wayland_drm: Failed to initialize primary plane. FATAL ERROR: backend failed to initialize, exiting now BTW: There's a typo in the title. REPOSITORY R108 KWin BRANCH drm-propert

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Martin Flöser
graesslin updated this revision to Diff 22186. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Prevent the new reported crash REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8752?vs=22158&id=22186 BRANCH drm-pro

D8758: Support modifier+mouse button on window decoration

2017-11-11 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma, broulik. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY On X11 modifier+mouse button on the window decoration triggers the "special" handling

D8752: [platforms/drm] At safety checks for the properties

2017-11-11 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. I tried this patch and kwin still crashes in QEMU, but at a different place now at least: #0 KWin::DrmOutput::pixelSize (this=0x0) at /usr/src/debug/kwin-5.11.90git.20171108T174438~9d