ngraham edited the test plan for this revision.
ngraham added reviewers: KDE Applications, davidedmundson, broulik.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8659
To: ngraham, #kde_applications, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff,
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 384900
TEST PLAN
Tested in KDE Neon. Before:
After:
REPOSITORY
R124 System Settings
BRANCH
master
REVISION DETAIL
https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1be6aecf248f: Change "Open..." to "Add
Image..." in Wallpaper chooser (authored by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8658?vs=21882&i
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8658
To: ngraham, #plasma, broulik, davidedmundson
Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezh
ngraham edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8441
To: guoyunhe, ngraham
Cc: broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
ngraham retitled this revision from "Change "Open..." to "Add Image" in
Wallpaper chooser" to "Change "Open..." to "Add Image..." in Wallpaper chooser".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
ngraham marked an inline comment as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8658
To: ngraham, #plasma, broulik
Cc: aspotashev, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
ngraham updated this revision to Diff 21882.
ngraham added a comment.
Restore elipses since this opens a file chooser dialog; also add elipses to
the "Add Folder" button for the slideshow style
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8658?v
ngraham edited the test plan for this revision.
ngraham added reviewers: Plasma, broulik.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8658
To: ngraham, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, s
aspotashev added inline comments.
INLINE COMMENTS
> config.qml:392
> +iconName: "list-add"
> +text: i18nd("plasma_applet_org.kde.image","Add Image")
> onClicked: imageWallpaper.showFileDialog();
The ellipsis ("Add Image...") is mandatory because the button op
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Changes the button in the wallpaper chooser marked "Open..." to say "Add
Image". This matches the text style for the button in slideshow mode,
graesslin updated this revision to Diff 21872.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
enum and uint
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8652?vs=21869&id=21872
BRANCH
support
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in outputdevice_interface.cpp:470
> we have the initial send which is all fine
>
> Then you've got this dynamically add them.
> But at a protocol level we have no way to remove and replace.
> That's somewhat broken.
>
> Per
davidedmundson added inline comments.
INLINE COMMENTS
> outputdevice.xml:225
> +
> +
> +
enum="transform"
also uint
> outputdevice_interface.cpp:470
>
> +void OutputDeviceInterface::addSupportedTransformation(Transform
> transformation)
> +{
we have the initial send whic
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The server can announce all supported transformations on an Output
amantia added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in foldermodel.cpp:163-164
> When QObject dies it's disconnected to all signal/slots. In this case if you
> want to not notify FolderModel you can use
>
> m_screenMapper->disconnect(this);
Yes, I know, indeed this might be
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2e7da1046e1b: Added an extra fuzzytime setting - Hobbit
Time (authored by jayturner, committed by ngraham).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D774
ngraham edited the summary of this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7747
To: jayturner, ngraham
Cc: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot,
progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart
jayturner added a comment.
In https://phabricator.kde.org/D7747#164151, @ngraham wrote:
> @jayturner, what email address should I use for you when I land this?
jaynicholastur...@gmail.com
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7747
To: jay
graesslin updated this revision to Diff 21858.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Changes suggested by Kai
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8645?vs=21853&id=21858
BRANCH
drm-supported
graesslin marked 2 inline comments as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8645
To: graesslin, #kwin, #plasma, subdiff
Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
21 matches
Mail list logo
