This revision was automatically updated to reflect the committed changes.
Closed by commit R108:77b5c3caa953: [platforms/drm] Add support for rotation
property on the Plane (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8582?vs=21667&id=2
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in drm_output.cpp:918
> we need to communicate this reset back to waylandOutput/waylandOutputDevice
Yes and for that there is a TODO a few lines below. But it doesn't make any
sense to implement it before https://phabricato
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in drm_output.cpp:109
> > for all variants of scaled, rotated and differently positioned outputs.
>
> "by all variants of rotated" do you mean just this one?
I meant, that I rotated the screen by 180 degree, scaled it, repo
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
drm-plane-rotate
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, kwin, bw
davidedmundson added inline comments.
INLINE COMMENTS
> drm_output.cpp:918
> +setGlobalPos(m_lastWorkingState.globalPos);
> +if (m_primaryPlane) {
> +
> m_primaryPlane->setTransformation(m_lastWorkingState.planeTransformations);
we need to communicate this
mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> foldermodel.cpp:535
> +m_screenMapper->addScreen(screen);
> +invalidateFilter();
> +}
this should not be required, since `addScreen` calls
davidedmundson added inline comments.
INLINE COMMENTS
> drm_output.cpp:109
> +QMatrix4x4 matrix;
> +if (m_orientation == Qt::InvertedLandscapeOrientation) {
> +matrix.translate(pixelSize().width() /2, pixelSize().height() / 2);
> for all variants of scaled, rotated and differentl
graesslin added a subscriber: davidedmundson.
graesslin added a comment.
@davidedmundson could you please verify that the scale is still applied
correctly. I set my displays to scaled and moved them around and verified with
mouse mark effect. Everything looks fine. But four eyes see more than
graesslin added a dependent revision: D8627: [platforms/drm] Properly adjust
cursor position on a rotated output.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff
Cc: ngraham, davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, pr
graesslin added dependencies: D8602: [platforms/drm] Restore previous mode if
an atomic test fails, D8582: [platforms/drm] Add support for rotation property
on the Plane.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8627
To: graesslin, #kwin, #plasma
Cc: plasma-devel,
graesslin added a dependent revision: D8627: [platforms/drm] Properly adjust
cursor position on a rotated output.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8602
To: graesslin, #kwin, #plasma, subdiff
Cc: ngraham, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliez
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This change refactors the way how the cursor position on a screen is
calculated. It is changed
dvogel created this revision.
dvogel added reviewers: broulik, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Reworked & simplified based on feedback from DDCUtil author.
Fixed CMakeList to add definitio
ngraham added a comment.
I think the question we need to ask ourselves is whether the ability to
create .desktop shortcuts by dragging from the task manager is useful to
enough people to outweigh the confusion and frustration to other people caused
by unwanted drags.
As a compromise, m
emateli added a comment.
> To be honest - dropping the patch.
I feel as that's the easy part.
> Sure. The URL to the .desktop file is the exchange-ready representation for
an app, which the task item is a delegate for. I don't see a good reason not to
be able to drag one, considerin
apol added inline comments.
INLINE COMMENTS
> kcm.cpp:69
> +
> +m_haveThemeExplorerInstalled =
> KService::serviceByDesktopName(QStringLiteral("org.kde.plasma.themeexplorer"));
> }
Wouldn't it be better to just do
`QStandardPaths::findExecutable("plasmathemeexplorer")`? This way we don't
mwolff retitled this revision from "WIP: position files at drop target position
in folder" to "FolderView: position files at drop event target position".
mwolff edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff,
mwolff updated this revision to Diff 21775.
mwolff added a comment.
use copyjob signals to map the target urls, not the source urls, which
resolves a lot of the brittleness of my previous approach. overall, this
works quite nicely, imo and is already in an acceptable state (to me).
wha
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:033afd2930d5: [System Tray] Sort plasmoids in "Extra
Items" by name (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8615?vs=21765&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0eb06ad874ae: [System Tray] Sort Entries by name
(authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8616?vs=21772&id=21773
REVISION DET
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8616
To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jens
broulik updated this revision to Diff 21772.
broulik added a comment.
- Use localeCompare, also fixes "vlc" showing up last just because it starts
lowercase
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8616?vs=21767&id=21772
REVISION DETAIL
h
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c08d28a08c1d: [Folder View] Emit dataChanged for
CheckStateRole only (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8618?vs=21770&id=2
abetts added a comment.
Well, looks like there are no objections... hehe
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8006
To: davidedmundson, #plasma
Cc: abetts, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, sebas, ap
broulik updated this revision to Diff 21770.
broulik edited the test plan for this revision.
broulik added a comment.
- Do the same for mime types model
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8618?vs=21769&id=21770
REVISION DETAIL
https://
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8618
To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We only change that role in setCheckedPlugins
TEST PLAN
Opened preview settings dialog, everything wa
davidedmundson added a comment.
There is a bug that I know of in < 5.9.2 if you have a crash after I want to
know about it.
INLINE COMMENTS
> ConfigEntries.qml:95
> +list.sort(function(a, b) {
> +if (a.name < b.name) {
> +return -1;
return a .localeCompar
marten updated this revision to Diff 21768.
marten added a comment.
Fix name for view background colour
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8617?vs=21766&id=21768
REVISION DETAIL
https://phabricator.kde.org/D8617
AFFECTED FILES
conta
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8615
To: broulik, #plasma, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apo
marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is the small dialogue that is summoned by the "More Preview Options"
button on the "Icons" page. Previou
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Changing visibility still works. Assigning a shortcut still works.
However, something's quite funky in the dial
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 386445
TEST PLAN
The Extra Items are now sorted alphabetically. Order of applets in "Entries"
and in
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:727db59f21b0: Move power management checkbox to the top
(authored by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8607?vs=21736&id=21764
REVIS
mart accepted this revision.
mart added a comment.
yeah, go for it for now
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik, mck182, davidedmundson, mart
Cc: mart, jensreuterberg, davidedmundson,
ngraham added a comment.
That's fine. I was just aiming for a small improvement here and to get a bug
closed.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik, mck182, davidedmundson
Cc: mart, je
mart added a comment.
Let me explain the situation a bit: HIG for the systray content is in
progress (and no, it won't be a complete redesign, but just a formalization of
the best charateristic of the current plasmoids) so some modules *might* have
to be partly reorganized afterwards.
an i
davidedmundson added a comment.
Ping
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8006
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: mwolff, apol, mart, davidedmund
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5a892dc88e25: Kicker: Use QtLoggingRules (authored by
davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8611?vs=21743&id=21762#toc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f16eb3313438: QLatin1String-ify (authored by
davidedmundson).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8609?vs=21742&id=21761
REVISION DETAIL
https:
ervin added a comment.
Looks good to me too but want to give the plasma team the last say.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhauman
jensreuterberg added a comment.
Say FOR EXAMPLE (an example, not a clear suggestion or goal) - we could
design all popups to follow a simple layout like this https://imgur.com/a/xbGt1
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8607
To:
jensreuterberg added a comment.
To be quite honest I don't think there is a complete agreement on the layouts
of the systray dialogues, although one should be considered - but since systray
dialogues have a bit of a history and there are still plans going about another
systray dialogue layou
mwolff abandoned this revision.
mwolff added a comment.
oh of course, the dropJob is the sender, stupid me.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: hein, ngraham, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff,
broulik added a comment.
I usually just temporarily mess with the dataengine to pretend to have
brightness controls for testing :)
INLINE COMMENTS
> PopupDialog.qml:70
> +onEnabledChanged: powermanagementChanged(enabled)
> +KeyNavigation.tab: batteryList
> +
hein added a comment.
IRC talk for posterity:
[17:32] from the notes you sent mlaurent, and from what I remember
form our past discussion, it is not clear to me how you envisioned (or even
implemented) the mapping of drop action -> new file
[17:33] first of all, what happens when you
hein accepted this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8611
To: davidedmundson, #plasma, apol, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
hein added a comment.
> What would you propose?
To be honest - dropping the patch.
> But is the dragging around into external applications of .desktop files a
feature that we want?
Sure. The URL to the .desktop file is the exchange-ready representation for
an app, which the tas
hein added a comment.
It's not necessary to delete connections. When a QObject is destroyed this is
done already. Patch rejected sorry :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: hein, ngraham, broulik, anthonyfieroni, plas
amantia added a comment.
Sound hacky and dangerous for me due to the point you mentioned. I'm not sure
I have a better idea now .
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
52 matches
Mail list logo
