jgrulich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
386360_remove_dialog_buttons
REVISION DETAIL
https://phabricator.kde.org/D8562
To: ngraham, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, progwolff, les
Hey Matthias,
On Tue, Oct 31, 2017 at 02:56:20AM +0100, Matthias Klumpp wrote:
> Also, did you know that you get screen artifacts and "stripes" as soon
> as you run kwin_wayland as root and not as regular user? ;-)
No, as it is unsupported workflow.. don't expect fixes for that :-P
> Anyway, the
ngraham added a comment.
What's next for this?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7768
To: subdiff, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
ngraham added reviewers: Plasma, jgrulich.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D8562
To: ngraham, #plasma, jgrulich
Cc: plasma-devel, ZrenBot,
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 386360
Change the Close button to a Cancel button in the KCM's connection removal
dialog. Ideally I would use Remove/No, which is wh
Hello!
The past weekend I made Plasma Mobile work on our preliminary
"devboard" for the Purism Librem 5 phone (which at the moment is not
much more than a i.mx6 CPU with peripherals/a screen - it will be much
more exciting soon).
The system is running Debian Testing (Buster) with KDE libraries fo
dvogel updated this revision to Diff 21592.
dvogel added a comment.
Reworked for simplification.
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5381?vs=14856&id=21592
REVISION DETAIL
https://phabricator.kde.org/D5381
AFFECTED FILES
CMakeLists.txt
davidedmundson added a comment.
Wouldn't it be cleaner to put the quit in:
Resources::Private::~Private
and/or ResourceScoreMaintainer::Private::~Private
(also I have no idea what the Resource thread is for, literally the only
thing it does actually in the thread is sleep)
REPOSI
davidedmundson added a reviewer: ivan.
REPOSITORY
R161 KActivity Manager Service
REVISION DETAIL
https://phabricator.kde.org/D8561
To: anthonyfieroni, #plasma, davidedmundson, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
systemd makes coredumps in /var/lib/systemd/coredumps when
kactivitymanagerd_pl
https://bugs.kde.org/show_bug.cgi?id=367696
Nate Graham changed:
What|Removed |Added
CC||kain...@gmail.com,
|
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:208ad519efa8: DictEngine: set a scheme for the URLs,
otherwise webengine won't handle them (authored by dfaure).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:baf36bc421b8: Don't re-align outputs when QMLOutput
in clone mode moves (authored by dvratil).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8390?vs=21033&id=21576
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:1a9164cdc7d1: Keep the unified QMLOutput always in center
(authored by dvratil).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8391?vs=21034&id=21575
REVISION DET
mart added a comment.
so, may be worth to have in kirigami a component called like ItemScrollView
intended for this?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D8526
To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolf
xuetianweng added a comment.
@mart I understand what you want to say, but for this specific case:
https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037
rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done.
And thus ther
mart added a comment.
as long qt and gtk will scale the same factor on dpi change, it should be good
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D8481
To: dos, #breeze, #plasma
Cc: mart, elvisangelaccio, ngraham, apol, plasma-devel, ZrenBot, progwolff,
lesl
mart added a comment.
scrollbars are smaller by purpose now, so no, not a bug
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D8481
To: dos, #breeze, #plasma
Cc: mart, elvisangelaccio, ngraham, apol, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, je
mart added a comment.
hmm, i feel it would be more correct to connect to the procedure finished and
then quit the app?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8529
To: xuetianweng, apol, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8534
To: dfaure, #plasma, davidedmundson, broulik, mart
Cc: ngraham, plasma-devel, #plasma, ZrenBot, progwolff, le
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7e6721ece08a: Scaled decorations in QPainter mode
(authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8504?vs=21398&id=21567
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:7c602a831f5d: Use nullptr. Initialize pointer (authored
by mlaurent).
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8432?vs=21172&id=21566
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:357bb3ab75c9: It's autotests not tests (authored by
mlaurent).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8553?vs=21558&id=21565#toc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UP
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Please also merge into master.
REPOSITORY
R104 KScreen
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8390
To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, le
sebas added a comment.
Please also merge into master.
REPOSITORY
R104 KScreen
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8391
To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R104 KScreen
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8391
To: dvratil, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apo
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R110 KScreen Library
BRANCH
use_nullptr
REVISION DETAIL
https://phabricator.kde.org/D8432
To: mlaurent, davidedmundson, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter
Meeting notes, fun as always. Enjoy the read!
--
sebas
http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 4-9-2017
Present: fvogt, d_ed, romangg, Sho_, einar77_work, bshah, notmart, kbroulik,
sebas
fvogt:
- I'm not quite sure what to do with ivan's request on the simplefavoritesmodel
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
rename_as_autotest
REVISION DETAIL
https://phabricator.kde.org/D8553
To: mlaurent, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moham
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> geolocator.cpp:25
> +{
> +m_engine = dataEngine("geolocation");
> +
meh, I'd rather we didn't have to link the rather heavy Plasma from KDED.
I'm n
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8553
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
rename_as_autotest
REVISION DETAIL
https://phabricator.kde.org/D8553
AFFECTED FILES
contain
jayturner added a comment.
In https://phabricator.kde.org/D7747#161721, @broulik wrote:
> What is "Elevensens" (I mean, how would a translator translate this)?
Dict.cc says "Homo floresiensis" latin name for Hobbit, so perhaps we can
deduce something for that, just trying to be careful h
broulik added a comment.
What is "Elevensens" (I mean, how would a translator translate this)? Dict.cc
says "Homo floresiensis" latin name for Hobbit, so perhaps we can deduce
something for that, just trying to be careful here.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabr
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0adccf18e3d0: We use Q_DECL_OVERRIDE or override.
(authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8549?vs=21551&id=21553
REVISION DET
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a5e9be03fe6: Don't loop twice here (authored by
mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8515?vs=21422&id=21552
REVISION DETAIL
https://
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
dont_loop_twice
REVISION DETAIL
https://phabricator.kde.org/D8515
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
use_override
REVISION DETAIL
https://phabricator.kde.org/D8549
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seb
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
> use unique keyword override
=
TEST PLAN
compile
REPOSITORY
R119 Plasma Desktop
BRANCH
use_override
R
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8549
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent added a comment.
This one too ?:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8515
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bf0a2b81426e: Emit signal when we change PerStripe
(authored by mlaurent).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8516?vs=21421&id=21550#toc
REPOSITORY
R119 Plasma Desktop
CHANGES S
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:27fb7629ce1d: Test enable status change and perStripe
change (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8517?vs=21426&id=21549
R
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
One more newline after the emit line please, otherwise GTG.
REPOSITORY
R119 Plasma Desktop
BRANCH
fix_missing_emit_signal
REVISION DETAIL
https://phabricator.kde.org/D8516
To: mlaurent,
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
add_more_autotest
REVISION DETAIL
https://phabricator.kde.org/D8517
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts
jensreuterberg added a comment.
I would avoid the shadows personally - it would be better to focus on better
spacing between the two areas and a clearer font usage to define them. Like
Broulik mentions it was removed more or less by active choice
REPOSITORY
R31 Breeze
REVISION DETAIL
ht
mlaurent added a comment.
Ping ?:)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8516
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8517
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
hein updated this revision to Diff 21544.
hein added a comment.
Also handle empty roles.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8524?vs=21438&id=21544
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8524
AFFECTED FILES
l
hein added a comment.
In https://phabricator.kde.org/D8524#161438, @ivan wrote:
> Also, not sure adding a signal that has one user only to a shared library
is the best approach, especially since .h says this:
>
> 37 * @NOTE: This is a placeholder, to be moved into KActivities (whic
50 matches
Mail list logo