D8548: Align app icon with app name, not back button

2017-10-29 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384916 Align the app icon with the app's name, not the back button TEST PLAN Tested in KDE Neon: REPOSITORY R134 Discover Software

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Andres Betts
abetts added a comment. In https://phabricator.kde.org/D7957#161647, @ngraham wrote: > The shadow seems a bit gratuitous to me, but I have to say I do like the extra borders and the nice explicit separator between Panels. Maybe another idea, instead of shadows is changing the colo

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Nathaniel Graham
ngraham added a comment. The shadow seems a bit gratuitous to me, but I have to say I do like the extra borders and the nice explicit separator between Panels. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: abetts, broulik, emmanue

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Andres Betts
abetts added a comment. I would even go as far as doing this: F5457461: Shadows.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: abetts, broulik, emmanuelp, elvisangelaccio, nicolasfella

D7957: Turn on frames around dock widgets by default

2017-10-29 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Too hard, can't figure it out. Maybe I'll revisit this at another time. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, mark

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: abetts, januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensr

D7747: Added an extra fuzzytime setting - Hobbit Time

2017-10-29 Thread Nathaniel Graham
ngraham added a comment. Any remaining objections? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D7747 To: jayturner, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

2017-10-29 Thread Roman Gilg
subdiff added a comment. In https://phabricator.kde.org/D8460#160642, @xuetianweng wrote: > Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only > get a virtual cursor. Thus I just move the condition to check the name of qpa > platform for now. Can you

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: abetts, januz, progwolff, broulik, sebas, plasma-de

D8460: Refactor kcm_input to enable having multiple backends.

2017-10-29 Thread Roman Gilg
subdiff added inline comments. INLINE COMMENTS > x11mousebackend.cpp:26 > +#include > +#include > +#include This include is not needed. > x11mousebackend.cpp:42 > +static const char PROFILE_ADAPTIVE[] = I18N_NOOP("Adaptive"); > +static const char PROFILE_FLAT[] = I18N_NOOP("Flat"); > + Thes

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 21536. ngraham added a comment. Tweaked colors to conform to standard Breeze HIG colors (https://community.kde.org/KDE_Visual_Design_Group/HIG/Color) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7424?vs=21144&id=21536

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. Great idea @abetts. Looks like we can easily change from Charcoal Grey to Shade Black (for example) to avoid having to define new colors. I'll work on this a bit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Andres Betts
abetts added a comment. Do you know if your colors match any of these? Color HIG If it doesn't or one of those colors can't work for you, we would need to have a bigger discussion with the team about that since it would me

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-10-29 Thread Nathaniel Graham
ngraham added a comment. Friendly ping REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg Cc: januz, progwolff, broulik, sebas, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D8362: Added setting to toggle drawing of title bar separator

2017-10-29 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R31:0d291b3f09cb: Added setting to toggle drawing of title bar separator (authored by emateli, committed by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8362?v

D8362: Added setting to toggle drawing of title bar separator

2017-10-29 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8362#161409, @hpereiradacosta wrote: > In https://phabricator.kde.org/D8362#161324, @ngraham wrote: > > > I'm going to land this tomorrow if I don't hear anything else. > > > Would be nice to actually contact the maintainer

D8524: Add a signal notifying a change in the names of running activities.

2017-10-29 Thread Ivan Čukić
ivan added a comment. Also, not sure adding a signal that has one user only to a shared library is the best approach, especially since .h says this: 37 * @NOTE: This is a placeholder, to be moved into KActivities (which it 38 * wraps) or the Task Manager applet backend.

D8362: Added setting to toggle drawing of title bar separator

2017-10-29 Thread Jens Reuterberg
jensreuterberg added a comment. From the VDG's standpoint there is zero reason to block this - as Andy have mentioned above. As for adding options to breeze I didn't know we had anything against it. REPOSITORY R31 Breeze BRANCH titlebar-highlight REVISION DETAIL https://phabricator.k

D8469: Use XDG_DATA_HOME and security fix

2017-10-29 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit R845:07311c73b5dd: Use XDG_DATA_HOME and security fix (authored by cryptodude, committed by ivan). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8469?vs=21364&id=2

D8362: Added setting to toggle drawing of title bar separator

2017-10-29 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D8362#161324, @ngraham wrote: > I'm going to land this tomorrow if I don't hear anything else. Would be nice to actually contact the maintainer of the code (and make sure he is among the reviewers) before taking such

D8469: Use XDG_DATA_HOME and security fix

2017-10-29 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8469 To: cryptodude, ivan, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart