D8364: Drop the explicit fallback to XRender

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Does anything now use Options::setCompositingMode? BRANCH drop-fallback-to-xrender REVISION DETAIL https://phabricator.kde.org/D8364 To: graesslin, #kwin, #plasma, davi

D8363: Try all supported Compositor Types of the current Platform

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH try-all-platforms REVISION DETAIL https://phabricator.kde.org/D8363 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezh

D8362: Added setting to toggle drawing of title bar separator

emateli retitled this revision from "added setting to toggle drawing of title bar separator" to "Added setting to toggle drawing of title bar separator". emateli edited the summary of this revision. emateli added a subscriber: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

davidedmundson added a comment. Following this up. QQC2.Label gets colours from "PlasmaDesktopTheme.cpp" This does calling setTextColor when the palette changes. However always with the same value, as though the KColorScheme hasn't been updated yet REPOSITORY R124 System Setting

D8364: Drop the explicit fallback to XRender

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY With the new try of all compositor types supported there is an automatic fallback from OpenGL to X

D8364: Drop the explicit fallback to XRender

graesslin added a dependency: D8363: Try all supported Compositor Types of the current Platform. REVISION DETAIL https://phabricator.kde.org/D8364 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8363: Try all supported Compositor Types of the current Platform

graesslin added a dependent revision: D8364: Drop the explicit fallback to XRender. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8363 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, ab

D8363: Try all supported Compositor Types of the current Platform

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The Compositor now tries to create a Scene not just once but every type supported by the Platfo

D8362: added setting to toggle drawing of title bar separator

emateli edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8362: added setting to toggle drawing of title bar separator

emateli added a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8362: added setting to toggle drawing of title bar separator

emateli added a reviewer: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8362: added setting to toggle drawing of title bar separator

emateli created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Adds a new settings on Breeze theme which allows the user to turn off the title bar separator drawn TEST PLAN 1. Use default breeze theme

D8361: Add option to change Oxygen's windows decoration shadow intensity

rpelorosso retitled this revision from "Add option to change windows shadow intensity" to "Add option to change Oxygen's windows decoration shadow intensity". REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8361 To: rpelorosso Cc: plasma-devel, ZrenBot, progwolff,

D8361: Add option to change windows shadow intensity

rpelorosso edited the summary of this revision. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8361 To: rpelorosso Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8361: Add option to change windows shadow intensity

rpelorosso created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch solves the following problem: In order to obtain light shadows, the inner color should be changed to a light gray, resulting in

D8316: Add a pure virtual method to Platform to describe the supported compositors

This revision was automatically updated to reflect the committed changes. Closed by commit R108:09489a4c2b5b: Add a pure virtual method to Platform to describe the supported compositors (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8316?vs=20819&id=20961#toc REP

D8232: Add option to center shadow

ngraham added a comment. Sorry guys, didn't mean to offend. Though I currently favor the centered approach, I'm absolutely willing to be convinced out of it, if VDG can come up with a non-centered shadow that looks good and resolves the issues with insufficient depth and contrast on windows'

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#156982, @ngraham wrote: > More evidence for the superiority of the centered approach. :) Sorry to say, but this is a completely gratuitous, non constructive and demotivating comment nathaniel. Hugo REPOSIT

D8232: Add option to center shadow

rkflx added a comment. In https://phabricator.kde.org/D8232#156982, @ngraham wrote: > More evidence for the superiority of the centered approach. :) Let's not jump to conclusions here too fast :) We should evaluate both approaches in how they solve the problem at hand (if that's d

D8232: Add option to center shadow

ngraham added a comment. More evidence for the superiority of the centered approach. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davided

D8232: Add option to center shadow

rkflx added a comment. Thanks for summarizing the discussion and doing the prototyping, that's appreciated. Just noticed a point which has not been mentioned yet: There are also the shadows of the Plasma widgets to consider. Ironically, those are already centered

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

broulik abandoned this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8357 To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

davidedmundson added a comment. > The icons in the Frequently Used list have readable text with dark colorschemes now. What's the issue with dark themes. I have one. It seems fine. Do you mean runtime switching? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.k

D8358: Use QActions directly in menu

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8358 To: broulik, #plasma, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Change doesn't make sense. If there's a bug in the QQC2 dekstop style label, then there's a bug in QQC2 dekstop style label. Avoiding the problem doens't fi

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#156965, @hpereiradacosta wrote: > I think the consensus (from Telegram discussions) was that I would submit two review requests to superseed this one: > > - one where the whole of breeze is now centered (shadows for wind

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#156934, @mvourlakos wrote: > In https://phabricator.kde.org/D8232#155519, @alake wrote: > > > Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overla

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#155519, @alake wrote: > Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overlapping windows could be improved. The proposed compromise solution actually loo

D8324: Fix ActionItem Label width, minimumWidth=300, minimum scaled by DPI, mockup ListModel in comments

ngraham added a comment. @ivan, does this look good? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8324 To: Zren, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 383614] KCM opened from tray icon has wrong icon under Wayland

https://bugs.kde.org/show_bug.cgi?id=383614 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving th

D8358: Use QActions directly in menu

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of duplicating the name and icon work, just bind it to the QAction itself. Also respect visibil

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

broulik added a comment. Urgh, even says Kirigami.Label is deprecated. Meeh. So something is severly broken somewhere :( REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8357 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

broulik added a comment. I just updated my Kirigami to master and now the kirigami label is also dark erroneously o.O REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8357 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohame

D8357: [IntroIcon] Use Kirigami.Label instead of QQC2.Label

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes the label not picking up color scheme properly. TEST PLAN The icons in the Frequently Used list

D8276: [SideBar] enable LayoutMirroring for RTL

ttv20 added a comment. In https://phabricator.kde.org/D8276#156785, @progwolff wrote: > Is it just for me, or is the layout mirrored unconditionally now? > > F5436511: systemsettings_rtl.png My mistake Committed fix - https://commits.kd

D8338: Set transient parent for system tray menus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2ff7b3e22158: Set transient parent for system tray menus (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8338?vs=20888&id=2093

D8276: [SideBar] enable LayoutMirroring for RTL

progwolff added a comment. Is it just for me, or is the layout mirrored unconditionally now? F5436506: systemsettings_rtl.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8276 To: ttv20, broulik, davidedmundson C

D8277: Background color for sidebar headers

This revision was automatically updated to reflect the committed changes. Closed by commit R124:c47fa0c75736: Background color for sidebar headers (authored by progwolff). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20801&id=20934 REVISION

D8345: [QPA] Implement Screen on top of internal Screens API

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH qpa-screens REVISION DETAIL https://phabricator.kde.org/D8345 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardenin