graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8321
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-moham
Zren edited the summary of this revision.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8324
To: Zren, ivan
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
ngraham added a comment.
Thanks for the patch! Can you change the bugzilla link to "BUG: 385794"? That
special keyword makes the bug get marked as resolved once this goes in.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8324
To: Zren, ivan
Cc: ngraham, plasm
Zren created this revision.
Zren added a reviewer: ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
First I fixed the ActionItem label width exiting the button boundaries
mentioned in https://bugs.kde.org/show_bug.cg
januz added a comment.
Personally, I'm in the centered shadows camp. I have windows set up to have
no borders and they always seem to visually blend into each other in a similar
way to what @rkflx describes.
I don't understand the reasoning behind light coming from the top-left, it
seems
apol added a comment.
See https://phabricator.kde.org/D8214
Then https://bugs.kde.org/show_bug.cgi?id=385548
That said, I don't know if ShareOpenGLContext would be any worse.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8318
To: dfaure, #plasma, da
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
On Plasma is a rather pointless check as our QPT uses SNIs
so we end up
dfaure created this revision.
dfaure added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QMutex isn't the right tool for this:
- If tryLock succeeds, the code didn't unlock the mutex again,
broulik added a comment.
Can't we fix the root-cause you mentioned? I still have memories of Akonadi
runner trying to *initialize* Qt Web Engine and that blowing up miserably.
Alternatively, Zanshin could provide an out-of-process DBus runner.
REPOSITORY
R120 Plasma Workspace
REVISION
dfaure created this revision.
dfaure added reviewers: Plasma, davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
[this happens in the zanshin runner, due to libKF5AkonadiCalendar.so.5 linking
to lib
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
platform-supported-compositors
REVISION DETAIL
https://phabricator.kde.org/D8316
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwo
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
So far KWin does not know which Compositors the platform actually
supports. This results in KWi
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:c50470387510: Make Qt5::X11Extras really optional
(authored by kfunk).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8307?vs=20787&id=20804
REVISION DETAIL
http
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:c8dbb830aace: macOS: Don't create bundles for test
executables (authored by kfunk).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8308?vs=20788&id=20803
REVISION
kfunk added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:7
> Maybe we could assume tests are non_gui by default?
`ecm_add_test(...)` does that. `ecm_mark_as_test(...)` doesn't. Might make
sense to change that for `ecm_mark_as_test(...)`, indeed.
REPOSITORY
R871 DrKonqi
B
progwolff updated this revision to Diff 20801.
progwolff added a comment.
- also revert newline
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8277?vs=20799&id=20801
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8277
AFFECTED FIL
This revision was automatically updated to reflect the committed changes.
kfunk marked an inline comment as done.
Closed by commit R871:abb6999b736b: Modernize: Use nullptr where possible
(authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8309?vs=20789&id=20800#toc
REPOS
kfunk marked an inline comment as done.
kfunk added inline comments.
INLINE COMMENTS
> broulik wrote in backtracegenerator.cpp:69
> `Q_ASSERT(!m_proc && !m_temp)`?
> iirc Clang doesn't like comparisons to `nullptr` very much (at least in
> `QCOMPARE`) and I find it cleaner
That can't be problem
progwolff updated this revision to Diff 20799.
progwolff added a comment.
- revert changes to SubCategoryPage
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8277?vs=20688&id=20799
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8277
mart added inline comments.
INLINE COMMENTS
> apol wrote in main.qml:28
> Should be using `Units.gridUnit`, no?
this needs porting too, then good to go
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8286
To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel
mart added a comment.
ok for the top toolbar to be darker.
the headers in the listviews should stay like they are now tugh
INLINE COMMENTS
> SubCategoryPage.qml:77
> elide: Text.ElideRight
> visible: !backButton.visible
> }
it's still suppo
rjvbb added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:32
> Is this change needed?
I don't understand, since when has DrKonqi been split out of plasma-runtime?
Plasma-runtime had a different approach: search for X11Extras only when X11 was
found. I think that's the better
sitter accepted this revision.
sitter added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:32
> Is this change needed?
Don't think this makes a difference. From a cmake POV the new version is more
correct though as Qt5 was already found so only finding Qt5X11Extras on its own
rjvbb accepted this revision.
rjvbb added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:7
> Maybe we could assume tests are non_gui by default?
For Mac there is only a theoretical difference in fact; nongui builds are
non-bundled but you have to try really hard nowadays to fin
sitter accepted this revision.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8309
To: kfunk, sitter, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
sitter accepted this revision.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8308
To: kfunk, rjvbb, sitter, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:afe0a5c04116: Fix placement of KSplash (authored by
graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8268?vs=20657&id=20796#toc
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1b01f1b30094: Update pointer position whenever a window
gets (un)minimized (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8145?vs=20356&id=207
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ecd00a565a99: Don't position a Dialog if it's
of type OSD (authored by graesslin).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8304?vs=20769&i
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:32
>
> -find_package(Qt5 ${QT_MIN_VERSION} CONFIG COMPONENTS X11Extras)
> +find_package(Qt5X11Extras ${QT_MIN_VERSION} CONFIG)
>
Is this change needed?
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabrica
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:7
> target_link_libraries(backtraceparsertest_manual Qt5::Core KF5::I18n
> KF5::KIOWidgets drkonqi_backtrace_parser)
> ecm_mark_as_test(backtraceparsertest
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8307
To: kfunk, rjvbb, sitter, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> backtracegenerator.cpp:69
> //they should always be null before entering this function.
> -Q_ASSERT(m_proc == NULL && m_temp == NULL);
> +Q_ASSERT(m_proc
kfunk added a reviewer: sitter.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8307
To: kfunk, rjvbb, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk added a reviewer: sitter.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8309
To: kfunk, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk added a reviewer: sitter.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8308
To: kfunk, rjvbb, sitter
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8309
AFFECTED FILES
src/aboutbugreportingdialog.h
src/backtracegener
kfunk added a reviewer: rjvbb.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8307
To: kfunk, rjvbb
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk added a reviewer: rjvbb.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D8308
To: kfunk, rjvbb
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
kfunk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8308
AFFECTED FILES
CMakeLists.txt
src/tests/backtraceparsertest/CMa
kfunk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise may fail with:
CMake Warning at CMakeLists.txt:32 (find_package):
Found package configuration file:
/Users/kfunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1ded47814a61: Port KAccess away from kdelibs4support
(authored by apol).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8115?vs=20782&id=20783
REVISION DETA
apol updated this revision to Diff 20782.
apol added a comment.
Fix
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8115?vs=20557&id=20782
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8115
AFFECTED FILES
kaccess/CMakeLists.txt
On Fri, Oct 13, 2017 at 1:11 PM, David Edmundson
wrote:
>
>
> On Thu, Oct 12, 2017 at 12:13 PM, Marco Martin wrote:
>>
>> On Wed, Oct 11, 2017 at 5:20 PM, Martin Flöser wrote:
>> >> yep, i like it and i'll try!
>> >> some times tough some help is needed to even figure out where the
>> >> proble
janmulder added a comment.
No commit access for me. Not needed, as I do not expect a huge amount of work
on the repo. It is perfectly fine when mart commits it.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8291
To: janmulder, mart
Cc: davidedmundson, plasma-deve
graesslin added a comment.
@davidedmundson The CI image is updated, you can push this now.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8050
To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,
davidedmundson added a comment.
Do you have commit access?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8291
To: janmulder, mart
Cc: davidedmundson, plasma-devel, apol, mart, hein
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
thanks for spotting
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8291
To: janmulder, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
ksplash-fix-5.11
REVISION DETAIL
https://phabricator.kde.org/D8268
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezha
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
dialog-no-position-osd
REVISION DETAIL
https://phabricator.kde.org/D8304
To: graesslin, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot,
graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The OSDs are positioned by the Wayland compositor. This fixed the issue
found in
graesslin added a comment.
Addressed the other problem in https://phabricator.kde.org/D8304. As that is
only master I would retarget this change here for master as well instead of
5.11.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8268
To: graesslin, #kwin, #plasma
graesslin added a comment.
And yes, that's a bug in Plasma:
[1117495.024] -> org_kde_plasma_surface@210.set_position(0, 0)
[1117495.036] -> org_kde_kwin_slide_manager@105.unset(wl_surface@88)
[1117495.041] -> wl_surface@88.commit()
[1117495.051] -> org_kde_plasma_surface@
graesslin added a comment.
In https://phabricator.kde.org/D8268#154753, @graesslin wrote:
> This needs additional testing for "normal" OSD windows. I'm not sure
whether it affects them. It shouldn't or better said: if they are it's a bug
somewhere else.
So tried this again: it do
54 matches
Mail list logo
