D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-10-03 Thread Thorsten Bonhagen
thorstenb marked 8 inline comments as done. thorstenb added a comment. Hi, i've done a arc redo because of "arc patch" not working and web "diff update" also not working. https://phabricator.kde.org/D8134 is the updated patch with the requested coding style. Sorry for not using arc in

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-03 Thread Thorsten Bonhagen
thorstenb edited the summary of this revision. thorstenb added reviewers: Plasma, jgrulich. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8134 To: thorstenb, #plasma, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-03 Thread Thorsten Bonhagen
thorstenb retitled this revision from "fix Coding style" to "plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style". thorstenb edited the summary of this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricato

D8134: fix Coding style

2017-10-03 Thread Thorsten Bonhagen
thorstenb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D7795_1 REVISION DETAIL https://phabricator.kde.org/D8134 AFFECTED FILES vpn/opencon

D8131: Deprecate Kirigami.Label

2017-10-03 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QQC2 Styles style labels themselves, we don't to do this via a subclass. This i

D8129: Don't try to override label heights

2017-10-03 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY 1. If we want to look like QWidgets, which we do, we need things to match, this means labe

D7941: use Kirigami Theme for colors

2017-10-03 Thread Marco Martin
mart marked an inline comment as done. mart added a comment. In https://phabricator.kde.org/D7941#151979, @davidedmundson wrote: > Is 5.39 tagged already? should be tagged next saturday. the two issues are adressed in master. REPOSITORY R858 Qt Quick Controls 2: Desktop Sty

D8127: fix weather view mycroft intent format changes

2017-10-03 Thread Aditya Mehra
This revision was automatically updated to reflect the committed changes. Closed by commit R846:655aa21ef3df: fix weather view mycroft intent format changes (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8127?vs=20306&id=

D7998: Stop setting the QQC1 style in startkde

2017-10-03 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R120:335116210b7c: Stop setting the QQC1 style in startkde (authored by arojas). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7998?vs=19950&id=20314 REVISION

D8100: Workaround crash on lockscreen close

2017-10-03 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R133:b85d1a63fccb: Workaround crash on lockscreen close (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8100?vs=20227&id=20312#toc REPOSITORY R133 KScreenLocker CHAN

D8100: Workaround crash on lockscreen close

2017-10-03 Thread Martin Flöser
graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > greeterapp.cpp:127 > +//will be fixed when themes port to QQC2 > +for(auto view: m_views) { > +if (QQuickItem *focusItem = view->activeFocusItem())

D8127: fix weather view mycroft intent format changes

2017-10-03 Thread Aditya Mehra
Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes https://phabricator.kde.org/T7132 new intent discovery method fixes weather view in plasmoid REPOSITORY R

[Powerdevil] [Bug 340427] PowerDevil should only inhibit systemd on active sessions

2017-10-03 Thread Josef Kufner
https://bugs.kde.org/show_bug.cgi?id=340427 Josef Kufner changed: What|Removed |Added CC||j...@frozen-doe.net --- Comment #2 from Josef Ku

D7941: use Kirigami Theme for colors

2017-10-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R858:aa33639fcfd9: use Kirigami Theme for colors (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7941?vs=20296&id=20299 RE

D7941: use Kirigami Theme for colors

2017-10-03 Thread David Edmundson
davidedmundson added a comment. Is 5.39 tagged already? INLINE COMMENTS > plasmadesktoptheme.cpp:48 > +this, [this]() { > +if (m_parentItem && m_parentItem->window()) { > +connect(m_parentItem->window(), > &QWindow::activeChanged,

D7939: ColorSet concept in Theme

2017-10-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:5b08a7b6cd50: ColorSet concept in Theme (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7939?vs=20297&id=20298#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE ht

D7939: ColorSet concept in Theme

2017-10-03 Thread Marco Martin
mart updated this revision to Diff 20297. mart added a comment. - Merge branch 'master' into arcpatch-D7939 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7939?vs=20247&id=20297 BRANCH arcpatch-D7939 REVISION DETAIL https://phabricator.kde.org/D7939

D7941: use Kirigami Theme for colors

2017-10-03 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH mart/kirigamiintegration REVISION DETAIL https://phabricator.kde.org/D7941 To: mart, #plasma, #kirigami, hein Cc: davidedmundson, plasma-devel, ZrenBot,

D7939: ColorSet concept in Theme

2017-10-03 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/colorcontext REVISION DETAIL https://phabricator.kde.org/D7939 To: mart, #kirigami, hein Cc: plasma-devel, apol, davidedmundson, mart, hein

D7940: plugin loaded by kirigami to use KColorScheme and KIconLoader

2017-10-03 Thread Marco Martin
mart abandoned this revision. mart added a comment. all the code is in https://phabricator.kde.org/D7941 now REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7940 To: mart, #plasma, #kirigami, hein Cc: davidedmundson, plasma-devel, Zr

D7941: use Kirigami Theme for colors

2017-10-03 Thread Marco Martin
mart reopened this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D7941 To: mart, #plasma, #kirigami, hein Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein

D7941: use Kirigami Theme for colors

2017-10-03 Thread Marco Martin
mart updated this revision to Diff 20296. mart added a comment. - add the kirigami plasma desktop integration here REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7941?vs=20293&id=20296 BRANCH mart/kirigamiintegration REVISION

D7941: use Kirigami Theme for colors

2017-10-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R858:1190c5e0c9f2: use Kirigami Theme for colors (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7941?vs=19981&id=20293 RE

D7315: Don't duplicate UI option for automatic speed detection

2017-10-03 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R116:e0642ee0d8c0: Don't duplicate UI option for automatic speed detection (authored by davidedmundson). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.k

D7998: Stop setting the QQC1 style in startkde

2017-10-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7998 To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7998: Stop setting the QQC1 style in startkde

2017-10-03 Thread Antonio Rojas
arojas added a comment. Ping. Would be nice to get this in 5.11 to reduce environment noise. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7998 To: arojas, davidedmundson, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,