D8077: Fix org.kde.plasma.calendar with Qt 5.10

2017-10-01 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D8077#151362, @broulik wrote: > Meh. > > I suspect there are other modules affected as well? I'm not sure, I didn't test anything beyond the default plasma configuration. A quick scan with a script showed mostly false posi

D8077: Fix org.kde.plasma.calendar with Qt 5.10

2017-10-01 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f43c236e34e: Fix org.kde.plasma.calendar with Qt 5.10 (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8077?vs=20165&id=20213

D8077: Fix org.kde.plasma.calendar with Qt 5.10

2017-10-01 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Meh. I suspect there are other modules affected as well? REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8077 To: fvogt,

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:f988a5f6547b: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D80

D8095: Support updating deco for changes of borderless maximize windows config

2017-10-01 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far only updated the Clients, now also ShellClient. REPOSITORY R108 KWin BRANCH borderle

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works! REPOSITORY R108 KWin BRANCH reload-vds-on-x11 REVISION DETAIL https://phabricator.kde.org/D8086 To: graesslin, #kwin, #plasma, fvogt Cc: fvogt, plasma-devel, kwin, Zren

D8094: Port RuleBook::discardUsed from Client to AbstractClient

2017-10-01 Thread Martin Flöser
graesslin added a dependency: D8090: Move WindowRules from Client to AbstractClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8094 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, a

D8090: Move WindowRules from Client to AbstractClient

2017-10-01 Thread Martin Flöser
graesslin added a dependent revision: D8094: Port RuleBook::discardUsed from Client to AbstractClient. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8090 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D8094: Port RuleBook::discardUsed from Client to AbstractClient

2017-10-01 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Prepares the Rules update on reconfigure for Wayland windows. REPOSITORY R108 KWin BRANCH r

D8090: Move WindowRules from Client to AbstractClient

2017-10-01 Thread Martin Flöser
graesslin updated this revision to Diff 20204. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I noticed I hadn't removed the variable from Client... That turned into another round of refactoring and moving things from Client to AbstractClien

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D8086#151291, @graesslin wrote: > In https://phabricator.kde.org/D8086#151206, @fvogt wrote: > > > I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single v

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Martin Flöser
graesslin updated this revision to Diff 20199. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. New try: found some more code which syncs the rootinfo. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8086?vs=20184&i

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8086#151206, @fvogt wrote: > I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single virtual desktop now instead of two by default. How does openS

D8090: Move WindowRules from Client to AbstractClient

2017-10-01 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far window rule specific functionality was only implemented in Client and in ShellClient the

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Fabian Vogt
fvogt added a comment. I gave it a try, it's slightly better but not enough: The virtual desktop pager is not visible by default as there's only a single virtual desktop now instead of two by default. The single virtual desktop had a name now though and it was possible to edit the count of

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-10-01 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R572 releaseme REVISION DETAIL https://phabricator.kde.org/D7981 To: asturmlechner, #plasma, sitter, O2 releaseme Cc: palimaka, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7981: cmakeeditor.rb: kdoctools_install conditional on KF5DocTools_FOUND

2017-10-01 Thread Andreas Sturmlechner
asturmlechner added a comment. In https://phabricator.kde.org/D7981#149086, @sitter wrote: > Note that ki18n is also currently marked REQUIRED though. thanks, I'm not concerned about ki18n as I have not seen it being optional anywhere. REPOSITORY R572 releaseme BRANCH master

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Fabian Vogt
fvogt added a comment. I'll give it a try, currently building. For some reason it fails building for Leap 42.3 though, with undefined references such as: > /home/abuild/rpmbuild/BUILD/kwin-5.10.90git~20171001T152640~https://phabricator.kde.org/R108:252980390d1091ea57e430836708cb766f79aa6

D8086: Reload VirtualDesktop settings after passing RootInfo on VirtualDesktopManager

2017-10-01 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The load method and updateLayout ensure the virtual desktop information is synced to RootInfo a

D8082: Also send Wayland clients to a new desktop if their desktop was removed

2017-10-01 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0d96e60b79a7: Also send Wayland clients to a new desktop if their desktop was removed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8082?vs=2

D8082: Also send Wayland clients to a new desktop if their desktop was removed

2017-10-01 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH virtual-desktop-remove-send-client-5.11 REVISION DETAIL https://phabricator.kde.org/D8082 To: graesslin, #kwin, #plasma, broulik Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,

D8082: Also send Wayland clients to a new desktop if their desktop was removed

2017-10-01 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far the method only operated on X11 clients. So when the last desktop got removed Wayland cl