D7831: Use a different key for font DPI on X and Wayland

2017-09-14 Thread David Edmundson
davidedmundson added a comment. In https://phabricator.kde.org/D7831#145979, @hein wrote: > The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly?

D7831: Use a different key for font DPI on X and Wayland

2017-09-14 Thread Eike Hein
hein added a comment. The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org

D7831: Use a different key for font DPI on X and Wayland

2017-09-14 Thread David Edmundson
davidedmundson retitled this revision from "Use a different vallue for font DPI on X and Wayland" to "Use a different key for font DPI on X and Wayland". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7831 To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, p

D7831: Use a different vallue for font DPI on X and Wayland

2017-09-14 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Saved config under X opened file Saved config under wayland REPOSITORY R119 Plasma Desktop BRANCH randa/accessibility REVISION DETAI

D7830: Use a separate config value for Wayland font DPI

2017-09-14 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On X our font DPI is used in addition to the scaling. i.e I want scale 2 and font DPI at 192 (96*2) On Wayland it's the opposite.

D7825: Add DefaultEvent flag to fix notification for relogin/restart

2017-09-14 Thread Fabian Vogt
fvogt closed this revision. fvogt added a comment. Phab did not notice https://commits.kde.org/plasma-pk-updates/0ad7ca59867a25dcfc8fd705d2b3c88fa191800b REPOSITORY R623 Plasma PackageKit Updater REVISION DETAIL https://phabricator.kde.org/D7825 To: fvogt, #plasma, lukas, jgrulich, davi

D7825: Add DefaultEvent flag to fix notification for relogin/restart

2017-09-14 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R623 Plasma PackageKit Updater BRANCH notificationfix REVISION DETAIL https://phabricator.kde.org/D7825 To: fvogt, #plasma, lukas, jgrulich, davidedmundson Cc: plasma-devel, ZrenBot, progwol

D7825: Add DefaultEvent flag to fix notification for relogin/restart

2017-09-14 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This flag is necessary is no notifyrc for the given appName exists. Otherwise the notification is silently discarded. TEST PLAN Added call to onRestartRequired somewhere more easily reachable, wi

D7817: Remaining accessibility on Plasma PA

2017-09-14 Thread David Rosca
drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Please fix that whitespace changes. INLINE COMMENTS > ListItemBase.qml:50 > height: rowLayout.height > - > RowLayout { ^ > ListItemBase.qml:125 > +

D7816: Put tabbar in focus chain

2017-09-14 Thread David Rosca
drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7816 To: davidedmundson, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen

D7820: man ioslave: spurious numbers included in clang(1) man page

2017-09-14 Thread Jonathan Marten
marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Viewing the clang(1) man page shows spurious floating point numbers, either "0.0", "3.5" or "7.0", scattered throughout the page: F3910985

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

2017-09-14 Thread David Edmundson
davidedmundson added a comment. See second line attached: F3910924: Spectacle.G18840.png F3910925: Spectacle.i18840.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kd

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

2017-09-14 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This draws a line underneath a Plasma checkbox label when it has keyboard focus. This is needed as when an item

D7815: Don't list tab names twice

2017-09-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7141ad172165: Don't list tab names twice (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7815?vs=19521&id=19524 REV

D7817: Remaining accessibility on Plasma PA

2017-09-14 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7817 AFFECTED FILES applet/contents/ui/Lis

D7815: Don't list tab names twice

2017-09-14 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7815 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, a

D7816: Put tabbar in focus chain

2017-09-14 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7816 AFFECTED FILES applet/contents/ui/mai

D7815: Don't list tab names twice

2017-09-14 Thread David Edmundson
davidedmundson updated this revision to Diff 19521. davidedmundson added a comment. update REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7815?vs=19520&id=19521 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7815 AFFECT

D7815: Don't list tab names twice

2017-09-14 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The name (with a correct role) is already exported as a tab By having the static text internally we get the n

D7814: Disable shortcuts for actions not on the current page

2017-09-14 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures we can have actions on multiple pages which use the same shortcut keysequences without running into clashes (which then in turn disables the sh

Re: Plasma 5.11 beta

2017-09-14 Thread Jonathan Riddell
You should use kglobalaccel framework 5.38.1 (or at least not 5.38.0) https://community.kde.org/Plasma/5.11_Errata Jonathan On 14 September 2017 at 12:07, Jonathan Riddell wrote: > Plasma 5.11 beta is out > https://www.kde.org/announcements/plasma-5.10.95.php > > Packagers will find new tars fo

Plasma 5.11 beta

2017-09-14 Thread Jonathan Riddell
Plasma 5.11 beta is out https://www.kde.org/announcements/plasma-5.10.95.php Packagers will find new tars for drkonqi, split out from one of the plasma tars, and plasma-vault and new plasmoid which depends on cryfs at runtime. The dependency on ddcutils in powerdevil is now not enabled by default

D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

2017-09-14 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:c1fd2638ba80: Use flatpak_installation_list_installed_refs for listing installed flatpaks (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator

D7800: Accessible roles on Plasma NM toolbar checkboxes

2017-09-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R116:f6d3ec9a54b6: Accessible roles on Plasma NM toolbar checkboxes (authored by davidedmundson). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

Re: KGlobalAccel regression in latest frameworks release

2017-09-14 Thread Jonathan Riddell
I've tagged v5.38.1 and released a tar with the change reverted. I've not reverted it in master branch so it will need to be fixed or reverted before 5.39.0 Jonthan

D5034: Add support for x-gvfs style options in fstab

2017-09-14 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D7774 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D5034 To: broulik, #plasma, dhaumann, dfaure Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, progwolff, les

D7798: [Folder View] Fix supported drag actions

2017-09-14 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6b8fa112f47d: [Folder View] Fix supported drag actions (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7798?vs=19479&id=19511 REVISION

D7733: [Folder View Icons Config] Fix initial index of ComboBox

2017-09-14 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4bf0358af9b8: [Folder View Icons Config] Fix initial index of ComboBox (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7733?vs=19308&id