D7629: Do not show reveal password button on login screen

siteshwarv added a comment. gentoo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces Cc: mart, davidedmundson, rharishnavnit, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D7639: [Task Manager] Decode applications URL before dragging

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7639 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D7631: [Folder View] Accept and reject Escape event appropriately

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice then! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7631 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D7640: QtCurve: reduce progressbar timer overhead

yuyichao accepted this revision. This revision is now accepted and ready to land. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D7640 To: rjvbb, yuyichao, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D7640: QtCurve: reduce progressbar timer overhead

yuyichao added a comment. > Style::drawControl() is const, so one also has to move m_timer, m_progressBarAnimateTimer and m_progressBarAnimateFps to a private class, which in addition would have to have a q pointer and a startParentTimer() "proxy" so we can call Style::startTimer() from a co

D5093: Add ~/.local/share/icons to icons search paths

abondrov added a comment. In https://phabricator.kde.org/D5093#142156, @rkflx wrote: > At [2] you can find more information. Please report back if this is missing any information, which questions you still have after reading it or any issues you encounter when getting to know Arcanist. O

D7648: Fix ksysguard not starting on plasmoid click

maxrd2 created this revision. maxrd2 added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After plasmoid has been running for some time (several hours, maybe days), clicking it would produce error: "file:///usr/share/plasma/plasmoids/org.kde.plas

D7629: Do not show reveal password button on login screen

davidedmundson added a comment. What distro? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces Cc: mart, davidedmundson, rharishnavnit, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7629: Do not show reveal password button on login screen

siteshwarv added a comment. I have talked to other people who use sddm on other distros where eye icon is visible. Despite of the eye icon being visible in the password box, people accidentally click it and it takes some time before they realize it. I would prefer to remove it from the login

D7640: QtCurve: reduce progressbar timer overhead

rjvbb set the repository for this revision to R626 QtCurve. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D7640 To: rjvbb, yuyichao, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7640: QtCurve: reduce progressbar timer overhead

rjvbb updated this revision to Diff 19073. rjvbb added a comment. Following Breeze's example, we can defer the creation of a timer for the busy/indeterminate state to when we encounter one, i.e. when `Style::drawControl()` is called with `CE_ProgressBarContents`. Determining if the timer

D7596: Register objectPath before service

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7f270efe9c4a: Register objectPath before service (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7596?vs=18911&id=19072 REVIS

Re: Kscreenlocker 5.10.5.1

¡Hola David! El 2017-08-31 a las 18:12 +0100, David Edmundson escribió: Kscreenlocker has a feature that doesn't play nicely with the latest nvidia driver making the entire thing crash. Given locking the screen is quite an important operation, we've made an immediate release that works round

D5093: Add ~/.local/share/icons to icons search paths

rkflx added a comment. > I don't know how to make commit message look like this one (with phabricator info) Oh, this one just used `arc land`. *blushes* Seems like you used the Phabricator web interface to upload the patch, but using Arcanist is easy once you wrapped your head arou

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

valeriymalov added a comment. It does work with both evdev-controlled pointers, libinput-controlled pointers and even on Wayland. As far as I understand, it just controls how Qt apps react to single "full" scroll event. It's doesn't affect system scroll speed, although takes it in account.

D7514: Create SyncManager only when using X11

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3e0e26204f4c: Create SyncManager only when using X11 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7514?vs=18679&id=19065 REVISION DETAIL

D7447: Move screen inversion through XRandr into X11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:51561052ec03: Move screen inversion through XRandr into X11 standalone platform (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7447?vs=18469&id=19063#toc REPOSITORY

D7444: Move the X11 Decoration Renderer into the X11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:23ef40e63809: Move the X11 Decoration Renderer into the X11 standalone platform (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7444?vs=18465&id=19062#toc REPOSITORY

D7259: Move QPainter compositor into plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R108:535b107969ca: Move QPainter compositor into plugin (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7259?vs=18039&id=19061#toc REPOSITORY R108 KWin CHANGES SINCE LAST

D7504: Do not hard runtime depend on X11 in composite startup

This revision was automatically updated to reflect the committed changes. Closed by commit R108:2892fad5b6c5: Do not hard runtime depend on X11 in composite startup (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7504?vs=18657&id=19064 RE

D7232: Move SceneXRender into a plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R108:054d9234112c: Move SceneXRender into a plugin (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7232?vs=18038&id=19060 REVISION DETAIL https:/

D7640: QtCurve: reduce progressbar timer overhead

rjvbb added a comment. Actually we do when the last progressbar is hidden, destroyed (or gets a QEvent::Close, testing that now). The reason we need to run a timer when progressbars are visible is how their busy mode is implemented. That does not have a separate state and there's no sig

D7406: Move X11 specific event filtering for ScreenEdges into x11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:833f933c5c6a: Move X11 specific event filtering for ScreenEdges into x11 standalone platform (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7406?vs=18378&id=19054#toc

D7395: [tabBox] Move X11 specific event filtering into a dedicated event filter

This revision was automatically updated to reflect the committed changes. Closed by commit R108:9c74be1256cc: [tabBox] Move X11 specific event filtering into a dedicated event filter (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7395?vs=

D7374: Move X11 movingClient handling into a dedicated X11EventFilter

This revision was automatically updated to reflect the committed changes. Closed by commit R108:bd5f5e0915b3: Move X11 movingClient handling into a dedicated X11EventFilter (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7374?vs=18305&id=1

D7398: Don't create QWhatsThis when user presses showContextHelp button

This revision was automatically updated to reflect the committed changes. Closed by commit R108:76ee47151a2c: Don't create QWhatsThis when user presses showContextHelp button (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7398?vs=18361&id

D7425: Add to Wayland captions if the caption is the same

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6685288d4869: Add to Wayland captions if the caption is the same (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7425?vs=18420&id=19055 REVIS

D7426: Make AbstractClient::caption no longer a virtual method

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a7b29e09cefe: Make AbstractClient::caption no longer a virtual method (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7426?vs=18421&id=19056 R

D7450: Move NonComposited Outline into the X11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a3dc2ad5a26e: Move NonComposited Outline into the X11 standalone platform (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7450?vs=18475&id=19058#toc REPOSITORY R108 K

D1798: Port some displayWidth/displayHeight usages to Screens::size()

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1e13deaa1d56: Port some displayWidth/displayHeight usages to Screens::size() (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1798?vs=18548&id=1

D7427: Drop boolean parameter from AbstractClient::caption

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f0652970f4f0: Drop boolean parameter from AbstractClient::caption (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7427?vs=18422&id=19057 REVIS

D7640: QtCurve: reduce progressbar timer overhead

davidedmundson added a comment. Not wanting to run a timer at 20fps when we're not animating a progress bar makes sense. What I don't get is why, when we know we don't need to animate, we don't just stop the timer. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

graesslin added a comment. I agree with Marco, this doesn't make sense and would not work with mouse wheels controlled through xinput and also not on Wayland. Also that it does only affect Qt applications is a clear sign that this should not be done. That would be highly confusing. REPOSITO

D5093: Add ~/.local/share/icons to icons search paths

abondrov added a comment. In https://phabricator.kde.org/D5093#142069, @davidedmundson wrote: > Do you have commit access? I guess I should still have it. But I don't know how to make commit message look like this one (with phabricator info): https://cgit.kde.org/plasma-integrati

Re: qqc2-desktop-style as framework

On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote: > any objection into pulling it into a framework? anything particular for the > procedure? as an update to that, i've update its cmake files and metadata files to be coherent with other frameworks, at this point i'll wait a couple of weeks if t

D5093: Add ~/.local/share/icons to icons search paths

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5093 To: abondrov, jriddell, broulik,

D5093: Add ~/.local/share/icons to icons search paths

abondrov updated this revision to Diff 19048. abondrov added a comment. Remove XDG_DATA_DIRS stuff. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5093?vs=18417&id=19048 REVISION DETAIL https://phabricator.kde.org/D5093

D7640: QtCurve: reduce progressbar timer overhead

rjvbb set the repository for this revision to R626 QtCurve. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D7640 To: rjvbb, yuyichao, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7640: QtCurve: reduce progressbar timer overhead

rjvbb updated this revision to Diff 19044. rjvbb edited the summary of this revision. rjvbb added a comment. cleaned up version that also switches the timer back to idling frequency CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7640?vs=19042&id=19044 REVISION DETAIL https://phabr

D5093: Add ~/.local/share/icons to icons search paths

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. oh, this patch isn't messed up, you're just not removing the original XDG_DATA_DIRS stuff. This is going to cause duplication of the /usr/share/ results REPOS

D7640: QtCurve: reduce progressbar timer overhead

rjvbb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Debugging an unrelated timer issue with GammaRay I noticed QtCurve can have multiple progressbar timers active in more complex applications like

D7632: [Folder View] Also handle Enter key (on numpad) to run files and cd into folders

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eca3cb1fecf4: [Folder View] Also handle Enter key (on numpad) to run files and cd into folders (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

D7624: [Containment Actions Config] Cleanup layout and support multiple modifiers

broulik updated this revision to Diff 19039. broulik added a comment. Add Binding for configurationChanged and remove explicit calls now that https://phabricator.kde.org/D7626 landed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7624?vs=18991&id=19

D7626: [CurrentContainmentActionsModel] Emit configurationChanged when action is added/removed/edited

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3f093c395b1d: [CurrentContainmentActionsModel] Emit configurationChanged when action is… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D7633: [Digital Clock] Compact and move to the end font setup

broulik added a comment. > I guess it's because it's not in a groupbox. Yes, it is not, as it's not "Information" and I didn't want to put a new GroupBox around it for that one item. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7633 To: broulik, #pl

D7624: [Containment Actions Config] Cleanup layout and support multiple modifiers

broulik added a comment. F3894718: Screenshot_20170901_115407.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7624 To: broulik, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D7633: [Digital Clock] Compact and move to the end font setup

mck182 added a comment. The horizontal alignment of the label is off compared to the rest of the labels, I guess it's because it's not in a groupbox. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7633 To: broulik, #plasma, #vdg, mart Cc: mck182, mart, pla

D7633: [Digital Clock] Compact and move to the end font setup

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. I like it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7633 To: broulik, #plasma, #vdg, mart Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D7629: Do not show reveal password button on login screen

mart added a comment. -1 as well, icon should be fixed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces Cc: mart, davidedmundson, rharishnavnit, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7624: [Containment Actions Config] Cleanup layout and support multiple modifiers

mart added a comment. how does it look when all texts in the buttons at the left are short? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7624 To: broulik, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7626: [CurrentContainmentActionsModel] Emit configurationChanged when action is added/removed/edited

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7626 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

Plasma 5.11 Release announcement / feature list

[re-sent in plain text format, BlackBerry Hub keeps insisting on using HTML email -.-] Hi all, I just figured we've got two weeks left until the 5.11 Beta release on Thursday, 14 September with final release on Tuesday, 10 October, so I started an Etherpad: https://notes.kde.org/p/plasma_5_11

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

mart added a reviewer: VDG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7558 To: valeriymalov, #plasma, #vdg Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

mart added a comment. i don't think the setting makes sense REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7558 To: valeriymalov, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7639: [Task Manager] Decode applications URL before dragging

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY An external application is unlikely to understand them. TEST PLAN I can now drag applications from task manager to my desktop or Dolphin aga

D7631: [Folder View] Accept and reject Escape event appropriately

broulik added a comment. It also improves the experience when in a panel. The popup won't just close when I press Escape while renaming but also first cancel the rename and then close the popup. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7631 To: brouli