D1231: Add Remote Access interface to KWayland

2017-08-26 Thread Alexey Min
alexeymin added a comment. In https://phabricator.kde.org/D1231#39191, @Kanedias wrote: > ... > Besides, I didn't find any mentions of multi-screen capabilities in Krfb at all. It currently works like this: > > d->framebufferImage = XGetImage(QX11Info::display(), >

D6096: Add Wayland RemoteAccess capabilities to KRfb

2017-08-26 Thread Alexey Min
alexeymin added a comment. There was a https://phabricator.kde.org/D5211, that added `xcb` framebuffer plugin; and after that `x11` framebuffer was removed from source tree ( https://phabricator.kde.org/R437:f131f7ddba584779144e7f737a98b24de430824c ), so this patch of needs to be slightly up

plasma-desktop-5.10.5/kcms/kfontinst/kcmfontinst/FontList.cpp:1415: suspicious if ?

2017-08-26 Thread David Binderman
Hello there, plasma-desktop-5.10.5/kcms/kfontinst/kcmfontinst/FontList.cpp:1415]: (style) Same expression on both sides of '||'. Source code is if(!Misc::app(KFI_VIEWER).isEmpty() || !Misc::app(KFI_VIEWER).isEmpty()) Suggest code rework. Regards David Binderman

D7567: Support edit and appstream actions also for application search results

2017-08-26 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY BUG:384036 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7567 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/kicker/plugin/actionlis

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread Heiko Becker
heikobecker added a comment. > But you can clear klipper's history. As you point out yourself "klipper provides that in the UI." From our POV what does it matter if that's exposed via a button here, or elsewhere. The fact that you could have malware doesn't remove the legit reasons to talk t

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7536#140395, @davidedmundson wrote: > But clearing isn't the only thing in that interface - for me it's about KPasteTextAction in KConfigWidgets, which replaces the regular paste action with a menu of entries and stuff. w

D7561: Avoid absolute paths to .desktop files in launcher URLs.

2017-08-26 Thread Eike Hein
hein updated this revision to Diff 18822. hein added a comment. One more comment. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7561?vs=18820&id=18822 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7561 AFFECTED FILES libtaskm

D7561: Avoid absolute paths to .desktop files in launcher URLs.

2017-08-26 Thread Eike Hein
hein updated this revision to Diff 18820. hein added a comment. Add comments. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7561?vs=18818&id=18820 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7561 AFFECTED FILES libtaskmanag

D7562: Understand KAStats-style applications: launcher URLs.

2017-08-26 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY See https://phabricator.kde.org/D7561. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7562 AFFECTED FILES applets/taskmanager/plugin/backend.cpp To

D7561: Avoid absolute paths to .desktop files in launcher URLs.

2017-08-26 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In any place we look up a KService, check if it has a menuId, and then generate KAStats-style applications: URL with it. Also learn how to han

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread David Edmundson
davidedmundson added a comment. > You cannot clear a clipboard history on X11 But you can clear klipper's history. As you point out yourself "klipper provides that in the UI." From our POV what does it matter if that's exposed via a button here, or elsewhere. The fact that you could have

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7536#140344, @heikobecker wrote: > FWIW, judging from a quick test the patch works and the applets history can be cleared via sweeper. > > In the case this causes problems, would there be another solution to clear the history

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

2017-08-26 Thread Valeriy Malov
valeriymalov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This should allow user to disable scrollwheel in KDE/Qt apps This does not seem to affect non-Qt apps, e.g. Google Chrome, but they ig

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread Heiko Becker
heikobecker added a comment. FWIW, judging from a quick test the patch works and the applets history can be cleared via sweeper. In the case this causes problems, would there be another solution to clear the history? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D1231: Add Remote Access interface to KWayland

2017-08-26 Thread David Edmundson
davidedmundson added a comment. Martin, I explicitly asked you to look at this on Monday. It's being really unfair to a new contributor to make them jump through all sorts of hoops to do things the way you want them, and leave them hanging for literally over a year. REPOSITORY R127 KW

D7555: Add basic example for adjusting column width draggable handle

2017-08-26 Thread Eike Hein
hein updated this revision to Diff 18809. hein added a comment. Increase handle width, position above boundary. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7555?vs=18800&id=18809 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7555 AFF

D7332: Port primary combo box to QComboBox::activated

2017-08-26 Thread David Edmundson
davidedmundson closed this revision. davidedmundson added a comment. Made diff against non-master REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D7332 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter

D6047: Support XDG v6

2017-08-26 Thread David Edmundson
davidedmundson updated this revision to Diff 18807. davidedmundson marked 10 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. added some comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE htt

D7535: Don't special case file URLs when processing .desktop files

2017-08-26 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:09624c713e63: Don't special case file URLs when processing .desktop files (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7535?v

D7531: Update SurfaceInterface outputs when an output global gets destroyed

2017-08-26 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:16f4486cc54c: Update SurfaceInterface outputs when an output global gets destroyed (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7531?vs=18741&id=18804#toc REPOS

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

2017-08-26 Thread David Edmundson
davidedmundson added a comment. > This change *is* a fix for the blurry icon which accidentally improves the config UI ;-) Well not really, for absolute paths you're just avoding a bug in IconItem. See https://bugs.kde.org/show_bug.cgi?id=383513 REPOSITORY R119 Plasma Desktop REVISIO

D7555: Add basic example for adjusting column width draggable handle

2017-08-26 Thread Eike Hein
hein updated this revision to Diff 18800. hein added a comment. Disable drag handle narrow mode. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7555?vs=18799&id=18800 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7555 AFFECTED FILES e

D7555: Add basic example for adjusting column width draggable handle

2017-08-26 Thread Eike Hein
hein added a comment. Note: Marco asked me to write an example for this. This was partially because I originally had a problem making it work: Shrinking didn't work quite right, and I would get a horizontal scrollbar in the PageRow. This turned out to be because I originally had the drag han

D7555: Add basic example for adjusting column width draggable handle

2017-08-26 Thread Eike Hein
hein created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Useful for applications in wide mode that use a first page as "sidebar" to the second page, as shown in the Simple Chat example, which this

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

2017-08-26 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b46cd1ed167c: Use icon chooser in Kicker and Dashboard configuration to select custom icon (authored by dvratil). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D7509: Add a property to hide the PageRow separator matching AbstractListItem.

2017-08-26 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R169:57d9bf1d73c8: Add a property to hide the PageRow separator matching AbstractListItem. (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7509?vs=18

D7535: Don't special case file URLs when processing .desktop files

2017-08-26 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7535 To: davidedmundson, #plasma, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D7469: Use icon chooser in Kicker and Dashboard configuration to select custom icon

2017-08-26 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7469 To: dvratil, #plasma, hein Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D7543: [autotests] Support new way to run the tests without need to install

2017-08-26 Thread Martin Flöser
graesslin updated this revision to Diff 18794. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Adjusted library path so that tests prefer what is in build dir - set LIBRARY_OUTPUT_DIRECTORY for globalaccel and aurorae, so that they are picked

D7531: Update SurfaceInterface outputs when an output global gets destroyed

2017-08-26 Thread Martin Flöser
graesslin added a comment. Could you please push this change, it fixes a crash in KWin when changing outputs (as discovered by PlasmaSurfaceTest::testOSDPlacement()): Thread 1 "testPlasmaSurfa" received signal SIGSEGV, Segmentation fault. KWayland::Server::OutputInterface::clientRes

D7543: [autotests] Support new way to run the tests without need to install

2017-08-26 Thread Martin Flöser
graesslin updated this revision to Diff 18790. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. - changed add_test to newer syntax so that tests are found after a clean build - kglobalaccel still loads wrong plugin (might need fixing in kglobalacc