Re: querying current mouse state

2017-08-09 Thread René J . V . Bertin
Martin Flöser wrote: Hi > of the buttons, but just sends the press events. I'm pretty sure that > not even the kernel knows it, otherwise libinput would expose it. It doesn't need to know it (and probably shouldn't because why would it). All it needs to know is how to read the information from

D7123: Several cleanups

2017-08-09 Thread Fabian Vogt
fvogt closed this revision. fvogt added a comment. Didn't get closed automatically... https://commits.kde.org/kwallet-pam/a33ec22b96e837899528b05963eae8ea6b01171a REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D7123 To: fvogt, #plasma, davidedmun

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

2017-08-09 Thread David Edmundson
davidedmundson abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: davidedmundson, #plasma, matank Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

2017-08-09 Thread David Edmundson
davidedmundson commandeered this revision. davidedmundson edited reviewers, added: matank; removed: davidedmundson. davidedmundson added a comment. > I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves the issue. I'll close this . REPOSITORY R242 Plasma Framewor

D7093: Implement the shortcut caption suffix for Wayland windows

2017-08-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH shell-client-shortcut-caption REVISION DETAIL https://phabricator.kde.org/D7093 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut

D7123: Several cleanups

2017-08-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R107 KWallet PAM Integration BRANCH patch1 REVISION DETAIL https://phabricator.kde.org/D7123 To: fvogt, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

[Powerdevil] [Bug 383327] Screen not locking on resume from suspend

2017-08-09 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=383327 Martin Flöser changed: What|Removed |Added Assignee|plasma-b...@kde.org |plasma-devel@kde.org Product|kscreen

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

2017-08-09 Thread Martin Flöser
graesslin added a comment. > the send_selection spec says we should be passing a null resource if we have no selection, whereas this version creates a data offer with nothing in it. But we have a selection, that's the point. We just don't have a datasource on the selection. Relevant

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

2017-08-09 Thread David Edmundson
davidedmundson added a comment. I don't think we did go in there because we have a selection, otherwise other->selection() wouldn't be null. If we want DDI::sendSelection(DDI *other) to always keep the client in sync we should do: auto selection = other->selection(); if (!sele

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

2017-08-09 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7078#134111, @davidedmundson wrote: > Isn't the real bug from that trace here: > > datadevice_interface.cpp:204 > void DataDeviceInterface::sendSelection(DataDeviceInterface *other) > d->createDataOffer(other->selection()

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

2017-08-09 Thread David Edmundson
davidedmundson added a comment. Isn't the real bug from that trace here: datadevice_interface.cpp:204 void DataDeviceInterface::sendSelection(DataDeviceInterface *other) d->createDataOffer(other->selection()); it's valid for other->selection() to be null, so this should be guarded

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

2017-08-09 Thread Martin Flöser
graesslin added a comment. ping! This is a crash fix. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To: graesslin, #kwin, #plasma, #frameworks Cc: plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,

D7214: Add virtual Scene::scenePainter method

2017-08-09 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:ad4a3107d548: Add virtual Scene::scenePainter method (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7214?vs=17914&id=17930 REVISION DETAIL

[Powerdevil] [Bug 383296] Powerdevil immediately discards xdg-screensaver inhibitions

2017-08-09 Thread Nicolas Frattaroli
https://bugs.kde.org/show_bug.cgi?id=383296 --- Comment #3 from Nicolas Frattaroli --- Nevermind, just read all the comments on that bug report and it looks like this was reported upstream and indeed the same issue. -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 383296] Powerdevil immediately discards xdg-screensaver inhibitions

2017-08-09 Thread Nicolas Frattaroli
https://bugs.kde.org/show_bug.cgi?id=383296 --- Comment #2 from Nicolas Frattaroli --- This is not a duplicate of that bug, for me, the inhibition does not work at all. The screen lock or dimming proceeds regardless. -- You are receiving this mail because: You are the assignee for the bug.

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-09 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. lovely jubbly! REPOSITORY R169 Kirigami BRANCH arcpatch-D6549 REVISION DETAIL https://phabricator.kde.org/D6549 To: apol, #kirigami, sitter, mart, davidedmundson Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH arcpatch-D6549 REVISION DETAIL https://phabricator.kde.org/D6549 To: apol, #kirigami, sitter, mart, davidedmundson Cc: plasma-devel, apol, mart

D6549: Look for QtGraphicalEffects, so packagers don't forget it

2017-08-09 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 17925. apol added a comment. Use the macro in ECM now REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6549?vs=16296&id=17925 BRANCH arcpatch-D6549 REVISION DETAIL https://phabricator.kde.org/D6549 AFFECTED FILES C

D7214: Add virtual Scene::scenePainter method

2017-08-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH scene-qpainter REVISION DETAIL https://phabricator.kde.org/D7214 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts