This revision was automatically updated to reflect the committed changes.
Closed by commit R134:224012fabcf2: Install required runtime for flatpakref if
it's specified (authored by jgrulich).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7201?
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c1892e6c0fd4: Add virtual Scene::xrenderBufferPicture
method (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7207?vs=17897&id=17915
REVISION D
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
So far EffectsHandlerImpl directly accessed SceneQPainter::painter
through a dynamic cast. If in future the QPainter based compositor shoul
https://bugs.kde.org/show_bug.cgi?id=383296
David Edmundson changed:
What|Removed |Added
CC||k...@davidedmundson.co.uk
Resolution|
https://bugs.kde.org/show_bug.cgi?id=383296
Bug ID: 383296
Summary: Powerdevil immediately discards xdg-screensaver
inhibitions
Product: Powerdevil
Version: 5.10.4
Platform: Archlinux Packages
OS: Linux
hein added a comment.
Hmm shouldn't we improve the caching in either KDirModel or FolderModel then?
Working around a performance issue in the model in delegate code just feels so
wrong. Any potential other user of FolderModel (e.g. future Plasma Mobile file
manager) would possibly have to k
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
flatpakref-runtime
REVISION DETAIL
https://phabricator.kde.org/D7201
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber
davidedmundson added a comment.
I would agree that we shouldn't be copying model data... But I'm not adding
that, it's already there.
> The FolderView::data() implementation already uses a cache
It seems we only cache the result of .desktop files that point to remote
URLs. The rest
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ContextMenu.qml:126
> +if (elided) {
> +item.action.text += "...";
> +}
We can't hard-code "...". Different lo
hein added a comment.
> model.isDir() does a full stat of a file.
model.isDir() does indeed, but this uses model.isDir, which is a data role.
The FolderView::data() implementation already uses a cache. The cache is
inserted into the first time isDir() is called and evicted e.g. on item
davidedmundson accepted this revision.
REPOSITORY
R108 KWin
BRANCH
scene-render-buffer
REVISION DETAIL
https://phabricator.kde.org/D7207
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abet
graesslin updated this revision to Diff 17897.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Incorporated David's naming suggestion
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7207?vs=17895&id=17897
BRANCH
hein added a comment.
UI design note: Even though I'm nerdy enough to understand the checkbox
stuff, sometimes I want to remove a favorite and spend two seconds of confusion
looking for a Remove action ...
REVISION DETAIL
https://phabricator.kde.org/D3805
To: ivan, mart, hein
Cc: Zren, pl
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> scene.h:164
> + **/
> +virtual xcb_render_picture_t bufferPicture() const;
> +
IMHO, as this class is generic, yet the return type is very speci
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
So far EffectsHandlerImpl directly accessed SceneXrender::bufferPicture
through a dynamic cast. If in future the XRender based composito
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1e9591ae400a: give wallpaper packages a comment (authored
by sitter).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7070?vs=17558&id=17882
REVISION DETAI
Sorry for delayed note-sending, attached logs and notes
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
2017-08-07 15:31:47 <@bshah> meeting?
2017-08-07 15:32:02 meetng!
2017-08-07 15:32:27 <@bshah> notmart
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master-comments
REVISION DETAIL
https://phabricator.kde.org/D7070
To: sitter, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
dfaure added a comment.
Ah, this key is already used, for applications? I wasn't aware, if that's the
case.
Hmm, then maybe better keep the same key indeed.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart, #frameworks, #plasma
Cc: dfaure, plasma-deve
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8e7e96db2683: Summary: change user visible text to use
modern branding (authored by jriddell).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7202?vs=17878
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
startplasma (wayland) uses the font DPI value from this config.
We don't require X11 to show a spinbox and save it to a file.
The
davidedmundson accepted this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7202
To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
jriddell added a comment.
ack
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7202
To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mar
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7204
To: davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seb
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
and comment at the top of startplasma.cmake please.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7202
To: jriddell, #p
jriddell updated this revision to Diff 17878.
jriddell added a comment.
- change comment to current branding
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7202?vs=17877&id=17878
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7202
jriddell added a comment.
I don't see any user visible strings in the startplasma/startplasmacompositor
scripts, it's just that one comment
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7202
To: jriddell, #plasma, davidedmundson
Cc: davidedmundson, plasma
jriddell updated this revision to Diff 17877.
jriddell added a comment.
- change comment to current branding
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7202?vs=17872&id=17877
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7202
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Micro-optimisation.
model.isDir() does a full stat of a file.
We hover a lot, may as well use a cached version of the variable.
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
any changes to this file should be mirrored in the wayland version (split as
either startplasma/startplasmacompositor)
REPOSITORY
R120 Plasma Workspace
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7cfdd9a5260b: Set a default font DPI if not set (authored
by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7185?vs=17828&id=17874
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0fa58f0abc71: Determine if we should use Qt scaling based
on env var (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7200?vs=1
jriddell added a reviewer: Plasma.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7202
To: jriddell, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
change user visible text to use modern branding
TEST PLAN
run it
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
ht
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
ok, let's go with this verison
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7200
To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, progwol
jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
If one wants to install using flatpakref which requires a runtime we should
check
if it's installed and provided by the flatpakref file to
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7f9e7c854936: Terminology fixes in KCMs:
KDE-as-the-desktop -> Plasma (authored by ltoscano).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6469?vs=16149&id
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
KWindowSystem::platform() cannot be used before QApplication is
constructed.
QCoreApplication::setAttribute needs to be called be
davidedmundson added a comment.
@notmart
If this was generic code, we should care about that.
For plasmashell we can be sure we're launched via startplasma and have the
env vars that set. If they're not there, it's the user's fault for being weird.
I might make it an expliticit en
mart added a comment.
In https://phabricator.kde.org/D6899#133625, @dfaure wrote:
> "Show" is a bit of a historical name here, this isn't about showing apps in
a menu...
>
> X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no?
>
> Looks good otherwise.
that would
mart added a comment.
wonder if we'll have to end up adding a command line switch for it? :(
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7188
To: davidedmundson, #plasma, mart
Cc: graesslin, cfeck, mart, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali
mart added a comment.
In https://phabricator.kde.org/D7188#133604, @graesslin wrote:
> You could check for env variable QT_QPA_PLATFORM
what about when is undefined but platform undetected?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7188
To
really they require Weston? (which, was intended pretty much as a proof of
concept)
On Monday 07 August 2017 10:47:44 Agustin Benito wrote:
> Dear Plasma devs,
>
> this document might be of interest. Please read below for context.
>
>
> Agustin Benito (toscalix)
> KDE eV member
> Profile: http
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:3e63fa62e629: [Color Picker] Add drag pixmap for color
(authored by broulik).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7184?vs=17825&id=17865
REVISION
dfaure added a comment.
"Show" is a bit of a historical name here, this isn't about showing apps in a
menu...
X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no?
Looks good otherwise.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart, #f
45 matches
Mail list logo
