D7077: Drop Client::cap_deco as it's nowhere used

2017-08-02 Thread Martin Flöser
graesslin added a comment. Sorry, the update should have gone in a new phab request. Arc failed me. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7077 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D7077: Drop Client::cap_deco as it's nowhere used

2017-08-02 Thread Martin Flöser
graesslin updated this revision to Diff 17607. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Implement the shortcut caption suffix for Wayland windows REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7077?vs=175

D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma

2017-08-02 Thread Luigi Toscano
ltoscano added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D6952: Properly render XWayland windows in SceneQPainter

2017-08-02 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:20e314d151e0: Properly render XWayland windows in SceneQPainter (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6952?vs=17308&id=17590#toc REPOSITORY R108 KWin CHANG

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

2017-08-02 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This crash got triggered in KWin when sending the selection to XWayland. While the test handles condition of not yet

D7046: Use xcb-icccm to read the name property

2017-08-02 Thread Martin Flöser
graesslin updated this revision to Diff 17587. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Same for fetchIconicName REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7046?vs=17573&id=17587 BRANCH xcb-iccm-name

D7077: Drop Client::cap_deco as it's nowhere used

2017-08-02 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY cap_deco was only used in the caption with stripped arg case which was unused and thus removed. Now cap_deco is completely unused.

kwin_wayland xdgv6: crash on ping

2017-08-02 Thread Marco Martin
Hi all, reporting it here my latest findings on a crash in the xdgv6 branch in kwin, which i think it *may* reveal something else wrong besides the implementation of the thing that it's crashing in particular (ping) when there are many windows opening and closing, we have a kwin crash with the b

D2957: [SDDM Theme] Offer switching to the user's session if there is one

2017-08-02 Thread matthias sweertvaegher
matthiass added a comment. In https://phabricator.kde.org/D2957#130176, @davidedmundson wrote: > This: https://github.com/sddm/sddm/pull/730 sweet! any idea on when we could expect a release? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2957

D6952: Properly render XWayland windows in SceneQPainter

2017-08-02 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH scene-qpainter-fix-xwayland REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot,

D6952: Properly render XWayland windows in SceneQPainter

2017-08-02 Thread Martin Flöser
graesslin added a comment. ok to go in? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lu

D6828: Send QKeyEvent with Qt::Key as expected by Qt to internal windows

2017-08-02 Thread Martin Flöser
graesslin added a comment. ping REVISION DETAIL https://phabricator.kde.org/D6828 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6411: [platforms/x11] Use a GlxContextAttributeBuilder

2017-08-02 Thread Martin Flöser
graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6411 To: graesslin, #kwin, #plasma Cc: kwin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6785: Move bitCount from utils to GlxBackend

2017-08-02 Thread Martin Flöser
graesslin abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D6785 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7059: Drop the stripped parameter from AbstractClient::caption

2017-08-02 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:afd52c188ab0: Drop the stripped parameter from AbstractClient::caption (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7059?vs=17534&id=17576

D6892: Process all clients when updating fullscreen for active client

2017-08-02 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:4a0787c0582b: Process all clients when updating fullscreen for active client (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6892?vs=17158&id=1

D7046: Use xcb-icccm to read the name property

2017-08-02 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > fvogt wrote in client.cpp:1428 > That does not matter in this instance. > `QString::fromUtf8(QByteArray(reply.name, reply.name_len));` does two copies: > > - QByteArray copies name_len bytes from name into a heap-allocated buffer > - QString co

D7046: Use xcb-icccm to read the name property

2017-08-02 Thread Martin Flöser
graesslin updated this revision to Diff 17573. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Add simplified() REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7046?vs=17515&id=17573 BRANCH xcb-iccm-name REVISI

D7065: warning--

2017-08-02 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1bd3145694b6: warning-- (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7065?vs=17551&id=17572 REVISION DETAIL https://phabricator.k

D7065: warning--

2017-08-02 Thread Harald Sitter
sitter added a comment. In https://phabricator.kde.org/D7065#131436, @anthonyfieroni wrote: > So, why don't make lamba without parameters? Same reason it didn't use a `(bool activate)` signature, whatever that reason might have been I could not say. Not my code. REPOSITORY R120

Re: Implementing a plasma colorscheme generator

2017-08-02 Thread Aleix Pol
On Tue, Aug 1, 2017 at 10:05 PM, Andrew wrote: > I have made a simple program that generates a plasma colorscheme from an > image. I am hoping to integrate it into plasma, making it so it takes the > current wallpaper (or any image) and allows the user to generate a colorscheme > based off of that

D7065: warning--

2017-08-02 Thread Anthony Fieroni
anthonyfieroni added a comment. So, why don't make lamba without parameters? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7065 To: sitter, apol Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7065: warning--

2017-08-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7065 To: sitter, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D7039: Fix build on linux

2017-08-02 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7039 To: apol, #kirigami, mart Cc: plasma-devel, apol, mart

D7073: [Wallpaper Configuration] Make Get New Stuff dialog modal to config window

2017-08-02 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Clicked "Get New Wallpaper", dialog was modal to the wallpaper config but not all of Plasma (windowmodal) REPOSITORY R120 Plasma Workspace REVISI

D6880: [Folder View] Indicate cut items

2017-08-02 Thread Eike Hein
hein added a comment. I'm wondering if this should be done in KIO/KDirModel ... does Dolphin do this per-view too? INLINE COMMENTS > broulik wrote in foldermodel.cpp:1714 > I think this check down here is wrong/not working properly Can you elaborate? REPOSITORY R119 Plasma Desktop REVIS

D7070: give wallpaper packages a comment

2017-08-02 Thread Harald Sitter
sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY comment gets converted to summary in appstream data and summaries are required, without it we'll fail the appstream test. REPOSITORY R120 P

D6956: Stop unnecessarily killing IBus when applying keyboard layouts config

2017-08-02 Thread David Edmundson
davidedmundson added a comment. It does when uploaded with arc diff, it doesn't otherwise. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6956 To: achauvel, xapienz, xuetianweng Cc: davidedmundson, cfeck, hein, xapienz, plasma-devel, #plasma, ZrenBot, progwo

D7065: warning--

2017-08-02 Thread Harald Sitter
sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY active is unused, don't declare it TEST PLAN no compiler warning raised about the unused var anymore REPOSITORY R120 Plasma Workspace BRA

D6956: Stop unnecessarily killing IBus when applying keyboard layouts config

2017-08-02 Thread Eike Hein
hein added a comment. I used arc patch which usually preserves authorship, I don't know why it didn't this time - I blame the tool. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6956 To: achauvel, xapienz, xuetianweng Cc: cfeck, hein, xapienz, plasma-dev

D6956: Stop unnecessarily killing IBus when applying keyboard layouts config

2017-08-02 Thread Christoph Feck
cfeck added a comment. Eike, next time you commit patches from contributors, please use the --author option in git commit to give proper attribution. Additionally, a bug number was given, but BUG: keyword was missing in the commit message. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7064: [Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel

2017-08-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:103c19119d67: [Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D7064: [Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel

2017-08-02 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7064 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D7064: [Folder View Config] Replace FilterableMimeTypesModel by Plasma SortFilterModel

2017-08-02 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We already have a ready-to-use filter model for that. While at it, make the filter case-insensitive. TEST PLAN Typing a filter filters the

D6938: [Folder View Config] Make model writable and drop custom setRowChecked method

2017-08-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:76af2694e937: [Folder View Config] Make model writable and drop custom setRowChecked method (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

2017-08-02 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e0b719f1e71: [Containment Interface] always emit contextualActionsAboutToShow for containment (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://p

D7059: Drop the stripped parameter from AbstractClient::caption

2017-08-02 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. `boolean trap--` :) REPOSITORY R108 KWin BRANCH client-caption-no-stripped REVISION DETAIL https://phabricator.kde.org/D7059 To: graesslin, #kwin, #plasma, broulik Cc: broulik, pl

D6938: [Folder View Config] Make model writable and drop custom setRowChecked method

2017-08-02 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6938 To: broulik, #plasma, hein Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,