graesslin added a comment.
Sorry, the update should have gone in a new phab request. Arc failed me.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7077
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
graesslin updated this revision to Diff 17607.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Implement the shortcut caption suffix for Wayland windows
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7077?vs=175
ltoscano added a comment.
Ping?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6469
To: ltoscano
Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:20e314d151e0: Properly render XWayland windows in
SceneQPainter (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6952?vs=17308&id=17590#toc
REPOSITORY
R108 KWin
CHANG
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This crash got triggered in KWin when sending the selection to XWayland.
While the test handles condition of not yet
graesslin updated this revision to Diff 17587.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Same for fetchIconicName
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7046?vs=17573&id=17587
BRANCH
xcb-iccm-name
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
cap_deco was only used in the caption with stripped arg case which was
unused and thus removed. Now cap_deco is completely unused.
Hi all,
reporting it here my latest findings on a crash in the xdgv6 branch in kwin,
which i think it *may* reveal something else wrong besides the implementation
of the thing that it's crashing in particular (ping)
when there are many windows opening and closing, we have a kwin crash with the
b
matthiass added a comment.
In https://phabricator.kde.org/D2957#130176, @davidedmundson wrote:
> This: https://github.com/sddm/sddm/pull/730
sweet! any idea on when we could expect a release?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2957
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
scene-qpainter-fix-xwayland
REVISION DETAIL
https://phabricator.kde.org/D6952
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot,
graesslin added a comment.
ok to go in?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6952
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lu
graesslin added a comment.
ping
REVISION DETAIL
https://phabricator.kde.org/D6828
To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6411
To: graesslin, #kwin, #plasma
Cc: kwin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol, mart, lukas
graesslin abandoned this revision.
REVISION DETAIL
https://phabricator.kde.org/D6785
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:afd52c188ab0: Drop the stripped parameter from
AbstractClient::caption (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7059?vs=17534&id=17576
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:4a0787c0582b: Process all clients when updating
fullscreen for active client (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6892?vs=17158&id=1
graesslin added inline comments.
INLINE COMMENTS
> fvogt wrote in client.cpp:1428
> That does not matter in this instance.
> `QString::fromUtf8(QByteArray(reply.name, reply.name_len));` does two copies:
>
> - QByteArray copies name_len bytes from name into a heap-allocated buffer
> - QString co
graesslin updated this revision to Diff 17573.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Add simplified()
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7046?vs=17515&id=17573
BRANCH
xcb-iccm-name
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1bd3145694b6: warning-- (authored by sitter).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7065?vs=17551&id=17572
REVISION DETAIL
https://phabricator.k
sitter added a comment.
In https://phabricator.kde.org/D7065#131436, @anthonyfieroni wrote:
> So, why don't make lamba without parameters?
Same reason it didn't use a `(bool activate)` signature, whatever that reason
might have been I could not say. Not my code.
REPOSITORY
R120
On Tue, Aug 1, 2017 at 10:05 PM, Andrew wrote:
> I have made a simple program that generates a plasma colorscheme from an
> image. I am hoping to integrate it into plasma, making it so it takes the
> current wallpaper (or any image) and allows the user to generate a colorscheme
> based off of that
anthonyfieroni added a comment.
So, why don't make lamba without parameters?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7065
To: sitter, apol
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7065
To: sitter, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, ap
apol closed this revision.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D7039
To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Clicked "Get New Wallpaper", dialog was modal to the wallpaper config but not
all of Plasma (windowmodal)
REPOSITORY
R120 Plasma Workspace
REVISI
hein added a comment.
I'm wondering if this should be done in KIO/KDirModel ... does Dolphin do
this per-view too?
INLINE COMMENTS
> broulik wrote in foldermodel.cpp:1714
> I think this check down here is wrong/not working properly
Can you elaborate?
REPOSITORY
R119 Plasma Desktop
REVIS
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
comment gets converted to summary in appstream data and summaries are
required, without it we'll fail the appstream test.
REPOSITORY
R120 P
davidedmundson added a comment.
It does when uploaded with arc diff, it doesn't otherwise.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel, xapienz, xuetianweng
Cc: davidedmundson, cfeck, hein, xapienz, plasma-devel, #plasma, ZrenBot,
progwo
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
active is unused, don't declare it
TEST PLAN
no compiler warning raised about the unused var anymore
REPOSITORY
R120 Plasma Workspace
BRA
hein added a comment.
I used arc patch which usually preserves authorship, I don't know why it
didn't this time - I blame the tool. :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6956
To: achauvel, xapienz, xuetianweng
Cc: cfeck, hein, xapienz, plasma-dev
cfeck added a comment.
Eike, next time you commit patches from contributors, please use the --author
option in git commit to give proper attribution. Additionally, a bug number was
given, but BUG: keyword was missing in the commit message.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:103c19119d67: [Folder View Config] Replace
FilterableMimeTypesModel by Plasma SortFilterModel (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kd
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7064
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We already have a ready-to-use filter model for that.
While at it, make the filter case-insensitive.
TEST PLAN
Typing a filter filters the
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:76af2694e937: [Folder View Config] Make model writable
and drop custom setRowChecked method (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7e0b719f1e71: [Containment Interface] always emit
contextualActionsAboutToShow for containment (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://p
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
`boolean trap--` :)
REPOSITORY
R108 KWin
BRANCH
client-caption-no-stripped
REVISION DETAIL
https://phabricator.kde.org/D7059
To: graesslin, #kwin, #plasma, broulik
Cc: broulik, pl
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6938
To: broulik, #plasma, hein
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol,
38 matches
Mail list logo