D6974: Make unittest independent from the location of the executable.

2017-07-28 Thread David Faure
dfaure created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This fixes the check in the unittest when doing set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103505 --- Ship it! Ship It! - Sebastian Kügler On Dec. 27, 2016,

D6933: [Component Chooser] Update http(s) scheme handler when changing default browser

2017-07-28 Thread David Faure
dfaure added a comment. In https://phabricator.kde.org/D6933#129446, @broulik wrote: > > I suppose updating the handler for text/html would make sense too, so that clicking on a local HTML file opens the same webbrowser. > > Well, KRun has a special case for text/html to always open t

D6970: Bug 382834 Patch

2017-07-28 Thread David Greengas
dgreengas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Patch created per bug report https://bugs.kde.org/show_bug.cgi?id=382834 Per the QML specification, the animation Easing.InQuad should b

Re: Review Request 130205: View Styles

2017-07-28 Thread Andreas Kainz
> On Juli 28, 2017, 9:14 vorm., Sebastian Kügler wrote: > > Why? > > > > The mode chooser is hidden well enough that it doesn't produce visual noise > > and not a lot of extra burden on the user (since there's UI for switching > > anyway, 2 or 3 options doesn't make it a lot lighter). Moreover

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-28 Thread Martin Flöser
graesslin added a comment. Good news: the combo worked! The crashing useractionsmenu test just passed on build.kde.org. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, kwin, Zren

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-28 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:06433997e8d9: Emit connectionDied on all Wayland connections of plugins on teardown (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6571?vs=172

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103497 --- So can we commit this then? - Albert Astals Cid On Dec. 2

D6952: Properly render XWayland windows in SceneQPainter

2017-07-28 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6952#129679, @davidedmundson wrote: > Seems ok, but I'm lost as to why Xwayland clients have a different buffer size in the first place. It is due to the reparenting of the window to support window decorations. The actual

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote: > > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components > > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks > > Is this fixed? no, that's the probl

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread David Edmundson
davidedmundson added a comment. > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks Is this fixed? Also we'll need to maybe look at changing how kirigami does its theme stuff so we can make t

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin
mart updated this revision to Diff 17325. mart added a comment. comment useless debug REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17324&id=17325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED FI

D6964: Force Plasma style for QQC2 in applets

2017-07-28 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY using the qml url interceptor, rewrite imports in order to load always the plasma styled qqc2 controls in plasmoids and

Re: Re: DrKonqi dependencies

2017-07-28 Thread David Edmundson
​Please can someone review kde:scratch/davidedmundson/drkonqi David

D6952: Properly render XWayland windows in SceneQPainter

2017-07-28 Thread David Edmundson
davidedmundson added a comment. Seems ok, but I'm lost as to why Xwayland clients have a different buffer size in the first place. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6952 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin,

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-28 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R108 KWin BRANCH connection-cleanup REVISION DETAIL https://phabricator.kde.org/D6571 To: graesslin, #kwin, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Re: Review Request 130206: systemsettings tooltip items non italic

2017-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130206/#review103489 --- Ship it! Ship It! - Sebastian Kügler On July 26, 2017,

Re: Review Request 130205: View Styles

2017-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/#review103488 --- Why? The mode chooser is hidden well enough that it doesn't

D6946: Emit connectionDied if the QPA is destroyed

2017-07-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:7dd186258620: Emit connectionDied if the QPA is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6946?vs=17273&id=17311 REVI

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:b669d4148a39: Destroy all kwayland objects created by registry when it is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D67

D6763: Fix app icon button in window decos with high DPI in previews.

2017-07-28 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R31:e827fa080137: Fix app icon button in window decos with high DPI in previews. (authored by davidedmundson). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6763?vs=16851

D6957: Add link about additional configuration option to baloo kcm docbook

2017-07-28 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6957 To: lueck, #documentation, #plasma, aacid Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D3484: Center systemmonitor window properly on multi-screen setup

2017-07-28 Thread Albert Astals Cid
aacid added a comment. Should we commit this then? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 To: valeriymalov, #plasma_workspaces, aacid, mart Cc: davidedmundson, sebas, aacid, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,