D6792: Make sure the dbus xml interface file exists before it's used

2017-07-21 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R101:db3a04289d0f: Make sure the dbus xml interface file exists before it's used (authored by heikobecker). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6792?vs=16934

D6811: Use std::bind expression for Workspace::slotWindowtoDesktop

2017-07-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. BRANCH slot-window-to-desktop-std-bind REVISION DETAIL https://phabricator.kde.org/D6811 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D6631: Fix compilation with strict libc (such as musl)

2017-07-21 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D6631#126937, @bcooksley wrote: > Sorry, looks like it's still unhappy (another different error). This time it's complaining about gettimeofday() > According to https://github.com/kinetiknz/cubeb/issues/6 defining XOPEN_SOURCE will

D6818: Implement support for window shortcuts for Wayland windows

2017-07-21 Thread Martin Flöser
graesslin added a comment. FYI: I figured out why the shortcut dialog does not work. It's an incorrect construction of the QKeyEvent which KWin uses internally and sends to QWindows and various other places. We convert the current key symbol to Qt:: Key and when a modifier key is released th

D6818: Implement support for window shortcuts for Wayland windows

2017-07-21 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Moves most of the implementation from Client to AbstractClient, so that it can be used for both Client and ShellClient. Only the X11 spe

D6813: Use customized font size for Digital Clock applet

2017-07-21 Thread Yunhe Guo
guoyunhe added a comment. In https://phabricator.kde.org/D6813#127279, @davidedmundson wrote: > Thanks, FYI we've had another review with the same change this week: https://phabricator.kde.org/D6764 Good to know 😃 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://pha

D6813: Use customized font size for Digital Clock applet

2017-07-21 Thread David Edmundson
davidedmundson added a comment. Thanks, FYI we've had another review with the same change this week: https://phabricator.kde.org/D6764 There's some comments there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6813 To: guoyunhe, #plasma_workspaces Cc

D6792: Make sure the dbus xml interface file exists before it's used

2017-07-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R101 KHotKeys BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6792 To: heikobecker, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen

D6813: Use customized font size for Digital Clock applet

2017-07-21 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY > This patch is not tested! I have some trouble to compile or run Plasma Workspace. Hope someone could help me test or give some build/test i

D6811: Use std::bind expression for Workspace::slotWindowtoDesktop

2017-07-21 Thread Martin Flöser
graesslin added a dependency: D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument. REVISION DETAIL https://phabricator.kde.org/D6811 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6783: Replace Workspace::slotWindowQuickTileFoo by a quickTileWindow with argument

2017-07-21 Thread Martin Flöser
graesslin added a dependent revision: D6811: Use std::bind expression for Workspace::slotWindowtoDesktop. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6783 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jen

D6811: Use std::bind expression for Workspace::slotWindowtoDesktop

2017-07-21 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way we don't need the sender() hack to get the value set on the QAction. TEST PLAN New autotest in master still passes BRANCH sl

[Powerdevil] [Bug 378498] Power settings missing scrollbar

2017-07-21 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=378498 Sebastian Kügler changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED

D6801: Replace delegate slots for window shortcut by std::bind expressions

2017-07-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH useractions-client-shortcut-simplify REVISION DETAIL https://phabricator.kde.org/D6801 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwol

D6688: Adjusted Scrollbars

2017-07-21 Thread David Edmundson
davidedmundson closed this revision. davidedmundson added a comment. Pushed https://commits.kde.org/breeze-gtk/01a86601804222929441c0c1c8bb0db6d4ee2769 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D6688 To: davidedmundson, mart, LordTermor Cc: davidedmundson

D6688: Adjusted Scrollbars

2017-07-21 Thread David Edmundson
davidedmundson commandeered this revision. davidedmundson added a reviewer: LordTermor. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D6688 To: davidedmundson, mart, LordTermor Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu