D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:bea87753629e: [client] Properly track enteredSurface in Keyboard (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6741?vs=16786&id=16797 RE

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Christoph Feck
cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH aurorae-support-shaded REVISION DETAIL https://phabricator.kde.org/D6719 To: graesslin, #kwin, #plasma, cfeck Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-moham

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > cfeck wrote in aurorae.cpp:407 > Do you remember why the other connection needed to be queued? Yes, when maximizing it can happen that the deco gets destroyed. It would act like a delete this without the queued connection. With shade this canno

D6746: Fix check for missing engine in comic applet

2017-07-16 Thread Anthony Fieroni
anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6746 To: davidedmundson, #plasma, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > aurorae.cpp:407 > connect(client().data(), > &KDecoration2::DecoratedClient::maximizedChanged, this, > &Decoration::updateBorders, Qt::QueuedConnection); > +connect(client().data(), &KDecoration2::DecoratedClient::shadedChanged, > this, &

D6746: Fix check for missing engine in comic applet

2017-07-16 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Current code would check the comic engine was not installed and not create the download dialog, but would still always try to show it.

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH keyboard-entered-surface-cleanup REVISION DETAIL https://phabricator.kde.org/D6741 To: graesslin, #frameworks, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwol

D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6734#125925, @davidedmundson wrote: > Sort of offtopic: are you aware of the new(ish) QOpenGLContext::setNativeHandle() theoretically we can just wrap kwin's existing OpenGL context and not have to actually switch contexts. >

D6630: [kstyle] Do not delete the Surface for a QWindow

2017-07-16 Thread Martin Flöser
graesslin closed this revision. graesslin added a comment. https://commits.kde.org/breeze/e02fef0883af3d3b33ce8a9ea8677c82c1973975 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6630 To: graesslin, #plasma, mart, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, le

D6741: [client] Properly track enteredSurface in Keyboard

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ASAN found a heap-use-after-free when deleting the focused keyboard surface in the client library. Keyboard did not t

D6735: [platforms/x11] Quit the OpenGL Freeze protection thread on shutdown

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Weird NVIDIA behavior fixup part 2. Now that we do no longer freeze when NVIDIA decides to create an OpenGL error on startup (https://

D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-16 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Sort of offtopic: are you aware of the new(ish) QOpenGLContext::setNativeHandle() theoretically we can just wrap kwin's existing OpenGL context and not have to actually swi

D6734: [qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context

2017-07-16 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Introduces a few more attributes needed for creating the OpenGL context used by the QPA. TEST PLAN Extended test and run KWin/Wayland

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote: > We still need https://phabricator.kde.org/D6571, with my proposed change. That's a special case where we delete the connection before the QPA. It might be that we don't need it. Also K

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-16 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:98e5d269a110: [server] Send keyboard leave when client destroys the focused surface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6683?vs=16755&id=16775#toc REPOSITOR

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread David Edmundson
davidedmundson added a comment. We still need https://phabricator.kde.org/D6571, with my proposed change. That's a special case where we delete the connection before the QPA. My added connect means that we get that signal regardless of whether we're in Kwin or not. What we wouldn't ne

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Martin Flöser
graesslin updated this revision to Diff 16774. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. New approach to the problem REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6719?vs=16748&id=16774 BRANCH aurorae-su

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-16 Thread Martin Flöser
graesslin added a comment. I like the idea! That would basically allow us to abandon https://phabricator.kde.org/D6571 and would also solve the issues we see with the kwayland-integration plugin which can crash applications on exit. May I ask for a small unit test for the new functionali

D6718: Fix occasional abort in the krunner plugin

2017-07-16 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D6718#125807, @davidedmundson wrote: > This shouldn't be needed. > Even an empty QList will have an argument of that empty QList and errors will have a different type. I thought so too, until I got crashes without the test.

D3805: Per-activity favorites (Final, again?)

2017-07-16 Thread Eike Hein
hein added a comment. I'm on vacation Mon-Wed and then travelling. I don't know yet when I can test again. I'm currently wary of touching my system too much because I need it to stay reliable as a demo machine for my presentation. If someone else can test for the crash using the steps above,

Fwd: kubuntu 16-17, systemsettings, display with two monitors

2017-07-16 Thread Thomas Pfeiffer
Dear Plasma team, as requested, I forwarded the email below which was sent to the board mailing list to what I hope is the correct community. Cheers, Thomas -- Forwarded Message -- Subject: kubuntu 16-17, systemsettings, display with two monitors Date: Samstag, 15. Juli 2017, 1

[kio-extras] [Bug 376867] sftp connect issue "Failed to resolve hostname = (Name or service not known)"

2017-07-16 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=376867 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving th