D6718: Fix occasional abort in the krunner plugin

2017-07-15 Thread David Edmundson
davidedmundson added a comment. This shouldn't be needed. Even an empty QList will have an argument of that empty QList and errors will have a different type. It implies something is wrong elsewhere. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.k

D6717: Expose base64-encoded favicons to the tabsrunner

2017-07-15 Thread Fabian Vogt
fvogt updated this revision to Diff 16759. fvogt added a comment. Also send a request for the favicon without timeout to fill the cache for next time. Otherwise favicons from slow servers might never show up REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://p

D6727: Destroy all kwayland objects created by registry when it is destroyed

2017-07-15 Thread David Edmundson
davidedmundson created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY Currently one has to connect every object manually to connectionDied, which is something we can do fo

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-15 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in wayland_server.cpp:99 > Alternative. > > Instead of deleting qobjects > > emit c->connectionDied(); > > Clients then call destroy() on whatever objects. > They can then delete the QObjects whenever they were going to.

D6571: Delete all Wayland connections by plugins prior to own Wayland connection

2017-07-15 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > wayland_server.cpp:93 > if (m_internalConnection.client) { > +// delete all connections hold by plugins like e.g. widget style > +const auto connections = > KWayland::Client::ConnectionThread::connections(); s/hold/hel

D6719: [aurorae] Add support for shaded windows

2017-07-15 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. Unfortunately there are still themes which cause glitches. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6719 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, a

D6726: [aurorae] Mark the render QQuickWindow as frameless

2017-07-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY On Wayland aurorae was creating a lot of stress for the system and basically turning the system unusable in a short time. This was due t

[kio-extras] [Bug 376867] sftp connect issue "Failed to resolve hostname = (Name or service not known)"

2017-07-15 Thread Chris Wells
https://bugs.kde.org/show_bug.cgi?id=376867 --- Comment #3 from Chris Wells --- Created attachment 106655 --> https://bugs.kde.org/attachment.cgi?id=106655&action=edit Package changes on 2017/07/15. -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 376867] sftp connect issue "Failed to resolve hostname = (Name or service not known)"

2017-07-15 Thread Chris Wells
https://bugs.kde.org/show_bug.cgi?id=376867 --- Comment #2 from Chris Wells --- Created attachment 106654 --> https://bugs.kde.org/attachment.cgi?id=106654&action=edit Package changes on 2017/07/09. -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 376867] sftp connect issue "Failed to resolve hostname = (Name or service not known)"

2017-07-15 Thread Chris Wells
https://bugs.kde.org/show_bug.cgi?id=376867 Chris Wells changed: What|Removed |Added CC||k...@techlovers.net --- Comment #1 from Chris Wel

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH keyboard-leave-surface-destroy REVISION DETAIL https://phabricator.kde.org/D6683 To: graesslin, #frameworks, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-15 Thread Martin Flöser
graesslin updated this revision to Diff 16755. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Add nullptr check to prevent crash REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6683?vs=16661&id=16

D6683: [server] Send keyboard leave when client destroys the focused surface

2017-07-15 Thread Martin Flöser
graesslin planned changes to this revision. graesslin added a comment. Causes crash in KWayaland when closing a window. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6683 To: graesslin, #frameworks, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

D6719: [aurorae] Add support for shaded windows

2017-07-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Aurorae did not render correctly. This change addresses the problem for both maximized and restored windows. BUG: 373319 FIXED-IN

D6717: Expose base64-encoded favicons to the tabsrunner

2017-07-15 Thread Fabian Vogt
fvogt added a comment. It could also decode the base64 data in the plasma-browser-integration-host already and send it as bytearray, I'm not sure what's simpler/better/faster. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D6717 To: fvogt, #plasma

D6718: Fix occasional abort in the krunner plugin

2017-07-15 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Sometimes the DBus reply has no arguments, so avoid trying to access them. TEST PLAN No crashes so far. REPOSITORY R856 Plasma Browser Integration BRANCH crashfix (branched from master) REVISI

D6717: Expose base64-encoded favicons to the tabsrunner

2017-07-15 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The browser has them in the cache already, so we avoid loading it ourselves, also we might not even have access to the icons from our context. Some browsers (Opera does) set the favIconUrl of the ta

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

2017-07-15 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=364642 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving th

D6714: Use same file descriptor for notification and reading

2017-07-15 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R856:b70020061b67: Use same file descriptor for notification and reading (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6714?vs=1

D6714: Use same file descriptor for notification and reading

2017-07-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R856 Plasma Browser Integration BRANCH nonbuffered (branched from master) REVISION DETAIL https://phabricator.kde.org/D6714 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, Zren

D6714: Use same file descriptor for notification and reading

2017-07-15 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Otherwise we wait for data on a different descriptor than we read from, which results in missing notifications if data lands in a buffer. TEST PLAN No modules were loaded after reloading the extens

D6711: Check for HUP/ERR/NVAL conditions on stdin

2017-07-15 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY While Qt's event loop checks for POLLHUP, it treats it exactly like POLLIN and it's not possible to retrieve that information from Qt. So in the Connection read handler it needs to be checked for

D3805: Per-activity favorites (Final, again?)

2017-07-15 Thread Ivan Čukić
ivan updated this revision to Diff 16733. ivan added a comment. This was a referse-murphy - the second I posted that I can not find the reason behind the crash, I managed. Can you try the current revision whether it crashes or not? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D380

D3805: Per-activity favorites (Final, again?)

2017-07-15 Thread Ivan Čukić
ivan added a comment. I've finally managed to reproduce the crash (clean install, clean build, clean everything). I still do not see what is the cause of it... REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

2017-07-15 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=364642 Martin Flöser changed: What|Removed |Added Summary|16.04.3: kio_sftp is fully |16.04.3: kio_sftp is broken |

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is fully and utterly broken

2017-07-15 Thread Toralf Förster
https://bugs.kde.org/show_bug.cgi?id=364642 --- Comment #7 from Toralf Förster --- (In reply to Janek Bevendorff from comment #6) > When I kill those sftp processes, I suddenly get a credentials window for a > connection I used hours ago (I remember that I needed to try several times, In the mean

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is fully and utterly broken

2017-07-15 Thread Toralf Förster
https://bugs.kde.org/show_bug.cgi?id=364642 Toralf Förster changed: What|Removed |Added Summary|16.04.3: kio_sftp is broken |16.04.3: kio_sftp is fully |

D6708: Properly swap the quick tile side when pressing the shortcut again

2017-07-15 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The quick tile shortcuts have a feature of moving the window to the next screen if one presses the same shortcut again. E.g. if a wind