davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It's used by ToolButton et al.
We install it in the theme folder, but not in the plasma components dir.
TEST PL
fvogt added a comment.
In https://phabricator.kde.org/D6634#125102, @graesslin wrote:
> In https://phabricator.kde.org/D6634#124880, @lbeltrame wrote:
>
> > openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are
available as well.
>
>
> @lbeltrame does it mean it would
LordTermor added a comment.
No, I don't have commit access (at least I don't think so since it's my first
commit).
Real name: Artem Grinev
Email: agrine...@gmail.com
There are also few bugs which affect gtk theme mimickers. I couldn't fix them
myself.
REPOSITORY
R98 Breeze for
davidedmundson added a comment.
Do you have commit access.
If not can we have your real name and email address please.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D6688
To: LordTermor, mart
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezha
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D6688
To: LordTermor, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
graesslin added a comment.
In https://phabricator.kde.org/D6634#124880, @lbeltrame wrote:
> openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available
as well.
@lbeltrame does it mean it would create problems for openSUSE or would it be
fine?
REPOSITORY
R108 KW
LordTermor created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Adjusted Scrollbars so now they fit the Qt theme
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D6688
AFFE
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930.
When Qt closes a window due to a key press
graesslin updated this revision to Diff 16660.
graesslin added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Make this compile. Looks like kdevelop fooled me and compiled KWin instead of
KWayland (that happens all the time to me)
REPOSITORY
R127
graesslin added a comment.
In https://phabricator.kde.org/D6657#124801, @mart wrote:
> does this overridex/fixes https://phabricator.kde.org/D6654?
kind of orthogonal. https://phabricator.kde.org/D6654 would be nicer if it
worked. But as long as https://phabricator.kde.org/D6654 d
sitter added a comment.
Yeah, legacy reasons. I am looking into ways to change this moving forward
though. Not sure if the cost-benefit will be reasonable, but it's on my radar
and at a glance should be doable in some form or fashion.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:a9a018589de5: Automatically install/remove/update related
refs (authored by jgrulich).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6677?vs=16647&id=16650#toc
REPOSITORY
R134 Discover Soft
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
related-refs
REVISION DETAIL
https://phabricator.kde.org/D6677
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ab
apol added a comment.
Looks good to me
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D6677
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
fvogt marked an inline comment as done.
fvogt added inline comments.
INLINE COMMENTS
> broulik wrote in ToolButtonStyle.qml:100
> `Text.StyledText`
I think the priority queue in my brain is somehow backwards
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde
fvogt updated this revision to Diff 16649.
fvogt added a comment.
Fix typo in ToolButtonStyle
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6679?vs=16648&id=16649
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6679
AFF
broulik added a comment.
+1
(for others reading this: Explicitly turning it into `StyledText` prevents
Qt's `AutoText` from deciding to use `PlainText` in some cases which will then
again look broken. Note that `StyledText` uses a basic string parser so it's
nowhere near as heavy as `Ri
fvogt created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The label text gets treated as RichText/StyledText, which is required
to display mnemonics underlined. Therefore it is necessary to ma
broulik added a comment.
> Is there any reason not to use the SPDX license IDs here?
The values are the ones in `KAboutLicense` from what I can tell.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6628
To: sebas, #plasma, sitter, mart, b
jgrulich updated this revision to Diff 16647.
jgrulich added a comment.
Cleanup commented code
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6677?vs=16645&id=16647
BRANCH
related-refs
REVISION DETAIL
https://phabricator.kde.org/D6677
mak added a comment.
Is there any reason not to use the SPDX license IDs here? =>
https://spdx.org/licenses/ (e.g. `GPL-2.0+` in this case).
In any case, this patch makes things way better, so +1 from me :-)
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabri
jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Process related refs which should be automatically installed/remove/updated
together with the
app or runtime which is being processed. This
sitter accepted this revision.
sitter added a comment.
Thanks for doing the leg work.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6628
To: sebas, #plasma, sitter, mart, broulik
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo
On Thu, Jul 13, 2017 at 1:49 PM, Marco Martin wrote:
> On Thu, Jul 13, 2017 at 11:05 AM, David Edmundson
> wrote:
>> That works fine for XDG, but wl-shellsurface doesn't like that and remains
>> until you delete the wl_surface. wl_shell_surface_destroy literally sends
>> nothing in wayland_debug.
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d8f1d44a493c: Declare AppManager.js as pragma library
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6676?vs=16643&id=1664
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> Before, I would get at least 6 instances (from various Dialogs that were
created for instance).
I doubt it, no-one uses that. Probably TabBars.
In any case, I wou
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It doesn't store any state but contains only functions.
TEST PLAN
Only one instance of this script is created in plasm
On Thu, Jul 13, 2017 at 11:05 AM, David Edmundson
wrote:
> That works fine for XDG, but wl-shellsurface doesn't like that and remains
> until you delete the wl_surface. wl_shell_surface_destroy literally sends
> nothing in wayland_debug.
>
> I think that's why they end up deleting both. It's not a
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:868d61272b2a: Allow having a header in a ListView that is
in an OverlaySheet (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D?vs=16615&id=16
lbeltrame added a comment.
openSUSE Leap 42.3 uses GCC 4.8 as default, although 5 and 6 are available as
well.
REPOSITORY
R108 KWin
BRANCH
cxx-14
REVISION DETAIL
https://phabricator.kde.org/D6634
To: graesslin, #plasma, lbeltrame, ivan
Cc: ivan, plasma-devel, kwin, #kwin, ZrenBot, pr
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We allow HTML in Notifications and QtQuick Text will even load remote images
which poses a privacy threat.
The network access manager factor
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ddc530ff14b6: [Notification Item] Enforce PlainText for
summary (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6671?vs=16629&id=1663
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6671
To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
According to specification only body text may contain HTML and this keeps
apps from screwing up the layout or even loading remote images.
TES
>IIRC wl_shell is not defined to be double buffered. Not sure how it's
about xdg. There is always the chance of breaking things *cough*Qt*cough*
when changing that - even if it is sane.
Xdg definitely is and for v7 this is important as mapping/unmapping is
different.
* committing a surface with e
broulik accepted this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6628
To: sebas, #plasma, sitter, mart, broulik
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6628
To: sebas, #plasma, sitter, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterber
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:395500244021: Use version of the Applications product
(authored by elvisangelaccio).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6642?vs=16557&id=16627#toc
REPOSITORY
R320 KIO Extras
CHA
mart added a comment.
+1 for all the ones from me
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6628
To: sebas, #plasma, sitter
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
On Thursday 13 July 2017 09:56:38 you wrote:
> with a qt more recent than https://codereview.qt-project.org/#/c/195835/
> surfacecreated events may be again sent at the right moments?
> (tough reverting https://bugreports.qt.io/browse/QTBUG-58423 would still be
> a good thing)
another good thing c
On Thursday 13 July 2017 09:56:38 you wrote:
> with a qt more recent than https://codereview.qt-project.org/#/c/195835/
> surfacecreated events may be again sent at the right moments?
> (tough reverting https://bugreports.qt.io/browse/QTBUG-58423 would still be
> a good thing)
maybe let's try a Qt
mart added a comment.
does this overridex/fixes https://phabricator.kde.org/D6654?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6657
To: graesslin, #plasma
Cc: mart, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts,
On Wednesday 12 July 2017 20:51:16 Martin Flöser wrote:
>
> You might be right. Given the output of KWin debug console all the calls
> didn't work.
>
> THIS SUCKS! So show event is too early and expose event is too late. God
> damn Qt why did you have to break this??? We had working code and now
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D
To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart
44 matches
Mail list logo
