D6612: Honour the NoDisplay attribute of KServices

This revision was automatically updated to reflect the committed changes. Closed by commit R124:85ed16cd4228: Honour the NoDisplay attribute of KServices (authored by fvogt). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6612?vs=16457&id=16487 REVISI

D6609: [Kickoff] Allow sorting favorites

hein added a comment. Please don't commit this. It conflicts with https://phabricator.kde.org/D3805. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6609 To: broulik, #plasma, #vdg, davidedmundson Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

Re: Plasma Browser Integration is in kdereview

On Tue, Jul 11, 2017 at 1:08 AM, David Edmundson wrote: > Do you know if you can me it be a bit more quiet and only output errors on >> >> failure? > > > I changed that a few weeks ago, I assume it's fine now? > > > If there are no complaints I'll move this to Plasma. +1 \o/ Aleix

D6440: [CurrentContainmentActionsModel] Allow making the action about dialog modal

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6440 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D6612: Honour the NoDisplay attribute of KServices

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D6612 To: fvogt, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je

D6609: [Kickoff] Allow sorting favorites

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6609 To: broulik, #plasma, #vdg, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6608: [PlasmaComponents Menu] Don't crash on null action

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. You've not addressed my setVisible comment. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6608 To: broulik, #plasma,

D6459: Fix the National Geographic PoTD dataengine

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I just merged https://phabricator.kde.org/D5729 which has been accepted for ages unmerged fixing this in another way. REPOSITORY R114 Plasma Addons REVISION DET

D5729: #379003: Fix National Geographic POTD provider

This revision was automatically updated to reflect the committed changes. Closed by commit R114:4ed05974c6a1: Replace XML parsing in National Geographic dataengine (authored by vitali, committed by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.k

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 David Edmundson changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #14 from Christian --- Has this patch been reviewed and been made available yet in Neon? -- You are receiving this mail because: You are the assignee for the bug.

Re: Plasma Browser Integration is in kdereview

Do you know if you can me it be a bit more quiet and only output errors on > failure? > I changed that a few weeks ago, I assume it's fine now? If there are no complaints I'll move this to Plasma.

D6615: Simplify Alternatives Dialog code

davidedmundson updated this revision to Diff 16480. davidedmundson added a comment. Simplify another line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6615?vs=16474&id=16480 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6615 A

[Powerdevil] [Bug 382105] Power devil crash dès la sortie de veille

https://bugs.kde.org/show_bug.cgi?id=382105 --- Comment #2 from kristof --- Le problème se produit à priori lorsque le portable est sur batterie -- You are receiving this mail because: You are the assignee for the bug.

D6615: Simplify Alternatives Dialog code

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Replace QObject::sender() and tracking objects in a list with a simple lambda. TEST PLAN Opened and closed dialog. REPOSITORY R120

D6614: Use new connect syntax in more places

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c00069c43db4: Use new connect syntax in more places (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6614?vs=16471&id=16472

D6614: Use new connect syntax in more places

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6614 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #fram

D6614: Use new connect syntax in more places

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Especially in frequently created items. Shoves off a couple of milliseconds of startup time. TEST PLAN - Changing the

D6581: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5cd48d672782: Fix crash in KCMKeyboardWidget::populateWithCurrentXkbOptions on Wayland (authored by graesslin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D6520: Summary: L2TP: pre-sharedkey should be mask

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c86bb0d58380: Summary: L2TP: pre-sharedkey should be mask (authored by scarpino). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6520?vs=16

D6612: Honour the NoDisplay attribute of KServices

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY kcmshell5 refuses to load modules that have this set and when clicking on them in systemsettings, an empty page with no button to go back to the overview is shown. So just don't show them to the u

D6611: Implement support for restricted move area on Wayland

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change implements a missing TODO to generate the restricted move area for windows with struts (aka panel) on Wayland. BRANCH restri

D6610: don't override paddings

This revision was automatically updated to reflect the committed changes. Closed by commit R134:c73a0f5ee543: don't override paddings (authored by mart). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6610?vs=16453&id=16454 REVISION DETAIL ht

D6610: don't override paddings

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D6610 To: mart, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha

D6610: don't override paddings

mart added a comment. F3808114: Spectacle.bh8012.png F3808117: Spectacle.UV8012.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D6610 To: mart, apol Cc: plasma-devel

D6610: don't override paddings

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY as paddings are used to indicate there should be some space made up for the scrollbar, don't overwrite them, use negative margins instead on t

D6608: [PlasmaComponents Menu] Don't crash on null action

broulik updated this revision to Diff 16452. broulik edited the summary of this revision. broulik added a comment. - For simplicitly just always delete the current action if it's ours before proceeding. Then either use the one passed in or create a new one. As a (neat) side-effect, explicitly

D6608: [PlasmaComponents Menu] Don't crash on null action

anthonyfieroni added inline comments. INLINE COMMENTS > qmenuitem.cpp:47 > +m_hasExplicitAction = true; > +delete m_action; > +m_action = nullptr; Why delete it? if (!a) { setVisible(false); return; } // m_action stays last one,

D6609: [Kickoff] Allow sorting favorites

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This brings back the ability to manually sort favorites alphabetically. BUG: 357125 FIXED-IN: 5.11.0 TEST PLAN Needs https://phabrica

D6608: [PlasmaComponents Menu] Don't crash on null action

davidedmundson added inline comments. INLINE COMMENTS > qmenuitem.cpp:29 > setAction(new QAction(this)); > +m_hasExplicitAction = false; > } Another approach I've seen done before is: if (action->parent() == this) we delete it, else it's the client's problem. IMHO cleaner, but up to

D6608: [PlasmaComponents Menu] Don't crash on null action

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY You can assign a `QAction` as "action", this way you can just pass it e.g. `plasmoid.action("configure")`. However, wh

Minutes Monday Plasma Hangout

Whoopadeedoo, this week's meeting notes! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 10-7-2017 Present: kbroulik, Sho, notmart, d_ed, bshah, sebas kbroulik: * Did some work on auto-hidden panel support, namely ensuring the panel stays open while interacting with a con

Topics for Plasma BoF at Akademy 2017

Hello plasmoids! Akademy is coming up and I thought it's good idea to start the etherpad where we can collect the ideas and topics we want to discuss at Plasma BoF at akademy. Currently room information is not available so we can't book slot but at least we can collect ideas and topics :-) https

D6554: [Plasma Dialog] Fix flag condition

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a19701c2529d: [Plasma Dialog] Fix flag conditions (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6554?vs=16444&id=16445 R

D6554: [Plasma Dialog] Fix flag condition

davidedmundson accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6554 To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D6554: [Plasma Dialog] Fix flag condition

broulik updated this revision to Diff 16444. broulik added a comment. - Fix all tooltip flag checks in dialog REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6554?vs=16309&id=16444 REVISION DETAIL https://phabricator.kde.org/D6554 AFFE

D6602: [Windowed Widgets Runner] Fix launching widget

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8c5a75341849: [Windowed Widgets Runner] Fix launching widget (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6602?vs=16440&id=16441

D6602: [Windowed Widgets Runner] Fix launching widget

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6602 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D6602: [Windowed Widgets Runner] Fix launching widget

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In https://phabricator.kde.org/R120:5dff3bc6869a14cd422d2682687b44a53a790ea7 I changed it so data contains the plugin name instead of metaData

D6550: [Task Manager] Set status to RequiresAttentionStatus while context menu is open

broulik abandoned this revision. broulik added a comment. https://phabricator.kde.org/D6577 is a better more generic approach REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6550 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D6577: Don't autohide panel if a child window is open

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6577 To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, pro

D6552: [Folder View] Replay mouse click so left button containment actions work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6f19967d6078: [Folder View] Replay mouse click so left button containment actions work (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D6552: [Folder View] Replay mouse click so left button containment actions work

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Yay down to one line :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6552 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

Re: KWin 5.10.3.1 update

¡Hola Martin! El 2017-07-09 a las 14:52 +0200, Martin Flöser escribió: If there are changes which can be backported we will do. Please do not cherry pick changes, that makes it impossible for us to ensure the quality or investigate bugs. That's not what I was trying to do here. With my Deb

D6552: [Folder View] Replay mouse click so left button containment actions work

broulik updated this revision to Diff 16434. broulik added a comment. - Re-use existing eventGenerator REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6552?vs=16330&id=16434 REVISION DETAIL https://phabricator.kde.org/D6552 AFFECTED FILES contai