mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> broulik wrote in containmentinterface.cpp:1073
> Not sure if we should use `this` (and then check `if m_containment` as
> context or `m_containment`
should be the same
RE
broulik added a comment.
In principle it works but when I unplug and plug back in AC, sometimes it
changes brightness or at least moves the brightness slider around for some
weird reason and then the brightness doesn't match the slider anymore.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:962a2e39ee7a: [qpa] Prevent crash due to Surface getting
null (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6533?vs=16258&id=16268
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:88e56f630b7e: Raise minimum required Mesa version to 10.0
(authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6462?vs=16085&id=16266
REVISION DETA
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
qpa-verify-surface-5.10
REVISION DETAIL
https://phabricator.kde.org/D6533
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezha
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:24ff93854ddc: [effects/slideback] Ignore windows which
are not in visible area (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6468?vs=16096&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:4e9456a85723: [platforms/x11] Fix incorrect screen edge
approaching with switch desktop on… (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D646
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This is a regression due to changes in Breeze to support Qt 5.8+ behavior
change. KWin's own QPA operates like < Qt 5.7 and breeze was p
graesslin added a comment.
Erm why was this pushed although it was in state changes requested?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwo
mart abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
dbusrunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma, broulik
Cc: broulik, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
davidedmundson updated this revision to Diff 16245.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
Kai's comments
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6390?vs=16231&id=16245
BRANCH
dbusrunner
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> containmentinterface.cpp:1073
> +
> +connect(desktopMenu, &QMenu::aboutToHide, m_containment, [this,
> oldStatus] {
> +m_containment->setStatus(oldStatus);
Not sure if we should use `this` (and then check `if m_containment` as context
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6523?vs=16229&id=16242
REVISION DETAIL
https://phabricator
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
please add a test case for the problem.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson, graesslin
Cc: grae
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This ensures the panel does not auto-hide then.
It also forces a re-evaluation of auto-hide status when the menu closes
davidedmundson marked 9 inline comments as done.
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in dbusrunnertest.cpp:88
> Why are you using `QString` and not `QStringLiteral` all over the place?
because it's in a test...
> broulik wrote in dbusrunner.cpp:109
> We cannot
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
mart added a comment.
In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote:
> Same question as before, what happens when we go from a theme with shadows
to a theme without?
I tried to switch back and forth several times between breeze and
keramiek(the theme linked i
broulik added a comment.
Cool stuff!
A bunch of nitpicks but then it's good to go.
INLINE COMMENTS
> dbusrunnertest.cpp:45
> +void testMatch();
> +//
> +private:
Remove
> dbusrunnertest.cpp:52
> +{
> +m_process = new QProcess(this);
> +m_process->start(QFINDTESTDATA("testre
davidedmundson added a comment.
Same question as before, what happens when we go from a theme with shadows to
a theme without?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6523
To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
davidedmundson updated this revision to Diff 16231.
davidedmundson added a comment.
Added unit test, support actions
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6390?vs=15870&id=16231
BRANCH
dbusrunner
REVISION DETAIL
https://phabricator.kde.org/D6
davidedmundson retitled this revision from "WIP: Add remote runners over DBus"
to "Add remote runners over DBus".
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D6390
To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-m
mart added a comment.
replaced by https://phabricator.kde.org/D6523
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed,
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if a plasma theme doesn't provide shadow graphics,
the buffer will be a nullptr as would be created
from an i
davidedmundson added a comment.
Buffer::Ptr ShmPool::createBuffer(const QImage& image)
{
if (image.isNull() || !d->valid) {
return QWeakPointer();
}
...
if our image is null (which it is), we get an an invalid Buffer::Ptr
Shadow::attach expects that to be val
mart added a comment.
In https://phabricator.kde.org/D6518#121981, @davidedmundson wrote:
> What if a theme only has shadow-top, but not right etc.
> (or a more likely scenario, they exist, but the metadata has them be 0px
big)
>
> What would happen if you have a theme with shadow
27 matches
Mail list logo
