mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
Looks good to me, and compiles/tests fine here. Though I'm not using it on
any hg repos so I can't actually test the new feature, but as long as it works
for you I'd say go ahead and commit.
davidedmundson updated this revision to Diff 15797.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Try to upload via arc...
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDAT
davidedmundson added a comment.
why did you chose this over overriding InstancePid in the dataengine?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6359
To: broulik, #plasma, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6359
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart,
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In plasma-browser-integration the browser window is a different PID from the
host that owns the MPris service leading to no media controls in
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ee79239a5de7: Use KRun::runApplication when possible;
split out and share more code. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D635
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6358
To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
hein updated this revision to Diff 15789.
hein added a comment.
Ref-ify.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6358?vs=15788&id=15789
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6358
AFFECTED FILES
libtaskmanag
hein updated this revision to Diff 15788.
hein added a comment.
Collapse the requestOpenUrls implementations as well; more sanity checking
for app-service-ness.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6358?vs=15787&id=15788
BRANCH
Plasma
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
I'm not particularly happy about adding more X11 code outside of
XWindowTasksModel, but it means greater code reuse (in something that
has experienced unwelcome drift before) and there's a precedent
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d1b5447f57e4: Use KRun::runApplication, add missing
KActivities::notifyAccessed calls. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:20bf7ec11458: Fix clicking outside of preview popups to
dismiss them corrupting mouse state (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.10
REVISION DETAIL
https://phabricator.kde.org/D6354
To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in xdgshell_interface.h:80
> @davidedmundson for the ping you could check the old wl_shell_surface
> implementation in KWayland.
the implementation here in xdgshell_interface is basically copied over the
kwayland wl_shell_surface.
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D6247_2
REVISION DETAIL
https://phabricator.kde.org/D6247
To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jen
hein updated this revision to Diff 15779.
hein added a comment.
Hide the popup button in nested views.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6247?vs=15778&id=15779
BRANCH
arcpatch-D6247_2
REVISION DETAIL
https://phabricator.kde.org/D62
hein requested review of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6247
To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
arcpatch-D6247_2
REVISION DETAIL
https://phabricator.kde.org/D6247
To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jen
hein updated this revision to Diff 15778.
hein added a comment.
Drop unrelated TM changes from patch.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6247?vs=15668&id=15778
BRANCH
arcpatch-D6247_2
REVISION DETAIL
https://phabricator.kde.org/D624
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Otherwise we:
- ... don't get startup notifications.
BUG:381500
- ... don't contribute data to recent/most used apps.
This is a surprisingly large oversight.
REPOSITORY
R120 Plasma
ivan updated this revision to Diff 15771.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3805?vs=12409&id=15771
REVISION DETAIL
https://phabricator.kde.org/D3805
AFFECTED FILES
applets/kicker/CMakeLists.txt
applets/kicker/package/contents/code/tools.js
applets/kicker/package/co
21 matches
Mail list logo
