luebking added inline comments.
INLINE COMMENTS
> scene_opengl.cpp:713
> +// handle shape update on case cursor image changed
> +connect(Cursor::self(), &Cursor::cursorChanged, this,
> updateCursorTexture);
> +}
You still update the cursor texture with every paint() - there
graesslin added a dependent revision: D6264: Fix switch desktop on screenedge
while resizing a Wayland window.
REPOSITORY
R108 KWin
BRANCH
fix-screenedge-window-move-5.10
REVISION DETAIL
https://phabricator.kde.org/D6257
To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, Zren
graesslin added a dependency: D6257: Fix switch desktop through edge when
moving window.
REVISION DETAIL
https://phabricator.kde.org/D6264
To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Screenedges only allows to switch desktop while moving window, not
while resizing. There was a special branch which only checked this for
https://bugs.kde.org/show_bug.cgi?id=381288
--- Comment #7 from Jens Reuterberg ---
You do have a good point. Perfect black on light-light grey is the preferred
one... (although as a print-monkey I need to say "Bright Yellow on Dark Grey"
or the other print monkeys may get angry ;) ) I worry ab
You do have a good point. Perfect black on light-light grey is the preferred
one... (although as a print-monkey I need to say "Bright Yellow on Dark Grey"
or the other print monkeys may get angry ;) ) I worry about the inverted
colour scheme though and icon effects.
I propose this - lets create
Kanedias marked 3 inline comments as done.
Kanedias added a comment.
Fixed lazy-init
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6186
To: Kanedias, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff,
lesliezhai, ali-moham
Kanedias updated this revision to Diff 1.
Kanedias added a comment.
Whoops, wrong patch
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6186?vs=15554&id=1
REVISION DETAIL
https://phabricator.kde.org/D6186
AFFECTED FILES
scene_opengl.cpp
scene_op
Kanedias updated this revision to Diff 15554.
Kanedias added a comment.
Fixes for lazy-init (thanks T.L.)
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6186?vs=15397&id=15554
REVISION DETAIL
https://phabricator.kde.org/D6186
AFFECTED FILES
autotests/cli
luebking added inline comments.
INLINE COMMENTS
> Kanedias wrote in scene_opengl.cpp:734
> You mean, to check whether BLEND was enabled prior to calling this func?
You might have to - and in addition possibly reset the actual blend function
from before. Please wait for Martins comment on this,
Kanedias added inline comments.
INLINE COMMENTS
> luebking wrote in scene_opengl.cpp:699
> The entire head should probably be in some init function, not in every paint
> call.
> If you go for a lazy init, you should seekt to prevent double connects (but I
> don't know whether Qt::UniqueConnecti
Kanedias updated this revision to Diff 15553.
Kanedias added a comment.
Fixed KWAYLAND -> Kwayland in CmakeLists.txt
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1231?vs=15125&id=15553
REVISION DETAIL
https://phabricator.kde.org/D1231
AFFECTED FILES
Kanedias added a comment.
@davidedmundson , do we really have nativeResourceForScreen call? AFAIK KWin
uses its own QPA, which implements only bits of functionality. We need to have
nativeResourceForScreen to be able to pass wl_output, should I patch QPA also,
or is there better way?
REPOSI
luebking added inline comments.
INLINE COMMENTS
> scene_opengl.cpp:699
> +// don't paint if no image for cursor is set
> +const QImage img = kwinApp()->platform()->softwareCursor();
> +if (img.isNull()) {
The entire head should probably be in some init function, not in every paint
c
Kanedias marked an inline comment as done.
Kanedias added a comment.
@graesslin , are you here? Can you look at this submission please if you have
time?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6186
To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin,
graesslin added a comment.
In https://phabricator.kde.org/D6258#117243, @fvogt wrote:
> What about the 5.8 branch? I'm not aware of any distros that use it with Qt
5.9, but IMO it needs to be fixed there as well.
I think it is not reasonable for a distribution to keep Plasma on LT
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
If the keymap cannot be created a few pointers in Xkb are null.
We should make sure to not call any xkbcommon functions on those
null
broulik added inline comments.
INLINE COMMENTS
> FolderItemDelegate.qml:119
> } else if (!hovered) {
> if (popupDialog != null) {
> +closePopup();
This check is now superfluous as it's also done in `closePopup()`
REPOSITORY
R119 Pl
fvogt added a comment.
What about the 5.8 branch? I'm not aware of any distros that use it with Qt
5.9, but IMO it needs to be fixed there as well.
REPOSITORY
R108 KWin
BRANCH
fix-grab-root-window-5.10
REVISION DETAIL
https://phabricator.kde.org/D6258
To: graesslin, #kwin, #plasma, b
https://bugs.kde.org/show_bug.cgi?id=352497
Sebastian Kügler changed:
What|Removed |Added
Assignee|plasma-devel@kde.org|plasma-b...@kde.org
--
You are receiving th
https://bugs.kde.org/show_bug.cgi?id=381288
Nate Graham changed:
What|Removed |Added
Status|RESOLVED|UNCONFIRMED
Resolution|WONTFIX
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
fix-screenedge-window-move-5.10
REVISION DETAIL
https://phabricator.kde.org/D6257
To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, leslie
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Fixes keyboard nav in present windows for me
REPOSITORY
R108 KWin
BRANCH
fix-grab-root-window-5.10
REVISION DETAIL
https://phabricator.kde.org/D6258
To: graesslin, #kwin, #plasma,
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
With qtbase 2b34aefcf02f09253473b096eb4faffd3e62b5f4 we do no longer get
events reported for the X11 root window. Our keyboard handling
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
There was a regression introduced in ScreenEdges when introducing the
activatesForPointer method. It considered the switch desktop on ed
I have to agree with Sebas here: the choice is a "damned if you do, damned if
you don't level" - the harsh contrasts would make many users feel as if the
experience is worse...
I am not trying to wave you away of course - you are more than right there are
many users who find the theme too vagu
https://bugs.kde.org/show_bug.cgi?id=381288
--- Comment #5 from Jens Reuterberg ---
I have to agree with Sebas here: the choice is a "damned if you do, damned if
you don't level" - the harsh contrasts would make many users feel as if the
experience is worse...
I am not trying to wave you away
Yes that was a worry of mine too - that certain people in the community would
use the vision as a club against developers but then I thought that the issue
there isn't so much the vision - its the person using it as a club.
Any vision can be used as a club, every statement of intent, even now wh
https://bugs.kde.org/show_bug.cgi?id=381288
Sebastian Kügler changed:
What|Removed |Added
CC||se...@kde.org
Status|UNCONFIRMED
I will add all these as notes on Phabricator task as well - keep the ideas
coming everyone its golden so far!
On Friday, 16 June 2017 01.27.42 CEST Aleix Pol wrote:
> On Thu, Jun 15, 2017 at 9:16 PM, Martin Flöser wrote:
> > Am 2017-06-12 01:19, schrieb Aleix Pol:
> >> On Sun, Jun 11, 2017 at 1
30 matches
Mail list logo
