D6106: [Notifications Data Engine] Expose desktop entry and application service name icon

2017-06-05 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Now that we have "desktop-entry" available, expose this information in the data engine. This could enable a notification implementation to s

D6105: [Notification Job Delegate] Slightly optimize summary label

2017-06-05 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of splitting, just use lastIndexOf and slice. This is 2x as fast. TEST PLAN Still shows only file name, I didn't check but I verif

D6059: Add a test that adds a notification and closes it

2017-06-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ec31a507275c: Add a test that adds a notification and closes it (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6059?vs=15187&id=15188

D6059: Add a test that adds a notification and closes it

2017-06-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D6059_1 REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, broulik, davidedmundson Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, p

D6059: Add a test that adds a notification and closes it

2017-06-05 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 15187. apol added a comment. Rebase to Plasma/5.10 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6059?vs=15186&id=15187 BRANCH arcpatch-D6059_1 REVISION DETAIL https://phabricator.kde.org/D6059 AFFECTED FI

D6059: Add a test that adds a notification and closes it

2017-06-05 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 15186. apol added a comment. Fix logic REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6059?vs=15069&id=15186 BRANCH arcpatch-D6059_1 REVISION DETAIL https://phabricator.kde.org/D6059 AFFECTED FILES applet

D5957: Don't ignore initially selected mime type filter

2017-06-05 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R135:267e7c635733: Don't ignore initially selected mime type filter (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5957?vs=14797&id=15183#toc REPOSITORY R135 Integr

Re: Distro integration for Plasma Browser Integration (was: Re: Plasma Browser Integration is in kdereview

2017-06-05 Thread David Edmundson
> > What options are possible to distribute extensions via distro packaging? > For chrome see https://developer.chrome.com/extensions/external_extensions. For firefox I was under the impression you can't, but I haven't extensively looked. But the easiest thing to do is see how chrome-gnome-shell

Distro integration for Plasma Browser Integration (was: Re: Plasma Browser Integration is in kdereview

2017-06-05 Thread Martin Steigerwald
Hello David. Thanks for your effort on plasma browser integration. I am unsure whether to keep CC to kde-core-devel and plasma-devel, please drop as you deem appropriate. Keeping all text for reference for those that only read distributions mailing list. David Edmundson - 05.06.17, 15:42: > He

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-06-05 Thread Vadym Krevs
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #31 from Vadym Krevs --- (In reply to David Faure from comment #29) > ... with which protocol exactly? smb for me. 1. Add an SMB share to "Places" in Dolphin. 2. Select any local file in HOME, right-click and select Copy or Cut. 3. Click

Re: Plasma Browser Integration is in kdereview

2017-06-05 Thread Luca Beltrame
In data lunedì 5 giugno 2017 16:42:34 CEST, David Edmundson ha scritto: > - chrome also has a feature where we can ship a text file on the distro > side that will make the browser automatically fetch an extension from their > store. You may need to ask distributions if they are OK with it. Also

Plasma Browser Integration is in kdereview

2017-06-05 Thread David Edmundson
Hey all, We'd like to add project plasma-browser-integration into KDE[0]. The goal is to make chrome and firefox integrate better into a Plasma desktop environment through browser extensions. How?: Firefox and chrome (and potentially others) allow plugins to talk to a native binary host [1]. Thi

D6026: Add setScale option to kscreendoctor

2017-06-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R110:bede0b95f7e7: Add setScale option to kscreendoctor (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6026?vs=14981&id=15171#toc REPOSITORY R110 KScreen Library CH

D5791: Allow to disable blinking cursor completely

2017-06-05 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D5791 To: kfunk, mck182, graesslin, broulik Cc: kossebau, plasma-devel, ZrenBot, spstarr, pr

D5791: Allow to disable blinking cursor completely

2017-06-05 Thread Kevin Funk
kfunk added a comment. FTR, some links: http://git.net/ml/kwrite-devel/2015-05/msg00016.html https://superuser.com/questions/546426/how-to-disable-blinking-cursor-in-opensuse-12-2-kde-virtualbox REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL

Kirigami in Frameworks

2017-06-05 Thread Marco Martin
Hi all, The Kirigami component set always was targeted to be eventually released as a framework, ideally tier 1. since a framework must depend at most from 2 Qt releases before the current one, it couldn't be released there yet. Now that Qt 5.9 is released, i would like to propose to move Kirigam

D6100: Only enable MPRIS global shortcuts on demand

2017-06-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7bd909fa3a4f: Only enable MPRIS global shortcuts on demand (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6100?vs=15163&id=15

D6035: Force KAccess to run under XCB

2017-06-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c75338d4a57c: Force KAccess to run under XCB (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6035?vs=14997&id=15166 REVISION DE

D5989: Disable session restoration in kaccess

2017-06-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2bd5eb446cb2: Disable session restoration in kaccess (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5989?vs=14885&id=15167 REV

D4972: Start drag with press and hold on touch events

2017-06-05 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. good idea! REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma, mart Cc: mart, hein, broulik, plasma-devel, #framewo

D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell

2017-06-05 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D6100 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6095 To: broulik, #plasma Cc: mvourlakos, Zren, davidedmundson, plasma-devel, ZrenBot, spstarr, progwol

D5989: Disable session restoration in kaccess

2017-06-05 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5989 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreute

D5791: Allow to disable blinking cursor completely

2017-06-05 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R135:4be9b478e529: Allow to disable blinking cursor completely (authored by kfunk). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5791

D6026: Add setScale option to kscreendoctor

2017-06-05 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > doctor.cpp:227 > +} else if (ops.count() == 4 && ops[2] == > QStringLiteral("scale")) { > +int scale = ops[3].toInt(&ok); > +

D6100: Only enable MPRIS global shortcuts on demand

2017-06-05 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Good idea. I'm somewhat concerned by the fact that media controller applet only loads when you have an mpris service running and then we have applications like Amarok that also try to reg

D5791: Allow to disable blinking cursor completely

2017-06-05 Thread Kevin Funk
kfunk added a comment. @Plasma devs: Comments? There are some users out there who'd like to see this feature. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5791 To: kfunk, mck182, graesslin Cc: kossebau, plasma-devel, ZrenBot,

D6035: Force KAccess to run under XCB

2017-06-05 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ugh.. but yep, makes sense :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6035 To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, Zr

D2173: WIP: New System Settings delegate design

2017-06-05 Thread David Edmundson
davidedmundson abandoned this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D2173 To: davidedmundson, #plasma Cc: broulik, colomar, jensreuterberg, ivan, mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, lu

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2017-06-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: anthonyfieroni, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, al

D6100: Only enable MPRIS global shortcuts on demand

2017-06-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The lockscreen uses the MPRIS dataengine. This leads to two applications registring the service using the same component name which le

D6047: WIP: Support XDG v6

2017-06-05 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > mart wrote in xdgshell_interface.h:80 > so storing all the ids of pings in progress somewhere to make a more recent > ping not cancel an older one still pending? from kwin, client.cpp: i guess that's the kwin part that will have to use this. it uses

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-06-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #30 from johan.claudebreunin...@gmail.com --- The protocol is MTP. With the an up to date Arch Linux install. -- You are receiving this mail because: You are the assignee for the bug.

D6059: Add a test that adds a notification and closes it

2017-06-05 Thread Aleix Pol Gonzalez
apol added a comment. Now it's just adding a test, it should be a straightforward review... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, broulik Cc: mart, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D5768: Use the first thumbnail as icon for KNS resources

2017-06-05 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:05e780a32f21: Use the first thumbnail as icon for KNS resources (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5768?vs=14291&i

Minutes Monday Plasma Meeting

2017-06-05 Thread Marco Martin
bshah: - [Halium] Worked on plasma mobile rootfs image based on halium - [Halium] Tested on Nexus 5 hammerhead, and there are at least no regressions - [Halium] Cool bit about is, since halium works on fairphone 2, Plasma mobile also works on fairphone2 \o/ - [Halium] Fancy things : https://twit

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-06-05 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #29 from David Faure --- ... with which protocol exactly? -- You are receiving this mail because: You are the assignee for the bug.

D6099: Fix Aurorae decorations with non integer DPI

2017-06-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R108:5091feb8f603: Fix Aurorae decorations with non integer DPI (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6099?vs=15155&id=15158 REVISIO

D5910: make shadows work on wayland

2017-06-05 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R31:d4940fe692c7: make shadows work on wayland (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5910?vs=15156&id=15157 REVISION DETAIL https://phabric

D5910: make shadows work on wayland

2017-06-05 Thread Marco Martin
mart updated this revision to Diff 15156. mart added a comment. - use a const_iterator REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5910?vs=14839&id=15156 BRANCH arcpatch-D5910 REVISION DETAIL https://phabricator.kde.org/D5910 AFFECTED FILES kstyle

D6099: Fix Aurorae decorations with non integer DPI

2017-06-05 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. +1, this should fix https://bugs.kde.org/show_bug.cgi?id=380524 sorry for the introduced bug REPOSITORY R108 KWin BRANCH xdgv6 REVISION DETAIL https://phabricator.kde.org/D6099 To: dav

D6099: Fix Aurorae decorations with non integer DPI

2017-06-05 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY As noted by Thomas L we're casting the scaleFactor to an int far too early, which in the worst case means we end up with Auro

D5114: support for high dpi in aurorae

2017-06-05 Thread David Edmundson
davidedmundson added a comment. > bonus points if the dpi is calculated as mean of dpiX and dpiY. Maybe, but it's more important that it matches what frameSvg is doing which is currently :src/declarativeimports/core/units.cpp:const qreal dpi = primary->logicalDotsPerInchX(); If it'

D1230: GBM remote access support for KWin

2017-06-05 Thread David Edmundson
davidedmundson added a comment. There is one issue we need to work out how to fix - with this system if you're running VNC you won't see the client's mouse. For VNC it's not a huge problem as you can see your own mouse, for screen recording it makes it useless. As I see it there are

D1230: GBM remote access support for KWin

2017-06-05 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > egl_gbm_backend.cpp:158 > +{ > +bool supportRemotePresent = false; > +const QByteArray remoteOption = qgetenv("KWIN_REMOTE"); you can do bool fo

D6095: [MPRIS Data Engine] Only register global shortcuts when loaded in plasmashell

2017-06-05 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D6095#114166, @Zren wrote: > Hmm, just of this after reading a comment on reddit. Latte-Dock uses another process, would this cause keyboard shortcuts to not work for it? I'm not sure if it has a different app name. > > http