D6059: Add a test that adds a notification and closes it

2017-06-02 Thread Martin Klapetek
mck182 added a comment. That's up to Kai/VDG, I guess. I was just wondering what changed from the previous patch where everyone agreed to not do it because it would be confusing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, bro

D6003: Tell user to unlock his session only

2017-06-02 Thread Yury Kudryashov
urkud closed this revision. urkud added a comment. See commit https://phabricator.kde.org/R133:7bbafe5f80c558fbcebd081a9733f37d8753f983 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D6003 To: urkud, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, Zr

[kio-extras] [Bug 379817] Behaviour change: JPEG image preview scaled to widget size

2017-06-02 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379817 --- Comment #3 from Christoph Feck --- Alexander, could you please upload the patch using https://phabricator.kde.org/differential/diff/create/ It is missing from the link in comment #1, and it looks like reviewboard does not work; the review is not ev

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-02 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379680 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug.

D6065: Fix issue in Qt 5.7

2017-06-02 Thread Jonathan Riddell
jriddell added a comment. solves it for me in discover and systemsettings REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6065 To: apol, #kirigami, jriddell, davidedmundson Cc: plasma-devel, apol, mart

D6065: Fix issue in Qt 5.7

2017-06-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:655bdb21b918: Fix issue in Qt 5.7 (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6065?vs=15075&id=15076 REVISION DETAIL https://phabricator.k

D6065: Fix issue in Qt 5.7

2017-06-02 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D6065 To: apol, #kirigami, jriddell, davidedmundson Cc: plasma-devel, apol, mart

D6065: Fix issue in Qt 5.7

2017-06-02 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY qml parser doesn't like having namespaced object types in the declaration of a property. Use QtObject instead. BUG: 380435 TEST PLAN T

[kio-extras] [Bug 380302] smb:// KIO still tries SMBv1 first which is blocked by modern servers

2017-06-02 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=380302 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org CC|

[kio-extras] [Bug 380302] smb:// KIO still tries SMBv1 first which is blocked by modern servers

2017-06-02 Thread Waleed Hamra
https://bugs.kde.org/show_bug.cgi?id=380302 Waleed Hamra changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED

D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario

2017-06-02 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D6063 REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6046 To: broulik, #plasma, #dolphin, kvermette, dfaure, graesslin, emmanuelp Cc: plasma-devel, #konqueror, ZrenBo

D6061: prototype of kactivity-based most used modules entries

2017-06-02 Thread Marco Martin
mart marked an inline comment as done. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas

D6061: prototype of kactivity-based most used modules entries

2017-06-02 Thread Marco Martin
mart updated this revision to Diff 15071. mart added a comment. - don't create services when it's not needed REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6061?vs=15056&id=15071 BRANCH mart/mostUsedModules REVISION DETAIL https://phabricator.

D6061: prototype of kactivity-based most used modules entries

2017-06-02 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ModuleView.cpp:349 > not "kcm:/" ? i seen that kicker does application:desktopfile.desktop so i did the same, but is the same in the end > davidedmundson wrote in SidebarMode.cpp:133 > Can I propose an alternative: > > At t

Re: Plasma 5.11 kickoff meeting

2017-06-02 Thread Eike Hein
I have a vacation day on the 6th (the current front-runner) as it's a national holiday here in Korea, and Monday is one in Germany, so I'd prefer if we could do it on Wednesday or so - but if the 6th ends up being selected I will try to participate from a phone at least :). Cheers, Eike

D6046: Workaround non-interactive file/places view on high dpi in multi monitor scenario

2017-06-02 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Ths hack isn't horrible (window() makes sense too), however 1. you might want to move the call to window() inside KRun itself so it applies to all apps 2. please add a link