dfaure added a comment.
Excellent finding, it helped me reduce further the most annoying Qt bug I'm
experiencing right now (in kmail)
--> https://bugreports.qt.io/browse/QTBUG-59017
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D6046
To: broulik, #plasma, #d
kossebau created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The constructor of QFlags which was intended to handle literal "0"
as commonly used indicator of no-flags-set has been
Hey,
Anybody knows if it's possible not to show the touchpad KCM at all if
it's not available? It's a bit odd to get it but see it all gray with
an error saying "touchpad not found".
FWIW this is an issue present in the KDE Slimbook.
Aleix
apol added a comment.
Yes sure.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6041
To: apol, #frameworks, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg
davidedmundson updated this revision to Diff 15020.
davidedmundson added a comment.
Arc didn't work, I think it was too big.
Manually uploading the patch did.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6047?vs=15013&id=15020
REVISION DETAIL
https://phabricator.kde.org/D6047
davidedmundson added a comment.
but as you say, we should never be in here, that's the entire sentiment of
the comment above here.
// Since we haven't been able to figure out the reason why
// this happens, we are adding this debug code to try to
// figure out how this happened.
This revision was automatically updated to reflect the committed changes.
Closed by commit R318:883b908b4b26: Revert "Increase smooth scrolling animation
duration from 100 to 300 ms and set… (authored by elvisangelaccio).
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7df184afa19f: [xembedsniproxy] Fix check whether to use
XTest (authored by wbauer).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6048?vs=15014&id=15017
lukas added a comment.
Works fine for me in general, with 2 caveats:
- the brightness change doesn't animate (but afaik that's expected)
- when switching back to AC, the brightness isn't restored (stays at the
previous "battery" level)
REPOSITORY
R122 Powerdevil
REVISION DETAIL
ht
wbauer added a comment.
In https://phabricator.kde.org/D6048#113217, @davidedmundson wrote:
> > Btw, I think the whole fix should probably be backported to 5.8 too...
>
> It introduces a new dependency :/
Really?
AFAICS it only additionaly links xembedsniproxy against XTst.
davidedmundson added a comment.
> Is it ok to commit it to the 5.10 branch as well?
Yes
> Btw, I think the whole fix should probably be backported to 5.8 too...
It introduces a new dependency :/
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6
davidedmundson added a comment.
Can we wait till after the next release is tagged as that's super soon and
this isn't that important.
We've had major bugs porting stuff in this area before.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.
wbauer added a comment.
Is it ok to commit it to the 5.10 branch as well?
Btw, I think the whole fix should probably be backported to 5.8 too...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6048
To: wbauer, #plasma, davidedmundson
Cc: plasma-devel, Z
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6041
To: apol, #frameworks, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, al
apol marked 2 inline comments as done.
apol added inline comments.
INLINE COMMENTS
> mart wrote in appletquickitem.h:105
> despite the warning in the header, this ended up being an exported symbol, so
> binary compatibility rules apply here too.
> Plasma::Package appletPackage() const; has to st
apol updated this revision to Diff 15015.
apol marked an inline comment as done.
apol added a comment.
Address Marco's comments
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6041?vs=15003&id=15015
BRANCH
master
REVISION DETAIL
http
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Oh you hero!
I can't believe I wrote the code, tested it, then failed when putting it
together.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.k
wbauer created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Because of C++'s operator precedence, '!' logically negated all_event_masks
only instead of the whole expression.
This resulted in the condit
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R318 Dolphin
BRANCH
Applications/17.04
REVISION DETAIL
https://phabricator.kde.org/D5883
To: elvisangelaccio, #vdg, #plasma, emmanuelp, davidedmundson
Cc: plasma-devel, #konqueror, #dolphin,
elvisangelaccio added a comment.
Ping?
I'm going to push before the 17.04.2 tag, unless there are objections.
(for the record, https://codereview.qt-project.org/#/c/195712/ will make this
feature configurable).
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D5
davidedmundson abandoned this revision.
davidedmundson added a comment.
Flipping phabricator...
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6047
To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jen
davidedmundson created this revision.
davidedmundson added projects: Plasma on Wayland, Frameworks.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REVISION SUMMARY
To move forward faster I thought we could start reviewing the
davidedmundson/xdgv6 branch for the
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: Konqueror, plasma-devel.
REVISION SUMMARY
See linked bug report and comment in the code for more explanation.
CHANGELOG: Fixed issue where file area would become inaccess
I've made a second testing release of Plasma Vault
https://download.kde.org/unstable/plasma-vault/plasma-vault-5.9.96.tar.xz
autographed by me
Key fingerprint = 2D1D 5B05 8835 7787 DE9E E225 EC94 D18F 7F05 997E
It includes a fix to show an error if the encryption process stopped
Jonathan
This revision was automatically updated to reflect the committed changes.
Closed by commit R107:38ff660bb81c: Handle differences in PAM headers (authored
by adridg).
REPOSITORY
R107 KWallet PAM Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6000?vs=14912&id=15009
REVISIO
jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.
doesn't break the build on Neon
REPOSITORY
R107 KWallet PAM Integration
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6000
To: adridg, jriddell, #plasma
Cc: plasma-
davidedmundson abandoned this revision.
davidedmundson added a comment.
I was hoping to put anything that affected v5 in a separate commits, with v6
separate, but that didn't really happen.
Will include with the other stuff.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricat
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pluginloader.h:208
> + **/
> +PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const
> QString &mimetype);
> +
wow, phab isn't that smart in
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:695f24fb522a: Don't leak MimeData object (authored by
davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6017?vs=14959&id=15008
REVISION DETAIL
hein accepted this revision.
hein added a comment.
Sounds good
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart, hein
Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohame
davidedmundson added a comment.
> So you're cleaning up the leak the next time the getter is accessed?
No? If it's accessed again m_data is not null so we don't get in that branch
The main cleanup is implicitly in the DeclarativeDropEvent destructor
REPOSITORY
R296 KDeclarative
BR
hein added a comment.
So you're cleaning up the leak the next time the getter is accessed? What if
this never happens?
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart
Cc: hein, plasma-devel, #frameworks, Z
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed
33 matches
Mail list logo
