D5381: Add brightness control using ddcutil lib

davidedmundson added a comment. What's the current status of this? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D5381 To: dvogel, broulik Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5926: Remove filename from source/dest fields in job notification

davidedmundson added a comment. ...and we have the filename just above it, making this duplicate information. Kinda makes sense then. Can we you do this in kuiserverengine.cpp instead? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5926 To: droserasp

D5870: Match subsequences in application runner

davidedmundson added a comment. Do you have commit access? REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma, davidedmundson Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas

D5933: We should not forget the launchers that are not currently shown

hein added a comment. Since I'm not available on tagging day and was concerned about missing this fixed, I put it into the 5.9 and 5.10 branches myself now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5933 To: ivan, hein, mart Cc: plasma-devel, ZrenBot,

D5912: minimize dialog resizes/moves

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #fr

D5932: KCM for controlling Night Color

lueck added inline comments. INLINE COMMENTS > subdiff wrote in CMakeLists.txt:2 > Ah, that's what these mysterious Messages.sh files everywhere are for. ;) > > Is the Messages.sh right this way? > > #! /usr/bin/env bash > $XGETTEXT `find . -name "*.qml"` -o $podir/kcm_nightcolor.pot You n

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a0dee59dcf28: Implement the new panel icon size ceiling also for Input Method Panel. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D5912: minimize dialog resizes/moves

davidedmundson added a comment. Offtopic, but in future can you adjust the summary when rewriting a patch rather than leaving a comment, it's easier to read. Phab still keeps the history if we need it. So this is for fixing when we have a mainItem whose size is bigger/smaller than its o

D5953: Implement the new panel icon size ceiling also for Input Method Panel.

hein added a comment. Superceded by https://phabricator.kde.org/D5962 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5953 To: hein, #plasma, xuetianweng, mart, broulik Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab

D5953: Implement the new panel icon size ceiling also for Input Method Panel.

hein abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5953 To: hein, #plasma, xuetianweng, mart, broulik Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Works well and much better than my patch. Only thing is: If I add kimpanel as a desktop widget and make it bigger, the icons stack in a vertical column by default. Might be nicer to go hori

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

xuetianweng updated this revision to Diff 14812. xuetianweng added a comment. inPanel is not used. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5962?vs=14811&id=14812 BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5962 AFFEC

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

xuetianweng created this revision. xuetianweng added a project: Plasma. REVISION SUMMARY It was done for various other applets but not this. BUG:378443 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5962 AFFECTED FILES applets/kimp

D5748: workaround for correct wayland positioning

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D5748 REVISION DETAIL https://phabricator.kde.org/D5748 To: mart, #plasma, #plasma_on_wayland, davidedmundson Cc: hein, davidedmundson, graesslin, plasm

D5912: minimize dialog resizes/moves

broulik added inline comments. INLINE COMMENTS > dialog.cpp:487 > +} > +Q_ASSERT(mainItem); > +Q_ASSERT(mainItemLayout); Those asserts are redundant now REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein, davide

D5912: minimize dialog resizes/moves

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in tooltipdialog.cpp:45 > Calling set flags explicitly and set type explicitly is conflicting. now just uses settype, tested on x11, still works and tooltip windows still has _NET_WM_WINDOW_TYPE_TOOLTIP settype is needed in wayl

D5912: minimize dialog resizes/moves

mart updated this revision to Diff 14809. mart added a comment. - use settype, not setflags REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14690&id=14809 BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D591

D5748: workaround for correct wayland positioning

mart added a comment. In https://phabricator.kde.org/D5748#111625, @hein wrote: > Did we do the 5.7 test? ah, i understood David did, sorry REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5748 To: mart, #plasma, #plasma_on_wayland Cc: hein, davi

D5758: wire up requestToggleKeepAbove/below

hein added a comment. Remember there's also a kwin side to this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5758 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, je

D5912: minimize dialog resizes/moves

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tooltipdialog.cpp:45 > setLocation(Plasma::Types::Floating); > +setType(Dialog::WindowType::Tooltip); > Calling set flags explicitl

D5748: workaround for correct wayland positioning

hein added a comment. Did we do the 5.7 test? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5748 To: mart, #plasma, #plasma_on_wayland Cc: hein, davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5912: minimize dialog resizes/moves

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/dialogresize REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, prog

D5748: workaround for correct wayland positioning

mart added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5748 To: mart, #plasma, #plasma_on_wayland Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas,

D5912: minimize dialog resizes/moves

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, luka

D5758: wire up requestToggleKeepAbove/below

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2cdd97c68544: wire up requestToggleKeepAbove/below (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5758?vs=14264&id=14808 REVISION DETA

D5757: add requestToggleKeepAbove/below

This revision was automatically updated to reflect the committed changes. Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14582&id=14807 REVISION DETAIL https:/

D5933: We should not forget the launchers that are not currently shown

hein added a comment. Is there a reason why this wasn't committed to the 5.10 branch yet? This is a critical fix and we're tagging tomorrow. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5933 To: ivan, hein, mart Cc: plasma-devel, ZrenBot, spstarr, progwo

D5950: Implement the new panel icon size ceiling also for Activities.

hein added a comment. In https://phabricator.kde.org/D5950#111476, @ivan wrote: > It would be nicer if we had a better way to do this instead of having a chunk of code copy-pasted all over the place. Agreed. Any ideas? Maybe we can implement it in IconItem somehow ... REPOSITORY

D5951: Implement the new panel icon size ceiling also for Bluetooth.

This revision was automatically updated to reflect the committed changes. Closed by commit R97:4f3998ae7914: Implement the new panel icon size ceiling also for Bluetooth. (authored by hein). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5951?vs=14788&id=1480

D5950: Implement the new panel icon size ceiling also for Activities.

hein added inline comments. INLINE COMMENTS > mart wrote in main.qml:31 > to detect if this is in a panel was intended from the beginning the > formfactor, not the location We've had this discussion on IRC before and you agreed with my reasoning as well as saying "it doesn't matter". Do you w

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Creates components so it can be integrated in any Kirigami application though. Haven't tested custom information providers yet, need to get hold

D5955: Fix compilation on CentOS 6

This revision was automatically updated to reflect the committed changes. Closed by commit R111:bb556d8cea2f: Fix compilation on CentOS 6 (authored by kfunk). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5955?vs=14798&id=14799 REVISION DETAIL ht

D5955: Fix compilation on CentOS 6

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D5955 To: kfunk, jriddell, apol Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D5955: Fix compilation on CentOS 6

kfunk updated this revision to Diff 14798. kfunk added a comment. Conditionally link to librt REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5955?vs=14795&id=14798 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5955 AFFECTED FIL

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 Sebastian Kügler changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org --- Comment #47 from Seb

D5955: Fix compilation on CentOS 6

kfunk added a comment. Alright, I now see why this is no longer required under Linux: https://stackoverflow.com/a/32649327/592636 > Since glibc 2.17, the library linking -rt is no longer required. > The clock_* are now part of the main C library. You can see the change history of glib

D5957: Don't ignore initially selected mime type filter

elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise QFileDialog::selectMimeTypeFilter() has no effect if called before show()/initializeDialog() (because the mime filters ar

D5956: Make sure we always set a default mime filter in save mode

elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KFileWidget::setMimeFilter() documentation says a default mime filter should be set if the dialog is being open in save mode. Wi

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #46 from Elvis Angelaccio --- @madcatz: it's unlikely that the bug is in Dolphin, as other kioslaves work just fine. Dolphin enables/disables the "Create New" menu depending on KFileItem::isWritable(). You may want to put some debug prints i

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

tcberner added a comment. I want to look at this some more this weekend. INLINE COMMENTS > adridg wrote in kcheckpass.c:77 > Possibly add > > #if !(HAVE_SIGNALFD_H_ || HAVE_EVENT_H) > #error > #endif > > to double-check that it's one or the other (reflecting the check in CMake) That should

D5012: Delay notifications until desktop session has loaded

fvogt added a comment. In https://phabricator.kde.org/D5012#111492, @davidedmundson wrote: > Sure, but the current state of having two notification systems was already undefined long before this patch. Two notification systems? That's not the case here as far as I can tell. >

D5950: Implement the new panel icon size ceiling also for Activities.

mart reopened this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:31 > > -Layout.minimumWidth: units.iconSizes.small > -Layout.minimumHeight: units.iconSizes.small > +readonly property bool inPanel: (plasmoid.locatio

D5955: Fix compilation on CentOS 6

kfunk added a reviewer: jriddell. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D5955 To: kfunk, jriddell Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5955: Fix compilation on CentOS 6

kfunk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Issue: processui/CMakeFiles/processui.dir/ProcessModel.cpp.o: In function `TimeUtil::systemUptimeSeconds()': ProcessModel.cpp:(.t

D5950: Implement the new panel icon size ceiling also for Activities.

mart added a comment. In https://phabricator.kde.org/D5950#111479, @mvourlakos wrote: > I hope only that the user will be able to set the panel iconsizehints to greater values than the icon theme provides, at least by editing manually the plasma files... this depends from a value

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

adridg added inline comments. INLINE COMMENTS > kcheckpass.c:77 > +#endif > > #define THROTTLE 3 Possibly add #if !(HAVE_SIGNALFD_H_ || HAVE_EVENT_H) #error #endif to double-check that it's one or the other (reflecting the check in CMake) > kcheckpass.c:384 > +EV_SET(&keventEvent[1], S

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

adridg added a comment. The recent change that uses signalfd() is a linuxism. Possibly a glibism as well. This patch introduces an alternate path for systems without signalfd(), using kevent() to do the Same Thing (tm) .. but as tcberner says, it's not been tested. Consider it a prototype.

D5012: Delay notifications until desktop session has loaded

davidedmundson added a comment. Sure, but the current state of having two notification systems was already undefined long before this patch. Undefined trumps not being a defined state of not co-installable in this case. There is a long term fix where service files will also go into /

D5951: Implement the new panel icon size ceiling also for Bluetooth.

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5951 To: hein, #plasma, mart, broulik, drosca Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, j