D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Michail Vourlakos
mvourlakos added a comment. Just to add that because of this way of implementation all plasmoids are bound totally to plasma design decisions and cant be used elsewhere e.g. Latte. So the plasmoids are bound to plasma paradigm. I hope only that the user will be able to set the panel icon

D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Ivan Čukić
ivan added a comment. It would be nicer if we had a better way to do this instead of having a chunk of code copy-pasted all over the place. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5950 To: hein, #plasma, mart, broulik Cc: ivan, plasma-devel, ZrenBot,

D5953: Implement the new panel icon size ceiling also for Input Method Panel.

2017-05-23 Thread Eike Hein
hein added a comment. This is a good first start but creates some new problems due to the convoluted layout code in the applet: When the panel is really small and forces things to be smaller than the preferred size, the icons shrink further but the spacing between them doesn't adjjust anymor

D5953: Implement the new panel icon size ceiling also for Input Method Panel.

2017-05-23 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It was done for various other applets but not this. BUG:378443 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5953 AFFECTED FILES applets/

D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a8d9038a592e: Implement the new panel icon size ceiling also for Activities. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5950?vs=14786

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b45cb75675c9: Implement the new panel icon size ceiling also for Kickoff. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5949?vs=14785&id

D5951: Implement the new panel icon size ceiling also for Bluetooth.

2017-05-23 Thread Eike Hein
hein updated this revision to Diff 14788. hein added a comment. Fix. REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5951?vs=14787&id=14788 BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5951 AFFECTED FILES src/applet/package/conte

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment. They seem to use the default compact repr and already work. Trickier question is what to do about Folder View, and also Kimpanel is really broken still and a lot more complex to fix. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://p

D5951: Implement the new panel icon size ceiling also for Bluetooth.

2017-05-23 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It was done for various other applets but not this. BUG:378443 REPOSITORY R97 Bluedevil BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5951 AFFECTED FILES src/applet/pac

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Kai Uwe Broulik
broulik added a comment. Indeed, might need a concept of some softer limit, so it won't grow the icon (which is what we're trying here) but still has it expand above a given threshold. I don't think Kickoff was that usable (or nice to look at, rather) in a panel, so fine with me on 5.10.

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment. Thx for the accept. I think it may be possible to write smarter code that does something like "look at the switchWidth/switchHeight, and if without the size limit they would be reached, drop the limit" or something ... and manage the content and the layout sizes in

D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5950 To: hein, #plasma, mart, broulik Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, je

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fine with me, was just wondering. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5949 To: hein, #plasma, mart, broulik Cc: broulik,

D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Eike Hein
hein added a comment. NOTE: We are tagging 5.10 very soon. If this is accepted (and it should be, as it is in plasma-desktop and we're advertising this in the release notes) and I am for some reason unavailable and not doing it, please make sure and take care of pushing this into the 5.10 br

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment. It doesn't, and so far the consensus on https://phabricator.kde.org/tag/plasma/ when discussing this has been that we care more about fixing the usual vertical panel use case than a Kickoff sidebar. It's probably also good for Latte Dock where they have problems with t

D5950: Implement the new panel icon size ceiling also for Activities.

2017-05-23 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It was done for various other applets but not this. BUG:378443 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5950 AFFECTED FILES applets/

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Kai Uwe Broulik
broulik added a comment. Can you verify that a thick (vertical) panel still gives you an expanded Kickoff? That was the reason I didn't implement this for FolderView. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5949 To: hein, #plasma, mart Cc: broulik, pl

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein added a comment. NOTE: We are tagging 5.10 very soon. If this is accepted (and it should be, as this is the default launcher, and this is a feature we're advertising in the release notes) and I am for some reason unavailable and not doing it, please make sure and take care of pushing th

D5949: Implement the new panel icon size ceiling also for Kickoff.

2017-05-23 Thread Eike Hein
hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It was done for various other applets but not this. BUG:378443 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5949 AFFECTED FILES applets/

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #45 from maxp...@gmail.com --- I have discovered that konqueror works fine. I can make folders with it, change names etc. Nothing is greyed out in the root share. This is without any patch or anything. Interestingly enough konquerors file m

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #44 from Luca Beltrame --- (In reply to madcatx from comment #43) > Is it just me or is there currently no obvious way how to get a phabricator > account? Thanks... Please register on identity.kde.org, then you can use the "Login with LDAP

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #43 from madc...@atlas.cz --- (In reply to Luca Beltrame from comment #30) > If you want the developers to look at the patch, please submit it to > https://phabricator.kde.org. Patches in Bugzilla unfortunately tend to get > lost. Is it just

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #42 from madc...@atlas.cz --- I've done a bit more thorough investigation to see how the access permissions on UDSEntry actually propagate. Here is what I can tell so far: Current behavior: When browsing a Windows network in Dolphin, you can

Re: Plasma Vault

2017-05-23 Thread Ivan Čukić
> Good. I didn't catch the "instead", that worried me. > Now I'm back to Zen. :) You know I'm not sane, but I'm not that insane either ;)

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #41 from tempel.jul...@gmail.com --- Would this patch also fix the behavior that files like large videos are first copied to the client system before they can be watched? This is another _HUGE_ restriction of the current Samba share support o

D5757: add requestToggleKeepAbove/below

2017-05-23 Thread Eike Hein
hein accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5757: add requestToggleKeepAbove/below

2017-05-23 Thread Marco Martin
mart added a comment. ping? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D5012: Delay notifications until desktop session has loaded

2017-05-23 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D5012#111331, @davidedmundson wrote: > There's no need for the .service file to match the dbus service name > > We change that, we get no file colision. > I wrote a patch on Friday when someone told me on irc, but hadn't tested

D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Leszek Lesner
leszeklesner updated this revision to Diff 14776. leszeklesner added a comment. Fixed qDebug typo. REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5942?vs=14772&id=14776 REVISION DETAIL https://phabricator.kde.org/D5942 AFFECTED FILES src/helper.c

D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > helper.cpp:70 > +QByteArray data; > +qDebug() << "Running update-initramfs --list default.plymouth now"; > +checkProcess.start("update-alternatives --list default.plymouth"); Should be `update-alternatives` here. REPOSITORY

D5927: improve positioning for highlight in systray

2017-05-23 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R120:40cc6c359cb5: improve positioning for highlight in systray (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5927?vs=14766&id=14775

Re: kdereview: qqc2-desktop-style

2017-05-23 Thread Marco Martin
On Sun, May 21, 2017 at 7:16 PM, Albert Astals Cid wrote: > if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}") >message(FATAL_ERROR "climbinggrades bla bla bla.") > endif() > > This is not climbinggrades ;) thanks, fixed -- Marco Martin

Plasma 5.8.7 LTS

2017-05-23 Thread Jonathan Riddell
Plasma 5.8.7 LTS tars are available now with three months' worth of bug fixes https://www.kde.org/announcements/plasma-5.8.7.php

D5012: Delay notifications until desktop session has loaded

2017-05-23 Thread David Edmundson
davidedmundson added a comment. There's no need for the .service file to match the dbus service name We change that, we get no file colision. I wrote a patch on Friday when someone told me on irc, but hadn't tested because I had to rebuild something. I'm back tomorrow, will upload the

D5937: No longer build Plasmate by default

2017-05-23 Thread Jonathan Riddell
jriddell added a comment. rather than disable the build I've put it into a separate repo kde:plasmate and removed it from kde:plasma-sdk both Plasma/5.10 and master branches REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade

D5937: No longer build Plasmate by default

2017-05-23 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Plasmate got moved into own repo now, discarding. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade, jriddell, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, l

D5012: Delay notifications until desktop session has loaded

2017-05-23 Thread Valerio Pilo
vpilo added a comment. In https://phabricator.kde.org/D5012#110815, @lbeltrame wrote: > Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch. I wouldn't know what course of action would b

Minutes Monday Plasma Meeting

2017-05-23 Thread Sebastian Kügler
We met, and I almost forgot to send the minutes! Here we go! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 21-35-2017 Present: notmart, Sho, bshah, sebas notmart: * fix kirigami2 pagerow tests https://phabricator.kde.org/D5868 Diff 5868 "make pagerow test pass" [Closed] http

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Martin Samek
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #40 from Martin Samek --- For some reason in my case attempt to access smb share eats 4 cores at 100% 3317 marsark 20 0 527504 26620 22188 R 100,0 0,2 0:32.47 smb.so 3305 marsark 20 0 527500 26616 22188 R 99,7 0,2

D5937: No longer build Plasmate by default

2017-05-23 Thread Jonathan Riddell
jriddell added a comment. There is a new git repo intended for this, kde:plasmate, I'll ask on mailing list if it's better to use that or just disable REPOSITORY R118 Plasma SDK BRANCH dontbuildplasmatebydefault REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma,

D5943: Set kauth timeout to timeout for the update-initramfs -u process

2017-05-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D5943 To: leszeklesner, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lu

D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D5942 To: leszeklesner, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lu

D5927: improve positioning for highlight in systray

2017-05-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH systray REVISION DETAIL https://phabricator.kde.org/D5927 To: mvourlakos, #plasma, mart, davidedmundson Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-moha

Re: Plasma Vault

2017-05-23 Thread Sebastian Kügler
On dinsdag 23 mei 2017 10:26:01 CEST Ivan Čukić wrote: > > will still make kded5 spin at 100%, and we're planning to release that > > code? > > Of course not - as I said, it will print out the proper message > instead of making CPUs burn. Good. I didn't catch the "instead", that worried me. Now I

D5937: No longer build Plasmate by default

2017-05-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK BRANCH dontbuildplasmatebydefault REVISION DETAIL https://phabricator.kde.org/D5937 To: kossebau, #plasma, sandroandrade, jriddell, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff,

D5943: Set kauth timeout to timeout for the update-initramfs -u process

2017-05-23 Thread Leszek Lesner
leszeklesner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We need to set the timeout for kauth to at least the same as that for the update-initramfs -u process (which is 6msec) otherwise DBUS

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #39 from madc...@atlas.cz --- (In reply to Christoph Feck from comment #37) > > kio_smb sets the permissions on the UDSEntries correctly but Dolphin seems > > to have a mind of its own. > > In other words, using Dolphin copying fails, but u

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #38 from madc...@atlas.cz --- Created attachment 105687 --> https://bugs.kde.org/attachment.cgi?id=105687&action=edit Debugging patch If there is anybody able to reproduce the problem reliably, there is a small testing patch that dumps the

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #37 from Christoph Feck --- > kio_smb sets the permissions on the UDSEntries correctly but Dolphin seems to > have a mind of its own. In other words, using Dolphin copying fails, but using "kioclient5 cp" works? -- You are receiving this

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #36 from madc...@atlas.cz --- Thanks, I figured that the logs are dumped through systemd already. This still does not answer the question where does Dolphin get the access permissions info from. Either some other layer messes with them along

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #35 from Elvis Angelaccio --- (In reply to madcatx from comment #27) > Created attachment 105682 [details] > Allow write access to root samba share > > The code still does not work entirely as expected - I am allowed to try to > write into

D5942: Check if plymouth file is known to update-alternatives before setting

2017-05-23 Thread Leszek Lesner
leszeklesner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the plymouth theme is not known to update-alternatives trying to execute update-alternatives --set will always fail. As plymouth kc

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-23 Thread Martin Flöser
graesslin added a comment. I wouldn't call it color correction as we used to have a mechanism called color correction in the past which did something very different. Personal suggestion: gamma correction or color temperature correction. Sorry cannot do a full review for the next few week

Re: Plasma Vault

2017-05-23 Thread Ivan Čukić
> It could still benefit from a cmake message of missing runtime dependencies. I agree. Will see to add it soon. Cheers, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3 45DF C9C5 77AF 0A37 240A

Re: Plasma Vault

2017-05-23 Thread Jonathan Riddell
On Mon, May 22, 2017 at 07:08:48PM +0200, Ivan Čukić wrote: > Thanks for this. I had problems with the docker image, so I succeeded > in reproducing the issue in VBox. > > I'll push the fix soon. Mind that it will still not work in Neon (old > version of encfs and no version of cryfs in main repos

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #34 from madc...@atlas.cz --- There has got to be something else going in. kio_smb sets the permissions on the UDSEntries correctly but Dolphin seems to have a mind of its own. -- You are receiving this mail because: You are the assignee fo

Re: Plasma Vault

2017-05-23 Thread Ivan Čukić
> will still make kded5 spin at 100%, and we're planning to release that > code? Of course not - as I said, it will print out the proper message instead of making CPUs burn. Cheers, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3 45DF C9C5 77AF

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Bronson
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #33 from Bronson --- ok ive ran the makepkg command(assuming this also will install the package). Rebooted, and still have the same bug present in dolphin... -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Bronson
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #32 from Bronson --- cant edit my last comment. Got around it with: gpg --recv-keys 3A6A4DB839EAA6D7 -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Bronson
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #31 from Bronson --- (In reply to madcatx from comment #28) > Created attachment 105683 [details] > Patched Arch Linux PKGBUILG > > Archers are welcome to try this patched PKGBUILD. I get the following error with the PKGBUILD (just running

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #30 from Luca Beltrame --- If you want the developers to look at the patch, please submit it to https://phabricator.kde.org. Patches in Bugzilla unfortunately tend to get lost. -- You are receiving this mail because: You are the assignee f

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 madc...@atlas.cz changed: What|Removed |Added Attachment #105680|0 |1 is obsolete|

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #28 from madc...@atlas.cz --- Created attachment 105683 --> https://bugs.kde.org/attachment.cgi?id=105683&action=edit Patched Arch Linux PKGBUILG Archers are welcome to try this patched PKGBUILD. -- You are receiving this mail because: Y

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #27 from madc...@atlas.cz --- Created attachment 105682 --> https://bugs.kde.org/attachment.cgi?id=105682&action=edit Allow write access to root samba share The code still does not work entirely as expected - I am allowed to try to write i