Re: Plasma 5.10 voice over text

2017-05-17 Thread Łukasz Sawicki
>You could show the virtual keyboard on the lock screen nevertheless. I >understand that the swipe in gesture is not possible to show properly, >but the things which can be shown without need for interaction could be >done. I added some info about virtual keyboard.

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread Andreas Sturmlechner
asturmlechner added a comment. Should this be picked for 5.8 branch as well? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreute

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R98:0a34d8667c6e: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally (authored by asturmlechner). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.or

Re: Plasma 5.10 voice over text

2017-05-17 Thread Martin Flöser
Am 2017-05-17 14:03, schrieb Łukasz Sawicki: This explains what it is, it doesn't explain what's changed since the last release. "Folder View is now the default desktop ..." Changed to "Due to the popular demand we changed to Folder View as the default desktop which allows users to put whateve

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread David Edmundson
davidedmundson added a comment. Yes You should see "Differential Revision: " in the commit message before pushing. REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread Andreas Sturmlechner
asturmlechner added a comment. Yes, I have commit access - it just happens to be my first use of arcanist instead of rbtools - can I git push straight to Plasma/5.10 branch? REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturml

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-17 Thread Sebastian Kügler
sebas abandoned this revision. sebas added a comment. Okay, thanks David. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, les

D5888: Get rid of extra margins

2017-05-17 Thread Alexander Volkov
This revision was automatically updated to reflect the committed changes. Closed by commit R104:96f3e96d3c45: Get rid of extra margins (authored by volkov). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5888?vs=14632&id=14637 REVISION DETAIL https://phabri

D5886: Use QFormLayout for sliders

2017-05-17 Thread Alexander Volkov
This revision was automatically updated to reflect the committed changes. Closed by commit R100:f5905ee018cd: Use QFormLayout for sliders (authored by volkov). REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5886?vs=14627&id=14636 REVISION DETAIL https://phab

Re: [wayland] some findings about weird shadows in wayland

2017-05-17 Thread David Edmundson
There was a potentially relevant change in plasma-integration last night. Make sure you have that before spending longer on it. I don't have this issue on my tooltips hovering over the plasmoids in the panel. Do you have it reproducible on any of the manual dialog tests in plasma-framework? David

[wayland] some findings about weird shadows in wayland

2017-05-17 Thread Marco Martin
Hi all, since i don't have much time to look in it the next few days, i'm dumping here some interesting findings i did on an issue i'm having on kwin/wayland (qt 5.9) I'll continue to look into that, but if this immediately rings a bell to someone, even better. Sometimes shadows (especially of p

Re: Plasma 5.10 voice over text

2017-05-17 Thread Łukasz Sawicki
2017-05-17 13:31 GMT+01:00 Łukasz Sawicki : > 2017-05-17 13:03 GMT+01:00 Łukasz Sawicki : > >>Could you run this by kde-promo as well? We should try to keep to keep the >>promo people closely involved for this kind of work. > > There is already a phabricator task https://phabricator.kde.org/T6065.

D5748: workaround for correct wayland positioning

2017-05-17 Thread David Edmundson
davidedmundson added a comment. edit, ignore that last comment. I hadn't seen it was a QPointer. Just my comment about checking on all other plaforms remains. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5748 To: mart, #plasma, #plasma_on_wayland Cc:

Re: Plasma 5.10 voice over text

2017-05-17 Thread Łukasz Sawicki
2017-05-17 13:03 GMT+01:00 Łukasz Sawicki : >Could you run this by kde-promo as well? We should try to keep to keep the >promo people closely involved for this kind of work. There is already a phabricator task https://phabricator.kde.org/T6065. Since Phabricator will be used as our main communica

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-17 Thread David Edmundson
davidedmundson added a comment. Do you have commit access? REPOSITORY R98 Breeze for Gtk BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5853 To: asturmlechner, #plasma, mart Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensr

D5888: Get rid of extra margins

2017-05-17 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D5888 To: volkov, #plasma, davidedmundson Cc: mart, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliez

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-17 Thread David Edmundson
davidedmundson added a comment. I merged a different thing that Martin was happy wtih. This is closable. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, Zr

Re: Plasma 5.10 voice over text

2017-05-17 Thread Sebastian Kügler
On dinsdag 16 mei 2017 23:25:11 CEST Łukasz Sawicki wrote: > Here is a script/voice over text for Plasma 5.10 video. It is heavily > based on Plasma 5.10 beta announcement. Please check it for grammar, > typos etc. > > https://notes.kde.org/p/Plasma_5.10_script > > If you think that I missed some

Re: Plasma 5.10 voice over text

2017-05-17 Thread Łukasz Sawicki
>This explains what it is, it doesn't explain what's changed since the last >release. >"Folder View is now the default desktop ..." Changed to "Due to the popular demand we changed to Folder View as the default desktop which allows users to put whatever files or folders they want easy access to"

D5888: Get rid of extra margins

2017-05-17 Thread Alexander Volkov
volkov updated this revision to Diff 14632. volkov added a comment. set margin size explicitly instead of using magic value -1 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5888?vs=14598&id=14632 BRANCH master REVISION DETAIL https://phabricator.kde.

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-17 Thread Christoph Feck
cfeck added a comment. Konsole could also be affected, see https://bugs.kde.org/show_bug.cgi?id=379795 Timing indicate all reporters use newest frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks, dav

D5888: Get rid of extra margins

2017-05-17 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > volkov wrote in widget.cpp:82 > To remove redundant spacing from the bottom part, you can see it on the > screenshot. i would prefer the margins to be all zero, that -1 looks a bit magic, even if would make things look slightly better, i vote for c

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-17 Thread Marco Martin
mart added a comment. possible fix https://phabricator.kde.org/D5900 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson Cc: lbeltrame, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, p

D5888: Get rid of extra margins

2017-05-17 Thread Alexander Volkov
volkov added inline comments. INLINE COMMENTS > davidedmundson wrote in widget.cpp:82 > why? To remove redundant spacing from the bottom part, you can see it on the screenshot. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D5888 To: volkov, #plasma Cc: mart, davided

D5888: Get rid of extra margins

2017-05-17 Thread Alexander Volkov
volkov added a comment. F3757149: reduce-spacing.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D5888 To: volkov, #plasma Cc: mart, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreu

D5886: Use QFormLayout for sliders

2017-05-17 Thread Alexander Volkov
volkov updated this revision to Diff 14627. volkov added a comment. use QSpacerItem instead of QWidget for spacing REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5886?vs=14596&id=14627 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5886 AF

[kio-extras] [Bug 379902] Samba shares no longer work

2017-05-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=379902 eva...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[kio-extras] [Bug 379902] Samba shares no longer work

2017-05-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=379902 --- Comment #2 from eva...@gmail.com --- Thanks for your reply - I had left the office before I read it. I had to reboot my laptop into Windows at home to use a specific piece of software so obviously I have a fresh boot of Mint this morning, and the boo

D5888: Get rid of extra margins

2017-05-17 Thread Marco Martin
mart added a comment. when visual changes are involved, always include a screenshot in the review request REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D5888 To: volkov, #plasma Cc: mart, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-m

D5888: Get rid of extra margins

2017-05-17 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > widget.cpp:82 > QVBoxLayout *vbox = new QVBoxLayout(widget); > +vbox->setContentsMargins(0, -1, 0, 0); > widget->setLayout(vbox); why? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D5888 To: volkov

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-17 Thread Luca Beltrame
lbeltrame added a comment. Unfortunately this change causes crashes in KPart-using applications that do stuff with their QActions with Qt 5.9. okular and kontact are affected, at least. This is a typical backtrace (got this from Eike, but I have the same): #0 QAction::setEnabled